From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id B789E1581E7 for ; Fri, 26 Apr 2024 17:53:16 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1DCC4E29CB; Fri, 26 Apr 2024 17:53:12 +0000 (UTC) Received: from tupone.it (tupone.it [95.216.99.101]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A0A69E29C0 for ; Fri, 26 Apr 2024 17:53:11 +0000 (UTC) Received: from alfredo.tupone.it (unknown [IPv6:2a01:e11:b:c630:2e0:4cff:fe69:49b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by tupone.it (Postfix) with ESMTPSA id ADD92840058; Fri, 26 Apr 2024 19:53:09 +0200 (CEST) Date: Fri, 26 Apr 2024 19:53:06 +0200 From: Alfredo Tupone To: Arsen =?UTF-8?B?QXJzZW5vdmnEhw==?= Cc: gentoo-dev@lists.gentoo.org, toolchain@gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/3] To make "tc_has_feature ada" actually work Message-ID: <20240426195306.7700e271@alfredo.tupone.it> In-Reply-To: <87h6foldy3.fsf@gentoo.org> References: <20240425154537.32502-1-tupone@gentoo.org> <87h6foldy3.fsf@gentoo.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 4ad22bb1-a33b-45dc-9f0a-db1d84324565 X-Archives-Hash: 045531069f47d61e1b16b77b763c3984 On Fri, 26 Apr 2024 10:34:44 +0200 Arsen Arsenovi=C4=87 wrote: > looks OK at a glance, but could you summarize the issues the patch set > fixes in the commit messages (and reword them to follow convention > generally)? it is important to have context while looking at a git > log. > > - IUSE+=3D" ada" > > + IUSE+=3D" ada" TC_FEATURES+=3D( ada ) =20 The change is about adding TC_FEATURES+=3D( ada ) Some lines towards the end there is=20 # TODO: Add a pkg_setup & pkg_pretend check for whether the active compiler # supports Ada. if tc_has_feature ada ; then BDEPEND+=3D" ada? ( || ( sys-devel/gcc[ada] dev-lang/gnat-gpl[ada] ) )" fi it looks to me that if TC_FEATURES+=3D( ada ) is missing, that dependency is not added >=20 > does this apply for all versions of GCC? I really don't know. Ada source are provided with gcc-8 too (the oldest version in the tree). I personally built gcc-10..13