From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9FF16158041 for ; Fri, 29 Mar 2024 03:54:47 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 02FC0E2A19; Fri, 29 Mar 2024 03:54:43 +0000 (UTC) Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B4320E29EC for ; Fri, 29 Mar 2024 03:54:42 +0000 (UTC) Received: by mail-yb1-xb32.google.com with SMTP id 3f1490d57ef6-db4364ecd6aso1550021276.2 for ; Thu, 28 Mar 2024 20:54:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711684481; x=1712289281; darn=lists.gentoo.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ZXyWH/jmnnaG2hMvIJPmb4I0SbgY7NvHTvNVkK2MbSE=; b=NKb7IA4uE1l50Hy1sQ4/lTFecaMEJtAU2sch3VCY5wdDiQ2J7O7x1vQDE+3SEcARUI RtrqMH/KPuOwNpc9PbzM4XG+VjhnqoGCeyuImUI0oBPNlUWew5tsRwC0esDI65wIn69B lNv5Y9UPaw50F36rYPI+pxtSK/sly8GHe2uRe2MFCTo5q3hhXaCEJKJrKiwp39chE/dL bkrnqnpFLFRBq3AvY60b3SKFTwvlDn+lkryJRhVZLwWRil+vxKKkYRnSQ4zw+rgrgUfD kRl9Km2B4xi3xuFZlAF+/lG0rPfDy8/GBNxvLstVdvtbnMwwfjnHaO3bwapHNBAD6T3b AA2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711684481; x=1712289281; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZXyWH/jmnnaG2hMvIJPmb4I0SbgY7NvHTvNVkK2MbSE=; b=GcNG7cNAbplHHceS6ryvmT3OxPrN+/cUTtGwTL0jHPgIuvTqMGu2Q/SJj3XcYL1ISI 6ErEGAoUuvr1Dx12fmw4aqRiQ14XCVxbvEbGZLPXV/b0y2IF2thDxYsaFeKRNP2qHUlc BQxkAZJhNpDjYgQ1OaLkvrIMesTTBO8vN8y0X78mn2huMYocFuRk02LKhYqWsbtCohYj VretOo4asbgDsczXlIcs+8MTm5CaMoFkLq4H3MdWaMIulL3nPfkiLN/JY9meNIQs73It CVmg75jM66vb6RxImP1/8+KTpj2oe4g1UK85qKRSA3MnYL9J5yBLxEGhXVs9FadNOuRN 7m0g== X-Gm-Message-State: AOJu0YwudCIAnSOokB36KoEFOOjXBVXWtToI04/mW5XM5jlqsaK3BPDQ WHVag2uDJJ00FNISyRIaAs6qNeYYn3GW6vU+1HiJNIjg9MnAJzxHhChaup9v X-Google-Smtp-Source: AGHT+IH3xM92rIllbwm/f8OCcyA0IWy8c8riYZrq5ywZd2IIXQEiqoyeeg5WgEOKb6R5m76hMtSNjA== X-Received: by 2002:a25:1344:0:b0:dcc:5e60:6fc7 with SMTP id 65-20020a251344000000b00dcc5e606fc7mr1181992ybt.55.1711684480712; Thu, 28 Mar 2024 20:54:40 -0700 (PDT) Received: from acleverhostname.hsd1.md.comcast.net ([2601:14d:4e00:d000::8299]) by smtp.gmail.com with ESMTPSA id mv5-20020a056214338500b0068fdb03a3a3sm1249775qvb.95.2024.03.28.20.54.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 20:54:40 -0700 (PDT) From: Eli Schwartz To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] [PATCH] metadata/install-qa-check.d: make the FHS paths warning easier to read Date: Thu, 28 Mar 2024 23:54:35 -0400 Message-ID: <20240329035439.11381-1-eschwartz93@gmail.com> X-Mailer: git-send-email 2.43.2 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: 0509ec09-fdc0-4b7d-a4ce-e9febaef8d45 X-Archives-Hash: fa08f0011beb55ac915174d9f642cae3 * QA Notice: The ebuild is installing to one or more unexpected paths: * * /var/tmp/portage/sys-cluster/legion-9999/image/usr/bin/legion_prof_files * /var/tmp/portage/sys-cluster/legion-9999/image/usr/bin/serializer_examples * * Please fix the ebuild to use correct FHS/Gentoo policy paths. This message is hard to understand. Is it saying that the resulting package contains files prefixed with ${D} which would be immensely broken? Is it saying that these paths are *directories* and the FHS does not approve of directories in /usr/bin/*/? In fact, it's the latter. Fix this in two ways: - clarify that it's an unexpected directory, not just some kind of path - strip ${D} so that people can better visualize what sort of path gets installed. This has the downside of not being able to copy/paste the path in order to inspect the image directory, but I think this is a very small downside. Usually by the time you see this message, portage has cleaned up. And if it hasn't, you can still copy/paste that from: Completed installing sys-cluster/legion-9999 into /var/tmp/portage/sys-cluster/legion-9999/image Signed-off-by: Eli Schwartz --- metadata/install-qa-check.d/08gentoo-paths | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/metadata/install-qa-check.d/08gentoo-paths b/metadata/install-qa-check.d/08gentoo-paths index 5b8607fd5f96..0b92a7a1c132 100644 --- a/metadata/install-qa-check.d/08gentoo-paths +++ b/metadata/install-qa-check.d/08gentoo-paths @@ -70,9 +70,9 @@ gentoo_path_check() { # report # ------ if [[ -n ${bad_paths[@]} ]]; then - eqawarn "QA Notice: The ebuild is installing to one or more unexpected paths:" + eqawarn "QA Notice: The ebuild is installing to one or more unexpected directories:" eqawarn - eqatag -v non-gentoo-paths "${bad_paths[@]}" + eqatag -v non-gentoo-paths "${bad_paths[@]#${D%/}}" eqawarn eqawarn "Please fix the ebuild to use correct FHS/Gentoo policy paths." fi -- 2.43.2