public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Eli Schwartz <eschwartz93@gmail.com>
To: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] [PATCH v2 0/5] eclass updates for meson <> distutils <> LTO
Date: Tue, 20 Feb 2024 01:14:40 -0500	[thread overview]
Message-ID: <20240220063504.3959739-1-eschwartz93@gmail.com> (raw)
In-Reply-To: <1b9b73ea-9895-4680-aab7-117e47c9cc36@gmail.com>

v2 answers the question: how to deal with accumulated mesonargs without
actually *running* meson_src_configure before gpep517

Eli Schwartz (5):
  meson.eclass: wire up LTO support directly into the meson options
  meson.eclass: prefer -D buildtype instead of --buildtype
  meson.eclass: refactor src_configure into a setter function
  distutils-r1.eclass: wire up meson-python to meson.eclass
  distutils-r1.eclass: fix src_configure to handle flag-o-matic
    correctly

 eclass/distutils-r1.eclass | 13 ++++--
 eclass/meson.eclass        | 85 +++++++++++++++++++++++++++-----------
 2 files changed, 70 insertions(+), 28 deletions(-)

Range-diff against v1:
1:  aac9d1516675 = 1:  aac9d1516675 meson.eclass: wire up LTO support directly into the meson options
-:  ------------ > 2:  cf98596d9bd1 meson.eclass: prefer -D buildtype instead of --buildtype
-:  ------------ > 3:  7ac90f1b2d88 meson.eclass: refactor src_configure into a setter function
2:  bcbec23f5c76 ! 4:  e8387e8dec72 distutils-r1.eclass: wire up meson-python to meson.eclass
    @@ Commit message
     
         The meson-python build backend -- as the name suggests -- uses meson
         under the hood. We have a meson eclass which does lots of useful things
    -    pertinent to meson. Make sure it gets invoked.
    +    pertinent to meson. Make sure it gets invoked, by prying out the options
    +    that meson_src_configure would use and setting passing them as our seed
    +    values for gpep517.
     
         Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
     
    @@ eclass/distutils-r1.eclass: distutils_pep517_install() {
      			)
      			;;
      		meson-python)
    -+			meson_src_configure "${DISTUTILS_ARGS[@]}"
    ++			local mesonargs=()
    ++			setup_meson_src_configure "${DISTUTILS_ARGS[@]}"
      			local -x NINJAOPTS=$(get_NINJAOPTS)
      			config_settings=$(
    - 				"${EPYTHON}" - "${DISTUTILS_ARGS[@]}" <<-EOF || die
    -@@ eclass/distutils-r1.eclass: distutils_pep517_install() {
    - 					ninjaopts = shlex.split(os.environ["NINJAOPTS"])
    - 					print(json.dumps({
    - 						"builddir": "${BUILD_DIR}",
    --						"setup-args": sys.argv[1:],
    - 						"compile-args": ["-v"] + ninjaopts,
    - 					}))
    - 				EOF
    +-				"${EPYTHON}" - "${DISTUTILS_ARGS[@]}" <<-EOF || die
    ++				"${EPYTHON}" - "${mesonargs[@]}" <<-EOF || die
    + 					import json
    + 					import os
    + 					import shlex
-:  ------------ > 5:  a30c280f4573 distutils-r1.eclass: fix src_configure to handle flag-o-matic correctly
-- 
2.43.0



  reply	other threads:[~2024-02-20  6:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20  4:26 [gentoo-dev] [PATCH 0/3] eclass updates for meson <> distutils <> LTO Eli Schwartz
2024-02-20  4:26 ` [gentoo-dev] [PATCH 1/3] meson.eclass: wire up LTO support directly into the meson options Eli Schwartz
2024-02-20  5:58   ` Mike Gilbert
2024-02-20  6:09     ` Eli Schwartz
2024-02-20  6:24       ` Mike Gilbert
2024-02-20  6:33         ` Eli Schwartz
2024-02-20  6:37           ` Eli Schwartz
2024-02-20  6:40           ` Sam James
2024-02-20  4:26 ` [gentoo-dev] [PATCH 2/3] distutils-r1.eclass: wire up meson-python to meson.eclass Eli Schwartz
2024-02-20  4:42   ` Sam James
2024-02-20  5:12     ` Eli Schwartz
2024-02-20  6:14       ` Eli Schwartz [this message]
2024-02-20  6:14         ` [gentoo-dev] [PATCH v2 1/5] meson.eclass: wire up LTO support directly into the meson options Eli Schwartz
2024-02-20  6:14         ` [gentoo-dev] [PATCH v2 2/5] meson.eclass: prefer -D buildtype instead of --buildtype Eli Schwartz
2024-02-20  6:14         ` [gentoo-dev] [PATCH v2 3/5] meson.eclass: refactor src_configure into a setter function Eli Schwartz
2024-02-20  6:42           ` [gentoo-dev] " Eli Schwartz
2024-02-20  6:14         ` [gentoo-dev] [PATCH v2 4/5] distutils-r1.eclass: wire up meson-python to meson.eclass Eli Schwartz
2024-02-20  6:55           ` Michał Górny
2024-02-20 20:45             ` Eli Schwartz
2024-02-20  6:14         ` [gentoo-dev] [PATCH v2 5/5] distutils-r1.eclass: fix src_configure to handle flag-o-matic correctly Eli Schwartz
2024-02-20  6:28   ` [gentoo-dev] [PATCH 2/3] distutils-r1.eclass: wire up meson-python to meson.eclass Michał Górny
2024-02-20  4:26 ` [gentoo-dev] [PATCH 3/3] distutils-r1.eclass: fix src_configure to handle flag-o-matic correctly Eli Schwartz
2024-02-20  6:35   ` Michał Górny
2024-02-20  4:41 ` [gentoo-dev] [PATCH 0/3] eclass updates for meson <> distutils <> LTO Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240220063504.3959739-1-eschwartz93@gmail.com \
    --to=eschwartz93@gmail.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox