From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 38ABE15838C for ; Thu, 25 Jan 2024 15:45:05 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8DBDBE2A83; Thu, 25 Jan 2024 15:45:00 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 32C43E2A54 for ; Thu, 25 Jan 2024 15:45:00 +0000 (UTC) From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Subject: [gentoo-dev] [PATCH 1/2] gnome2-utils.eclass: Make *_gdk_pixbuf_update work unconditionally Date: Thu, 25 Jan 2024 16:44:52 +0100 Message-ID: <20240125154453.22915-1-mgorny@gentoo.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 78726989-4ff7-4204-84a5-47f6148ae86c X-Archives-Hash: 048a6c7718dde63e77c8432d35bab2b7 Remove the GNOME2_ECLASS_GDK_PIXBUF_LOADERS condition that required calling gnome2_gdk_pixbuf_savelist prior to gnome2_gdk_pixbuf_update. The actual list was never used, and all the ebuilds calling the function in Gentoo contain conditions to avoid calling the function when loaders are not built. Closes: https://bugs.gentoo.org/922500 Signed-off-by: Michał Górny --- eclass/gnome2-utils.eclass | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/eclass/gnome2-utils.eclass b/eclass/gnome2-utils.eclass index 3a92a43e306a..bbee2a419dfc 100644 --- a/eclass/gnome2-utils.eclass +++ b/eclass/gnome2-utils.eclass @@ -1,4 +1,4 @@ -# Copyright 1999-2023 Gentoo Authors +# Copyright 1999-2024 Gentoo Authors # Distributed under the terms of the GNU General Public License v2 # @ECLASS: gnome2-utils.eclass @@ -363,11 +363,6 @@ gnome2_gdk_pixbuf_update() { local updater="${EROOT%/}/usr/bin/${CHOST}-gdk-pixbuf-query-loaders" [[ -x ${updater} ]] || updater="${EROOT%/}/usr/bin/gdk-pixbuf-query-loaders" - if [[ -z ${GNOME2_ECLASS_GDK_PIXBUF_LOADERS} ]]; then - debug-print "gdk-pixbuf loader cache does not need an update" - return - fi - if tc-is-cross-compiler ; then ewarn "Updating of gdk-pixbuf loader cache skipped due to cross-compilation." ewarn "You might want to run gdk-pixbuf-query-loaders manually on the target" -- 2.43.0