[gentoo-dev] [PATCH] install-qa-check.d/60python-site: Check for deprecated .egg* files

[gentoo-dev] [PATCH] install-qa-check.d/60python-site: Check for deprecated .egg* files

[Michał Górny]

Check for deprecated .egg and .egg-info files.  While at it, fix stray
file check not to barf on *.egg files.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
 metadata/install-qa-check.d/60python-site | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/metadata/install-qa-check.d/60python-site b/metadata/install-qa-check.d/60python-site
index afef445ad715..e4748b75fdfe 100644
--- a/metadata/install-qa-check.d/60python-site
+++ b/metadata/install-qa-check.d/60python-site
@@ -31,6 +31,7 @@ python_site_check() {
 	local stray=()
 
 	local bad_versions=()
+	local eggs=()
 	local outside_site=()
 	local stray_packages=()
 
@@ -79,11 +80,22 @@ python_site_check() {
 				')' -print0
 		)
 
+		# check for deprecated egg format
+		while IFS= read -d $'\0' -r f; do
+			eggs+=( "${f#${ED}}" )
+		done < <(
+			find "${sitedir}" -maxdepth 1 '(' \
+				-name '*.egg-info' -o \
+				-name '*.egg' \
+				')' -print0
+		)
+
 		# check for stray files in site-packages
 		while IFS= read -d $'\0' -r f; do
 			stray_packages+=( "${f#${ED}}" )
 		done < <(
 			find "${sitedir}" -maxdepth 1 -type f '!' '(' \
+					-name '*.egg' -o \
 					-name '*.egg-info' -o \
 					-name '*.pth' -o \
 					-name '*.py' -o \
@@ -194,6 +206,14 @@ python_site_check() {
 		eqatag -v python-site.bad_version "${bad_versions[@]}"
 	fi
 
+	if [[ ${eggs[@]} ]]; then
+		eqawarn
+		eqawarn "QA Notice: The following deprecated .egg or .egg-info files were found."
+		eqawarn "Please migrate the ebuild to use the PEP517 build."
+		eqawarn
+		eqatag -v python-site.egg "${eggs[@]}"
+	fi
+
 	if [[ ${stray_packages[@]} ]]; then
 		eqawarn
 		eqawarn "QA Notice: The following unexpected files/directories were found"
-- 
2.43.0