From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1D61B15803E for ; Sat, 6 Jan 2024 13:45:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 84BA82BC0D7; Sat, 6 Jan 2024 13:44:57 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 372952BC0CA for ; Sat, 6 Jan 2024 13:44:57 +0000 (UTC) From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Subject: [gentoo-dev] [PATCH 4/9] install-qa-check.d/60python-site: Add bad version check Date: Sat, 6 Jan 2024 14:44:41 +0100 Message-ID: <20240106134446.26153-4-mgorny@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240106134446.26153-1-mgorny@gentoo.org> References: <20240106134446.26153-1-mgorny@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 6c3eafe1-3b37-488e-a39d-8f4ff2563ee4 X-Archives-Hash: b972e534f3b66d5deba847fde9ef9a4f This was a case e.g. with =dev-python/pyrqlite-2.2.0. Signed-off-by: Michał Górny --- metadata/install-qa-check.d/60python-site | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/metadata/install-qa-check.d/60python-site b/metadata/install-qa-check.d/60python-site index 459509f8a136..a54dda53a454 100644 --- a/metadata/install-qa-check.d/60python-site +++ b/metadata/install-qa-check.d/60python-site @@ -24,6 +24,7 @@ python_site_check() { local missing=() local stray=() + local bad_versions=() local stray_packages=() # Avoid running the check if sufficiently new gpep517 is not installed @@ -42,6 +43,18 @@ python_site_check() { local sitedir=( "${ED}"/usr/lib/${impl}*/site-packages ) [[ -d ${sitedir} ]] || continue + # check for bad package versions + while IFS= read -d $'\0' -r f; do + bad_versions+=( "${f#${ED}}" ) + done < <( + find "${sitedir}" -maxdepth 1 '(' \ + -name '*-0.0.0.dist-info' -o \ + -name '*-UNKNOWN.dist-info' -o \ + -name '*-0.0.0.egg-info' -o \ + -name '*-UNKNOWN.egg-info' \ + ')' -print0 + ) + # check for stray files in site-packages while IFS= read -d $'\0' -r f; do stray_packages+=( "${f#${ED}}" ) @@ -148,6 +161,14 @@ python_site_check() { eqawarn " https://projects.gentoo.org/python/guide/qawarn.html#compiled-bytecode-related-warnings" fi + if [[ ${bad_versions[@]} ]]; then + eqawarn + eqawarn "QA Notice: The following Python packages were installed with" + eqawarn "invalid/suspicious versions in the site-packages directory:" + eqawarn + eqatag -v python-site.bad_version "${bad_versions[@]}" + fi + if [[ ${stray_packages[@]} ]]; then eqawarn eqawarn "QA Notice: The following unexpected files/directories were found" -- 2.43.0