public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: [gentoo-dev] [PATCH 3/9] distutils-r1.eclass: Stray file check moved to install-qa-check.d
Date: Sat,  6 Jan 2024 14:44:40 +0100	[thread overview]
Message-ID: <20240106134446.26153-3-mgorny@gentoo.org> (raw)
In-Reply-To: <20240106134446.26153-1-mgorny@gentoo.org>

Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
 eclass/distutils-r1.eclass | 33 ---------------------------------
 1 file changed, 33 deletions(-)

diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
index c0d1992ccce0..8dfee7cb9232 100644
--- a/eclass/distutils-r1.eclass
+++ b/eclass/distutils-r1.eclass
@@ -2091,39 +2091,6 @@ _distutils-r1_post_python_install() {
 	if [[ -d ${sitedir} ]]; then
 		_distutils-r1_strip_namespace_packages "${sitedir}"
 
-		local forbidden_package_names=(
-			examples test tests
-			.pytest_cache .hypothesis _trial_temp
-		)
-		local strays=()
-		local p
-		mapfile -d $'\0' -t strays < <(
-			find "${sitedir}" -maxdepth 1 -type f '!' '(' \
-					-name '*.egg-info' -o \
-					-name '*.pth' -o \
-					-name '*.py' -o \
-					-name '*.pyi' -o \
-					-name "*$(get_modname)" \
-				')' -print0
-		)
-		for p in "${forbidden_package_names[@]}"; do
-			[[ -d ${sitedir}/${p} ]] && strays+=( "${sitedir}/${p}" )
-		done
-
-		if [[ -n ${strays[@]} ]]; then
-			eerror "The following unexpected files/directories were found top-level"
-			eerror "in the site-packages directory:"
-			eerror
-			for p in "${strays[@]}"; do
-				eerror "  ${p#${ED}}"
-			done
-			eerror
-			eerror "This is most likely a bug in the build system.  More information"
-			eerror "can be found in the Python Guide:"
-			eerror "https://projects.gentoo.org/python/guide/qawarn.html#stray-top-level-files-in-site-packages"
-			die "Failing install because of stray top-level files in site-packages"
-		fi
-
 		if [[ ! ${DISTUTILS_EXT} && ! ${_DISTUTILS_EXT_WARNED} ]]; then
 			if [[ $(find "${sitedir}" -name "*$(get_modname)" | head -n 1) ]]
 			then
-- 
2.43.0



  parent reply	other threads:[~2024-01-06 13:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-06 13:44 [gentoo-dev] [PATCH 1/9] install-qa-check.d: Generalize 60python-{pyc → site} Michał Górny
2024-01-06 13:44 ` [gentoo-dev] [PATCH 2/9] install-qa-check.d/60python-site: Add invalid site-packages check Michał Górny
2024-01-06 13:44 ` Michał Górny [this message]
2024-01-06 13:44 ` [gentoo-dev] [PATCH 4/9] install-qa-check.d/60python-site: Add bad version check Michał Górny
2024-01-06 13:44 ` [gentoo-dev] [PATCH 5/9] install-qa-check.d/60python-site: Forbid lib & usr package names Michał Górny
2024-01-06 13:44 ` [gentoo-dev] [PATCH 6/9] install-qa-check.d/60python-site: Add check for wrong libdir Michał Górny
2024-01-06 13:44 ` [gentoo-dev] [PATCH 7/9] install-qa-check.d/60python-site: Check for UNKNOWN package name Michał Górny
2024-01-06 13:44 ` [gentoo-dev] [PATCH 8/9] install-qa-check.d/60python-site: Check for out-of-sitepkg install Michał Górny
2024-01-06 13:44 ` [gentoo-dev] [PATCH 9/9] install-qa-check.d/60python-site: allow site-packages/README.txt Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240106134446.26153-3-mgorny@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox