[gentoo-dev] [PATCH] toolchain-funcs.eclass: Remove outdated reference to tc-has-openmp

[gentoo-dev] [PATCH] toolchain-funcs.eclass: Remove outdated reference to tc-has-openmp

[Petr Vaněk]

tc-has-openmp function was deprecated in commit 9bc832c6d39b
("toolchain-funcs.eclass: deprecate tc-has-openmp") and later removed in
commit eb970274d283 ("toolchain-funcs.eclass: remove tc-has-openmp").
Due to this, the reference to it in the tc-check-openmp function has
become redundant and is therefore removed.

Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
---
 eclass/toolchain-funcs.eclass | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/eclass/toolchain-funcs.eclass b/eclass/toolchain-funcs.eclass
index 556bbac35307..8398ee004a7d 100644
--- a/eclass/toolchain-funcs.eclass
+++ b/eclass/toolchain-funcs.eclass
@@ -576,9 +576,7 @@ _tc-has-openmp() {
 # @DESCRIPTION:
 # Test for OpenMP support with the current compiler and error out with
 # a clear error message, telling the user how to rectify the missing
-# OpenMP support that has been requested by the ebuild. Using this function
-# to test for OpenMP support should be preferred over tc-has-openmp and
-# printing a custom message, as it presents a uniform interface to the user.
+# OpenMP support that has been requested by the ebuild.
 #
 # You should test for any necessary OpenMP support in pkg_pretend in order to
 # warn the user of required toolchain changes.  You must still check for OpenMP
-- 
2.41.0

[gentoo-dev] [PATCH] toolchain-funcs.eclass: Remove outdated reference to tc-has-openmp

[Petr Vaněk]

tc-has-openmp function was deprecated in commit 9bc832c6d39b
("toolchain-funcs.eclass: deprecate tc-has-openmp") and later removed in
commit eb970274d283 ("toolchain-funcs.eclass: remove tc-has-openmp").
Due to this, the reference to it in the tc-check-openmp function has
become redundant and is therefore removed.

Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
---
 eclass/toolchain-funcs.eclass | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/eclass/toolchain-funcs.eclass b/eclass/toolchain-funcs.eclass
index 556bbac35307..8398ee004a7d 100644
--- a/eclass/toolchain-funcs.eclass
+++ b/eclass/toolchain-funcs.eclass
@@ -576,9 +576,7 @@ _tc-has-openmp() {
 # @DESCRIPTION:
 # Test for OpenMP support with the current compiler and error out with
 # a clear error message, telling the user how to rectify the missing
-# OpenMP support that has been requested by the ebuild. Using this function
-# to test for OpenMP support should be preferred over tc-has-openmp and
-# printing a custom message, as it presents a uniform interface to the user.
+# OpenMP support that has been requested by the ebuild.
 #
 # You should test for any necessary OpenMP support in pkg_pretend in order to
 # warn the user of required toolchain changes.  You must still check for OpenMP
-- 
2.41.0

Re: [gentoo-dev] [PATCH] toolchain-funcs.eclass: Remove outdated reference to tc-has-openmp

[Petr Vaněk]

On Sun, Sep 17, 2023 at 04:49:41PM +0200, Petr Vaněk wrote:
> tc-has-openmp function was deprecated in commit 9bc832c6d39b
> ("toolchain-funcs.eclass: deprecate tc-has-openmp") and later removed in
> commit eb970274d283 ("toolchain-funcs.eclass: remove tc-has-openmp").
> Due to this, the reference to it in the tc-check-openmp function has
> become redundant and is therefore removed.

There is no difference between two patches I have sent. The second one
was additionally CCed to @MAINTAINER, which I forgot to add in first
attempt.

Petr