From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2E5D1158008 for ; Thu, 15 Jun 2023 16:28:00 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 850E2E09EC; Thu, 15 Jun 2023 16:27:56 +0000 (UTC) Received: from gmmr-4.centrum.cz (gmmr-4.centrum.cz [IPv6:2a00:da80:1:502::8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 434A6E09E4 for ; Thu, 15 Jun 2023 16:27:54 +0000 (UTC) Received: from gmmr-4.centrum.cz (localhost [127.0.0.1]) by gmmr-4.centrum.cz (Postfix) with ESMTP id 43C412B761 for ; Thu, 15 Jun 2023 18:27:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atlas.cz; s=mail; t=1686846473; bh=4vnp87DQo1d1OnVn0Vm9p9nct+dodFBL5boDtE1kPzY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YR74+Ufc7Gn/1vU6UNWpzGCXr3h7RIoRwgzZvgE3bnPeNU0oPwF3Ud93UAbH/dQQE X5RizNNHQUaoS0WYrQWoNvvUBR2QCrdHmaCHcWND8UXALwLZ8oupJknm5Hup0Cz/VJ G8HixSwLMFxRTjZc8q84juE3ge8u3exFQD2S7ieE= Received: from antispam94.centrum.cz (unknown [10.30.208.94]) by gmmr-4.centrum.cz (Postfix) with ESMTP id 427B9201120F for ; Thu, 15 Jun 2023 18:27:53 +0200 (CEST) X-IPAS-Result: =?us-ascii?q?A2CyAAAIO4tk/0vj/y5aHAEBAQEBAQcBARIBAQQEAQFAC?= =?us-ascii?q?YE1BAEBCwGDI4FchFGRVIxmhSiBH4xADwEBAQEBAQEBAQk5CwQBAYFTgzMCh?= =?us-ascii?q?XwmNwYOAQIEAQEBAQMCAQIBAQEBAQEDAQEBAgMBAQEBAQEGAwEBgRyFLzkNg?= =?us-ascii?q?jcigywBAQEDI1YQCw0LAgImAgJXGYJ+AYInATQUsCyBMhoCZYNdAYEXmSkCg?= =?us-ascii?q?SFfgSIGgRUtAZFfQoINglGBbz6CYgKCLYMOgmcEjiiQVoEob4EegSJ/AgkCE?= =?us-ascii?q?WeBCAhegXFAAg1UCwtjgRyBW3kCAhEpExRSeR0DBwOBBRAvBwQyHwkGCRgYF?= =?us-ascii?q?yUGUQctJAkTFUEEg1gKgQ0/FQ4RglokAgc2PxtUgRM3A0QdQAMLbT01FB8Gb?= =?us-ascii?q?YFXMIFRJCSfTQMwgmKBDizHAYMUfoRDhzmVHjOXPwOSFYd9kBqNWppdgXmBf?= =?us-ascii?q?zMiMIMiUhmOZoM9hRSKZ3M7AgcLAQEDCYI7iQ0BAQ?= IronPort-PHdr: A9a23:LbWAnBwgjFNFqpDXCzK3zVBlVkEcU1XcAAcZ59Idhq5Udez7ptK+Z hGZua83xw6VFazgqNt6yMPu+5j6XmIB5ZvT+FsjS7drEyE/tMMNggY7C9SEA0CoZNTjbig9A dgQHAQ9pyLzPkdaAtvxaEPPqXOu8zESBg//NQ1oLejpB4Lelcu62/6y9pHJbAhEmiSxbbx2I Ri5sA7cqtQYjYx+J6k+zRfEvmFGcPlMy2NyIlKTkRf85sOu85Nm7i9dpfEv+dNeXKvjZ6g3Q qBWAzogM2Au+c3krgLDQheV5nsdSWoZjBxFCBXY4R7gX5fxtiz6tvdh2CSfIMb7Q6w4VSik4 qx2ThLjlSUJOCMj8GzPhMJ+jLxVrQy8qRJ8zY7bb52aO+d8ca7GYdMWWXBMUtpNWyBdAI6xa ZYEAeobPeZfqonwv0EAogWiBQm2GejgxSVHhnno2K05zu8sFhvJ3BYjH90UtXTbts/1ObwIX uCpyKnH1y7DY+lK1jb88YXFdA0qrv6QU7xqa8XR1VUvGB3fjlWWsYHpIS6Y2OoCvWWF4eRsS Oyih3AppQxxvDWix8cih43Xio8axF3I6yF0zYYrKNC2R0B2YMOoHIVMuyyVOIZ4TMcvTmd1s yg0zb0GvIS0fCkMyJk/yB7fauCHc4iV4h34TuqePTB4hHd9dLKwmRmy91Sgyur7VsWu11ZKt CVFn9/RvX4Ozxze8seKR/pn8ku/2TuC1xrf5v9aLU02j6bWKZ4szqYumpYOv0nPBDH6lFvqg KOMaEkp9fSk5/7jb7jnoJKXKpV6hRvkMqs0n8yyGeE4Mg8TUGeF4em8z7jj/VHhQLVNk/02j rHVsJDEKsQfoa60GwBV0oM65xakCjemzMwYkWQaIF5fZB2IkY7pO03UIPDlCPezmUijkTZzy /DHOL3uHInNI2DMnbrgZ7px9U5RxQopwdxB+Z5ZCKsNLfDzV0PpsdzXFB45Mwi6w+b9D9V90 5sTVniVAq+aKqzStEWH5vg0LuaWeI8VvCzyK+M/6/HyjH41gVkdcrKx0psNdH+4BuhmI1meY Xf0jNoNCX0KsRYmTOz2lF2CViZeZ2yvX60n5jA2E42mApnFRoCxh7yB2z23HppMZmBJElyMC 2vnd52YW/cQbyKfOtRhnSYBVbW6RI8uyxeutBP9y7pgNObU/TcYtZ372Nhv++LTjQ0y9SBzD 8mF3GGCUWd0nn8PRz8xxaxwvFJyykmY3Kh8gvxYDsBT5+hTXgc1K5HcyfB6C9f1Wg7bedeJU lmmEZ2aBmQ+Q9QtxNhLb0tjM9GjlQzYmSWnBaMSkPqMHpNn3Ljb2i3JKtpng0jP0goixw0vW MhGMGS8rqdj8wHIQYXbxRbK3522fLgRiXaevFyIynCD6RkwbQ== IronPort-Data: A9a23:gfwFra1zG35fB8cXlfbD5ZBwkn2cJEfYwER7XKvMYLTBsI5bp2BSm GZJW2qGP//eNmT0c9Ala4q39E9SuMeBm9JhS1BsqSg9HnlHgPSeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yAUOZigHNLUEPTDNj16WThqQSIgjQMLs+Mii+aEu/Dga++2k Y20+5W31GONgWYuaTpKsv/b8nuDgdyr0N8mlg1jDRx0lACG/5UlJMp3Db28KXL+Xr5VEoaSL woU5OzREsvxpn/BO/v9+lrJWhRiro36ZGBivkFrt52K2XCukMCSPpETb5LwYW8P49mAcksYJ N9l7fRcQi9xVkHAdXh0vxRwS0lD0aN6FLDvfEm28vW6kGD8T1TV5rZMNAIaMdMS5bMiaY1O3 aRwxDElYRXGnOeq2OviDOJhgNg5McytN5F3VnNIkW+fV6t7B8qZHOOVuLe03x9p7ixKNf/EZ MMcYCBHZQjEagYJMUV/5JcWxr3x1yCvLW0wRFS9poM3w3D06z5K64OuIcjzS4bJWuAOtxPNz o7B1yGjav0AD/SF1DCU2n2hgPPImmX8Qo16PKax89ZljVuPwWtVDwcZPXO0rP+ljUn7V99BA 0gV4TY166c/8lCsSZ/6RRLQnZKflkJCHYANTqtgsl7Llfe8DxulO1XohwVpMLQO3PLajxRzv rNVt7sF3QBSjYA= IronPort-HdrOrdr: A9a23:U7Ax0K1CoxV3UJiBxXHZxwqjBKUkLtp133Aq2lEZdPWaSKOlfu SV7ZEmPH7P+VQssR4b8+xoVJPsfZqYz+8Q3WBzB8bAYOCFggqVxehZhOOI/9SjIU3DH4Vmu5 uIHZITNOHN X-Talos-CUID: =?us-ascii?q?9a23=3AJJ6q/GmgwIgpG3CCPvHARv+WesfXOSDsxTTpChC?= =?us-ascii?q?VM1pGcZjWa2fT1K86mdU7zg=3D=3D?= X-Talos-MUID: 9a23:13xNJAkV1xbY/iMUBJujdnphHcdI+4OJOns2qtYXqe+1b29vHmy02WE= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.00,245,1681164000"; d="scan'208";a="22191868" Received: from unknown (HELO gm-smtp11.centrum.cz) ([46.255.227.75]) by antispam94.centrum.cz with ESMTP; 15 Jun 2023 18:27:53 +0200 Received: from arkam (ip-213-220-240-96.bb.vodafone.cz [213.220.240.96]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by gm-smtp11.centrum.cz (Postfix) with ESMTPSA id EC1F1100AE2AC; Thu, 15 Jun 2023 18:27:52 +0200 (CEST) Date: Thu, 15 Jun 2023 18:27:51 +0200 From: Petr =?utf-8?B?VmFuxJtr?= To: gentoo-dev@lists.gentoo.org Cc: ruby@gentoo.org, Sam James Subject: Re: [gentoo-dev] [PATCH 10/11] ruby-ng.eclass: use shopt directly, not via estack.eclass Message-ID: <2023615162751-ZIs8B4QuEytBT1s_-arkamar@atlas.cz> References: <20230615155240.589982-1-sam@gentoo.org> <20230615155240.589982-10-sam@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230615155240.589982-10-sam@gentoo.org> X-Archives-Salt: 8dd917cf-45cb-4ecc-abda-302e5812bb0b X-Archives-Hash: 634938f60f352c0c1640e6a71751fd37 On Thu, Jun 15, 2023 at 04:52:37PM +0100, Sam James wrote: > ulm points out that estack.eclass is particularly inefficient (although > it'll get slightly better once https://github.com/gentoo/gentoo/pull/31437 > is fixed). > > Let's just manually roll it like llvm.eclass does. > > Bug: https://bugs.gentoo.org/908465 > Signed-off-by: Sam James > --- > eclass/ruby-ng.eclass | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass > index 14f4414337d6f..8fe26057e7ffe 100644 > --- a/eclass/ruby-ng.eclass > +++ b/eclass/ruby-ng.eclass > @@ -163,7 +163,8 @@ _RUBY_ATOMS_SAMELIB_RESULT="" > _ruby_atoms_samelib() { > _RUBY_ATOMS_SAMELIB_RESULT="" > > - eshopts_push -o noglob > + local shopt_save=$(shopt -p -o noglob) ^~~~~~~~ Wrong indentation - expanded tab instead of tab > + set -f > local token > local atoms=" RUBYTARGET? (" > for token in $*; do > @@ -177,7 +178,7 @@ _ruby_atoms_samelib() { > esac > done > atoms+=" ) " > - eshopts_pop > + ${shopt_save} > > _ruby_set_globals_invalidate_if_stale > local _ruby_implementation > -- > 2.41.0 > >