From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1E89B158015 for ; Sat, 30 Dec 2023 05:07:28 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C32E52BC045; Sat, 30 Dec 2023 05:07:23 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 6FFB92BC014 for ; Sat, 30 Dec 2023 05:07:23 +0000 (UTC) From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Subject: [gentoo-dev] [PATCH 1/2] linux-mod-r1.eclass: Require the compression to succeed Date: Sat, 30 Dec 2023 06:07:15 +0100 Message-ID: <20231230050716.127184-1-mgorny@gentoo.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: d822d6b0-71c1-4aac-abda-494a98d64308 X-Archives-Hash: a1a0077547919696ef3d2f71b25341d8 Now that the module compression is conditional to USE=modules-compress, we no longer need to allow it to fail gracefully. If user enabled the compression explicitly, they expect it to succeed. If they don't have the tools, they can always flip it off again. Signed-off-by: Michał Górny --- eclass/linux-mod-r1.eclass | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/eclass/linux-mod-r1.eclass b/eclass/linux-mod-r1.eclass index 67a4b64eb481..b6be4ba8a16d 100644 --- a/eclass/linux-mod-r1.eclass +++ b/eclass/linux-mod-r1.eclass @@ -860,9 +860,8 @@ _modules_process_compress() { die "USE=modules-compress enabled but no MODULE_COMPRESS* configured" fi - # could fail, assumes have commands that were needed for the kernel einfo "Compressing modules (matching the kernel configuration) ..." - edob "${compress[@]}" -- "${@}" + edob "${compress[@]}" -- "${@}" || die } # @FUNCTION: _modules_process_depmod.d -- 2.43.0