From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 46578158013 for ; Tue, 5 Dec 2023 05:28:44 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 292EF2BC0B2; Tue, 5 Dec 2023 05:26:09 +0000 (UTC) Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E7DBE2BC0AF for ; Tue, 5 Dec 2023 05:26:08 +0000 (UTC) Received: by mail-oi1-x22a.google.com with SMTP id 5614622812f47-3b8903f7192so2862372b6e.0 for ; Mon, 04 Dec 2023 21:26:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701753967; x=1702358767; darn=lists.gentoo.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=F3xcMt6iYOhfmFY1PSDciUEOQbWQ7awNEeSUui5QyeQ=; b=gSIEs0P7G+e1r5/wmpNGDOG0K+NjtRhNXxSVAli+G6RQJy5cr/Hg05Vxz1etXZCVjP OPwdOrMMzmPDJpDPkMQZqS90XPCrurWiSZpK8CVEIy1YwrERn11kOGiolDzr3fvWLsro 7J7CxLIjb/3mmAMk3XgKUeFvQp6LujvHwqVUVJKUBa8AsSZ1OBBrSYhkPS7+AaGfDIOE 6yh1KM98Nqs1XjC9KTFktxZIhNhnNzTD7SpiIQvJyuEqseU+zO9DLMcdoqStL01rKnnl jHBmhxdDPMAcf/GLJYMK4a+VAHbiLdQq2r2uu+kBhjeJg5bGfjqcYxW+BSmHCn/xs9Os 0g8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701753967; x=1702358767; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F3xcMt6iYOhfmFY1PSDciUEOQbWQ7awNEeSUui5QyeQ=; b=bhBu26pM8trtfT5LTsk6trhcRyYLsHJnRJqT6Qn/ceHT+iBhXlKEwIH2qD/PONL1Jx oV0iuq8dw4Y4YPbgcB6OHdfIyEaoXD5Yq98E8Zq3pifHSI98taH2Z9UMycQ7NahSGLKA jchjYH/D5L9R9Qj7zBrG4Ss+9ZgwX8BbdKjGyZKJhQAR7rGt/lzgEqhslmD8vJ9wR8IT 1D9avBESvXlFLPkXXolCxOluAq3qPctW/3wkE7zI0Qy2St3QFb6E7cl5LjSfSlPhIaRS xVihnJiWuk7+Oxn9pt+hE9S8yj9L64v9K+hg2ld2wZlFZNynvk0D+52tjgYv3nrW6yf3 Nfiw== X-Gm-Message-State: AOJu0YzbotGk+umA8SLYvhI687g2rRikwfXbpf6KalNVqW8ji9l+ZHNB hz1Uf0RMXLn0+GCvVNKbOiV1ShFipVI= X-Google-Smtp-Source: AGHT+IEBK049u4ioPvKvqV+4ekTAyEkRwA8DrSUPwqs5kB6awPfpeczb+5b9360wijZx1ARRy7KopA== X-Received: by 2002:a05:6808:d49:b0:3b8:47d0:fe56 with SMTP id w9-20020a0568080d4900b003b847d0fe56mr5390400oik.24.1701753967430; Mon, 04 Dec 2023 21:26:07 -0800 (PST) Received: from acleverhostname.attlocal.net (108-200-163-197.lightspeed.bcvloh.sbcglobal.net. [108.200.163.197]) by smtp.gmail.com with ESMTPSA id x19-20020a056808145300b003b6caf2accfsm2081659oiv.22.2023.12.04.21.26.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 21:26:06 -0800 (PST) From: Eli Schwartz To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] [RFC PATCH 09/10] net-print/cups-browsed: restrict tests Date: Tue, 5 Dec 2023 00:20:34 -0500 Message-ID: <20231205052550.3150055-10-eschwartz93@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231205052550.3150055-1-eschwartz93@gmail.com> References: <20231205052550.3150055-1-eschwartz93@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: 19bf08ab-deeb-4c92-95a2-569322239b20 X-Archives-Hash: 9fd9830294ab1c2467fb1c941794297a The tests are newly created during the 2.x upgrade. They will hang forever if they cannot run properly. And running them properly has hit a wall. I'm not sure where to go on from here. Even getting this far means stepping outside of what portage can reasonably require. Avahi only runs as root, and doesn't seem to have a mocking mode, and even if it is running, the sandbox prevents src_test from seeing it. Signed-off-by: Eli Schwartz --- .../cups-browsed/cups-browsed-2.0.0.ebuild | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/net-print/cups-browsed/cups-browsed-2.0.0.ebuild b/net-print/cups-browsed/cups-browsed-2.0.0.ebuild index 6baeb697f2cd..0232d57c8b51 100644 --- a/net-print/cups-browsed/cups-browsed-2.0.0.ebuild +++ b/net-print/cups-browsed/cups-browsed-2.0.0.ebuild @@ -29,6 +29,18 @@ BDEPEND=" virtual/pkgconfig " +# The tests are new since the split out of cups-filters. Actually running them +# seems to be challenging. You need: +# - cups tools that are USE-optional +# - running avahi-daemon (as root!) +# - disable portage's pid-sandbox, which interferes with avahi +# - ipptool still fails to connect to port 8xxx +# +# If anything fails, a `while true` loop fails to successfully launch and break +# out of the loop, leading to a hang. Until there's an obvious recipe for +# successfully running the tests, restrict it. +RESTRICT="test" + PATCHES=( "${FILESDIR}"/0001-cups-browsed.c-Fix-build-with-avahi-disabled-20.patch ) @@ -47,6 +59,13 @@ src_configure() { econf "${myeconfargs[@]}" } +src_test() { + # Requires avahi running. Hangs forever if not available. + avahi-daemon --check 2>/dev/null || die "no running avahi daemon found, cannot run tests" + + default +} + src_install() { default -- 2.41.0