From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 93E3B158099 for ; Sat, 25 Nov 2023 06:55:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2BCFB2BC025; Sat, 25 Nov 2023 06:55:18 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E7B812BC01A for ; Sat, 25 Nov 2023 06:55:17 +0000 (UTC) From: Sam James To: gentoo-dev@lists.gentoo.org Cc: hardened@gentoo.org, toolchain@gentoo.org, Sam James Subject: [gentoo-dev] [PATCH] profiles/features/hardened/amd64: enable USE=pic Date: Sat, 25 Nov 2023 06:55:00 +0000 Message-ID: <20231125065506.3472677-1-sam@gentoo.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: fb3fc479-cbe1-4141-8d17-40aa6a631fa2 X-Archives-Hash: 8613082649a21df43d773c9693c4196c There's no real reason not to do this. The status quo is wrong for when we're doing multilib 32-bit builds on x86, and we already have to undo this on musl because its handling for TEXTRELs is limited (see bug #707660). (I noted my intention to do this in 80a72bac2350811712c018b68f61a031736c579f as well.) This seems to have been added originally in e718e1dc1781b3bb5cd80233c217aea3b0e46755 and bb28d08f1cf8cf16f6e57929a8de6b7c85bbe714 (git graft commit). Bug: https://bugs.gentoo.org/707660 Bug: https://bugs.gentoo.org/913412 Signed-off-by: Sam James --- profiles/features/hardened/amd64/make.defaults | 2 +- profiles/features/hardened/amd64/no-multilib/make.defaults | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) delete mode 100644 profiles/features/hardened/amd64/no-multilib/make.defaults diff --git a/profiles/features/hardened/amd64/make.defaults b/profiles/features/hardened/amd64/make.defaults index e8f0bdf8ba650..89a7242c35648 100644 --- a/profiles/features/hardened/amd64/make.defaults +++ b/profiles/features/hardened/amd64/make.defaults @@ -1,4 +1,4 @@ # Copyright 1999-2023 Gentoo Authors. # Distributed under the terms of the GNU General Public License v2 -USE="cet -pic" +USE="cet" diff --git a/profiles/features/hardened/amd64/no-multilib/make.defaults b/profiles/features/hardened/amd64/no-multilib/make.defaults deleted file mode 100644 index 1dd0a2a0f7e0d..0000000000000 --- a/profiles/features/hardened/amd64/no-multilib/make.defaults +++ /dev/null @@ -1,6 +0,0 @@ -# Copyright 1999-2011 Gentoo Foundation -# Distributed under the terms of the GNU General Public License v2 - -# We don't need to have pic on -USE="-pic" - -- 2.43.0