From: Sam James <sam@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: hardened@gentoo.org, toolchain@gentoo.org, Sam James <sam@gentoo.org>
Subject: [gentoo-dev] [PATCH] profiles/features/hardened/amd64: enable USE=pic
Date: Sat, 25 Nov 2023 06:55:00 +0000 [thread overview]
Message-ID: <20231125065506.3472677-1-sam@gentoo.org> (raw)
There's no real reason not to do this. The status quo is wrong for when
we're doing multilib 32-bit builds on x86, and we already have to undo
this on musl because its handling for TEXTRELs is limited (see bug #707660).
(I noted my intention to do this in 80a72bac2350811712c018b68f61a031736c579f
as well.)
This seems to have been added originally in e718e1dc1781b3bb5cd80233c217aea3b0e46755
and bb28d08f1cf8cf16f6e57929a8de6b7c85bbe714 (git graft commit).
Bug: https://bugs.gentoo.org/707660
Bug: https://bugs.gentoo.org/913412
Signed-off-by: Sam James <sam@gentoo.org>
---
profiles/features/hardened/amd64/make.defaults | 2 +-
profiles/features/hardened/amd64/no-multilib/make.defaults | 6 ------
2 files changed, 1 insertion(+), 7 deletions(-)
delete mode 100644 profiles/features/hardened/amd64/no-multilib/make.defaults
diff --git a/profiles/features/hardened/amd64/make.defaults b/profiles/features/hardened/amd64/make.defaults
index e8f0bdf8ba650..89a7242c35648 100644
--- a/profiles/features/hardened/amd64/make.defaults
+++ b/profiles/features/hardened/amd64/make.defaults
@@ -1,4 +1,4 @@
# Copyright 1999-2023 Gentoo Authors.
# Distributed under the terms of the GNU General Public License v2
-USE="cet -pic"
+USE="cet"
diff --git a/profiles/features/hardened/amd64/no-multilib/make.defaults b/profiles/features/hardened/amd64/no-multilib/make.defaults
deleted file mode 100644
index 1dd0a2a0f7e0d..0000000000000
--- a/profiles/features/hardened/amd64/no-multilib/make.defaults
+++ /dev/null
@@ -1,6 +0,0 @@
-# Copyright 1999-2011 Gentoo Foundation
-# Distributed under the terms of the GNU General Public License v2
-
-# We don't need to have pic on
-USE="-pic"
-
--
2.43.0
next reply other threads:[~2023-11-25 6:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 6:55 Sam James [this message]
2023-11-25 14:00 ` [gentoo-dev] [PATCH] profiles/features/hardened/amd64: enable USE=pic David Seifert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231125065506.3472677-1-sam@gentoo.org \
--to=sam@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=hardened@gentoo.org \
--cc=toolchain@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox