From: "Ulrich Müller" <ulm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: "Ulrich Müller" <ulm@gentoo.org>, "Mike Gilbert" <floppym@gentoo.org>
Subject: [gentoo-dev] [PATCH v2] acct-user.eclass: Warn when the user is removed from a group
Date: Mon, 23 Oct 2023 22:41:37 +0200 [thread overview]
Message-ID: <20231023204145.27236-2-ulm@gentoo.org> (raw)
Acked-by: Mike Gilbert <floppym@gentoo.org>
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
---
v2: Add explanation and documentation reference to warning message
eclass/acct-user.eclass | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/eclass/acct-user.eclass b/eclass/acct-user.eclass
index f658aa0eabc3..c9d335c4e558 100644
--- a/eclass/acct-user.eclass
+++ b/eclass/acct-user.eclass
@@ -431,6 +431,20 @@ acct-user_pkg_postinst() {
opts+=( --prefix "${ROOT}" )
fi
+ local g old_groups del_groups=""
+ old_groups=$(egetgroups "${ACCT_USER_NAME}")
+ for g in ${old_groups//,/ }; do
+ has "${g}" "${groups[@]}" || del_groups+="${del_groups:+, }${g}"
+ done
+ if [[ -n ${del_groups} ]]; then
+ ewarn "Removing user ${ACCT_USER_NAME} from group(s): ${del_groups}"
+ ewarn "To retain the user's group membership in the local system"
+ ewarn "config, override with ACCT_USER_${ACCT_USER_NAME^^}_GROUPS"
+ ewarn "or ACCT_USER_${ACCT_USER_NAME^^}_GROUPS_ADD in make.conf."
+ ewarn "Documentation reference:"
+ ewarn "https://wiki.gentoo.org/wiki/Practical_guide_to_the_GLEP_81_migration#Override_user_groups"
+ fi
+
elog "Updating user ${ACCT_USER_NAME}"
# usermod outputs a warning if unlocking the account would result in an
# empty password. Hide stderr in a text file and display it if usermod fails.
--
2.42.0
next reply other threads:[~2023-10-23 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 20:41 Ulrich Müller [this message]
2023-11-08 6:52 ` [gentoo-dev] [PATCH v2] acct-user.eclass: Warn when the user is removed from a group Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023204145.27236-2-ulm@gentoo.org \
--to=ulm@gentoo.org \
--cc=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox