From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 23032158008 for ; Thu, 15 Jun 2023 15:55:56 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1DA39E0A8C; Thu, 15 Jun 2023 15:53:04 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CC738E0A89 for ; Thu, 15 Jun 2023 15:53:03 +0000 (UTC) From: Sam James To: gentoo-dev@lists.gentoo.org Cc: ruby@gentoo.org, Sam James Subject: [gentoo-dev] [PATCH 11/11] ruby-ng.eclass: add _ruby_get_use_targets comment Date: Thu, 15 Jun 2023 16:52:38 +0100 Message-ID: <20230615155240.589982-11-sam@gentoo.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230615155240.589982-1-sam@gentoo.org> References: <20230615155240.589982-1-sam@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: 5e5dd9c9-a1ba-41fd-a504-fe69e1298a43 X-Archives-Hash: 1f18284d0bee916c9f8a3aa805f1b8a5 I don't see us adding a non-ruby* target any time soon so this should be fine. Signed-off-by: Sam James --- eclass/ruby-ng.eclass | 3 +++ 1 file changed, 3 insertions(+) diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass index 8fe26057e7ffe..043e3eefcbd68 100644 --- a/eclass/ruby-ng.eclass +++ b/eclass/ruby-ng.eclass @@ -105,6 +105,8 @@ ruby_implementation_depend() { _ruby_get_all_impls() { _RUBY_GET_ALL_IMPLS=() + # XXX: Please update _ruby_get_use_targets if adding a non-'ruby*' + # target. local i found_valid_impl for i in ${USE_RUBY}; do case ${i} in @@ -350,6 +352,7 @@ _ruby_get_use_targets() { _ruby_set_globals_invalidate_if_stale local impls="${_RUBY_GET_ALL_IMPLS[@]}" + # XXX: This assumes all targets begin with 'ruby'. _RUBY_GET_USE_TARGETS="${impls//ruby/ruby_targets_ruby}" } -- 2.41.0