From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 494DE158020 for ; Tue, 29 Nov 2022 18:56:10 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 32AC0E0893; Tue, 29 Nov 2022 18:56:06 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EE7ECE088C for ; Tue, 29 Nov 2022 18:56:05 +0000 (UTC) From: Mike Gilbert To: gentoo-dev@lists.gentoo.org Cc: Mike Gilbert Subject: [gentoo-dev] [PATCH] linux-info.eclass: getfilevar: pass 'need-compiler=' to make Date: Tue, 29 Nov 2022 13:55:44 -0500 Message-Id: <20221129185544.1957747-1-floppym@gentoo.org> X-Mailer: git-send-email 2.38.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: e17329dd-eee6-4d21-88e7-5b50631f95c5 X-Archives-Hash: d00326e76eeddb2f076568f4b1fe9620 This avoids some unnecessary Makefile logic and gives a nice speed up. Before the change, linux-info_pkg_setup takes 11 to 15 seconds on my AMD Phenom II. After, it takes 3 to 4 seconds. Signed-off-by: Mike Gilbert --- eclass/linux-info.eclass | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass index fc125b0d751..3e64cb9457a 100644 --- a/eclass/linux-info.eclass +++ b/eclass/linux-info.eclass @@ -238,7 +238,9 @@ getfilevar() { # Pass dot-config=0 to avoid the config check in kernels prior to 5.4. [[ ${EAPI:-0} == [0123] ]] && nonfatal() { "$@"; } echo -e "e:\\n\\t@echo \$(${1})\\ninclude ${basefname}" | \ - nonfatal emake -C "${basedname}" --no-print-directory M="${T}" dot-config=0 need-config= ${BUILD_FIXES} -s -f - 2>/dev/null + nonfatal emake -C "${basedname}" --no-print-directory M="${T}" \ + dot-config=0 need-config= need-compiler= \ + ${BUILD_FIXES} -s -f - 2>/dev/null ARCH=${myARCH} fi -- 2.38.1