From: Sam James <sam@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: dist-kernel@gentoo.org, kernel@gentoo.org, Sam James <sam@gentoo.org>
Subject: [gentoo-dev] [PATCH 4/8] linux-mod.eclass: improve error handling for module compression
Date: Tue, 11 Oct 2022 23:54:40 +0100 [thread overview]
Message-ID: <20221011225444.56032-4-sam@gentoo.org> (raw)
In-Reply-To: <20221011225444.56032-1-sam@gentoo.org>
doins will 'die for us' in newer EAPIs, and add missing || dies to compressor calls.
Signed-off-by: Sam James <sam@gentoo.org>
---
eclass/linux-mod.eclass | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/eclass/linux-mod.eclass b/eclass/linux-mod.eclass
index e837916b881a..e4c71cdf2c15 100644
--- a/eclass/linux-mod.eclass
+++ b/eclass/linux-mod.eclass
@@ -716,22 +716,22 @@ linux-mod_src_install() {
# and similarily compress the module being built if != NONE.
if linux_chkconfig_present MODULE_COMPRESS_XZ; then
- xz -T$(makeopts_jobs) ${modulename}.${KV_OBJ}
- doins ${modulename}.${KV_OBJ}.xz || die "doins ${modulename}.${KV_OBJ}.xz failed"
+ xz -T$(makeopts_jobs) ${modulename}.${KV_OBJ} || die "Compressing ${modulename}.${KV_OBJ} with xz failed"
+ doins ${modulename}.${KV_OBJ}.xz
elif linux_chkconfig_present MODULE_COMPRESS_GZIP; then
if type -P pigz ; then
- pigz -n$(makeopts_jobs) ${modulename}.${KV_OBJ}
+ pigz -n$(makeopts_jobs) ${modulename}.${KV_OBJ} || die "Compressing ${modulename}.${KV_OBJ} with pigz failed"
else
- gzip ${modulename}.${KV_OBJ}
+ gzip ${modulename}.${KV_OBJ} || die "Compressing ${modulename}.${KV_OBJ} with gzip failed"
fi
- doins ${modulename}.${KV_OBJ}.gz || die "doins ${modulename}.${KV_OBJ}.gz failed"
+ doins ${modulename}.${KV_OBJ}.gz
elif linux_chkconfig_present MODULE_COMPRESS_ZSTD; then
- zstd -T$(makeopts_jobs) ${modulename}.${KV_OBJ}
- doins ${modulename}.${KV_OBJ}.zst || die "doins ${modulename}.${KV_OBJ}.zst failed"
+ zstd -T$(makeopts_jobs) ${modulename}.${KV_OBJ} || "Compressing ${modulename}.${KV_OBJ} with zstd failed"
+ doins ${modulename}.${KV_OBJ}.zst
else
- doins ${modulename}.${KV_OBJ} || die "doins ${modulename}.${KV_OBJ} failed"
+ doins ${modulename}.${KV_OBJ}
fi
- cd "${OLDPWD}"
+ cd "${OLDPWD}" || die "${OLDPWD} does not exist"
generate_modulesd "${objdir}/${modulename}"
done
--
2.38.0
next prev parent reply other threads:[~2022-10-11 22:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 22:54 [gentoo-dev] [PATCH 1/8] kernel-2.eclass: decompress xz in parallel Sam James
2022-10-11 22:54 ` [gentoo-dev] [PATCH 2/8] linux-mod.eclass: compress xz/zstd " Sam James
2022-10-12 8:27 ` Ulrich Mueller
2022-10-12 16:42 ` Sam James
2022-10-11 22:54 ` [gentoo-dev] [PATCH 3/8] linux-mod.eclass: use pigz for parallel compression if available Sam James
2022-10-11 22:54 ` Sam James [this message]
2022-10-11 22:54 ` [gentoo-dev] [PATCH 5/8] linux-mod.eclass: cleanup whitespace Sam James
2022-10-11 22:54 ` [gentoo-dev] [PATCH 6/8] kernel-build.eclass: compress xz/zstd in parallel Sam James
2022-10-12 4:46 ` Michał Górny
2022-10-12 4:51 ` Sam James
2022-10-12 8:39 ` Ulrich Mueller
2022-10-12 16:43 ` Sam James
2022-10-11 22:54 ` [gentoo-dev] [PATCH 7/8] kernel-build.eclass: use pigz for parallel compression if available Sam James
2022-10-11 22:54 ` [gentoo-dev] [PATCH 8/8] kernel-build.eclass: use pbzip2/lbzip2 " Sam James
2022-10-12 0:20 ` [gentoo-dev] " Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221011225444.56032-4-sam@gentoo.org \
--to=sam@gentoo.org \
--cc=dist-kernel@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=kernel@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox