From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 779B6158094 for ; Wed, 27 Jul 2022 07:19:29 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B1A4AE100A; Wed, 27 Jul 2022 07:17:34 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 46CC8E1004 for ; Wed, 27 Jul 2022 07:17:34 +0000 (UTC) From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Subject: [gentoo-dev] [PATCH 6/6] virtualx.eclass: Do not disable sandbox Date: Wed, 27 Jul 2022 09:17:22 +0200 Message-Id: <20220727071722.277530-7-mgorny@gentoo.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220727071722.277530-1-mgorny@gentoo.org> References: <20220727071722.277530-1-mgorny@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 42d9edfe-0a69-48c9-a4c8-e6c6c23d4292 X-Archives-Hash: fced1416052e5a35b6ce00ec4812dc20 The code responsible for disabling sandbox dates back to 2002 and does not include any explanation. Let's try if we still need it. Signed-off-by: Michał Górny --- eclass/virtualx.eclass | 7 ------- 1 file changed, 7 deletions(-) diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass index c0af095e89a5..e04834d39bd1 100644 --- a/eclass/virtualx.eclass +++ b/eclass/virtualx.eclass @@ -107,7 +107,6 @@ virtx() { local i=0 local retval=0 - local OLD_SANDBOX_ON="${SANDBOX_ON}" local xvfbargs=( -screen 0 1280x1024x24 +extension RANDR ) debug-print "${FUNCNAME}: running Xvfb hack" @@ -115,9 +114,6 @@ virtx() { einfo "Starting Xvfb ..." - # We really do not want SANDBOX enabled here - export SANDBOX_ON="0" - debug-print "${FUNCNAME}: Xvfb -displayfd 1 ${xvfbargs[*]}" local logfile=${T}/Xvfb.log local pidfile=${T}/Xvfb.pid @@ -134,9 +130,6 @@ virtx() { die "Xvfb failed to start" fi - # Now enable SANDBOX again if needed. - export SANDBOX_ON="${OLD_SANDBOX_ON}" - # Do not break on error, but setup $retval, as we need to kill Xvfb einfo "Xvfb started on DISPLAY=${DISPLAY}" debug-print "${FUNCNAME}: $@" -- 2.35.1