[gentoo-dev] [PATCH 1/2] meson.eclass: disable PCH

[gentoo-dev] [PATCH 1/2] meson.eclass: disable PCH

[Sam James]

It's already masked and disabled in GCC and it causes a huge
number of problems, but we need t odo this to avoid automagically
trying to use PCH-even-once-it's-been-disabled-in-the-compiler.

Bug: https://bugs.gentoo.org/839549
Signed-off-by: Sam James <sam@gentoo.org>
---
 eclass/meson.eclass | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/eclass/meson.eclass b/eclass/meson.eclass
index c094f4683913..809cf10f8366 100644
--- a/eclass/meson.eclass
+++ b/eclass/meson.eclass
@@ -1,4 +1,4 @@
-# Copyright 2017-2021 Gentoo Authors
+# Copyright 2017-2022 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 # @ECLASS: meson.eclass
@@ -323,6 +323,12 @@ meson_src_configure() {
 		--build.pkg-config-path "${BUILD_PKG_CONFIG_PATH}${BUILD_PKG_CONFIG_PATH:+:}${EPREFIX}/usr/share/pkgconfig"
 		--pkg-config-path "${PKG_CONFIG_PATH}${PKG_CONFIG_PATH:+:}${EPREFIX}/usr/share/pkgconfig"
 		--native-file "$(_meson_create_native_file)"
+
+		# gcc[pch] is masked in profiles due to consistent bugginess
+		# without forcing this off, some packages may fail too (like gjs,
+		# bug #839549), but in any case, we don't want to bother attempting
+		# this.
+		-Db_pch=false
 	)
 
 	if [[ -n ${EMESON_BUILDTYPE} ]]; then
-- 
2.35.1

[gentoo-dev] [PATCH 2/2] meson.eclass: disable werror

[Sam James]

It's Gentoo policy to disable Werror where possible and this is
a builtin Meson option, so let's use it, to save needing to
add this all the time in ebuilds.

Closes: https://bugs.gentoo.org/754279
Signed-off-by: Sam James <sam@gentoo.org>
---
 eclass/meson.eclass | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/eclass/meson.eclass b/eclass/meson.eclass
index 809cf10f8366..f2f7173f5a9a 100644
--- a/eclass/meson.eclass
+++ b/eclass/meson.eclass
@@ -329,6 +329,10 @@ meson_src_configure() {
 		# bug #839549), but in any case, we don't want to bother attempting
 		# this.
 		-Db_pch=false
+
+		# It's Gentoo policy to not have builds die on blanket -Werror, as it's
+		# an upstream development matter. bug #754279.
+		-Dwerror=false
 	)
 
 	if [[ -n ${EMESON_BUILDTYPE} ]]; then
-- 
2.35.1

[gentoo-dev] Re: [PATCH 1/2] meson.eclass: disable PCH

[Mike Gilbert]

On Tue, Apr 19, 2022 at 2:21 PM Sam James <sam@gentoo.org> wrote:
>
> It's already masked and disabled in GCC and it causes a huge
> number of problems, but we need t odo this to avoid automagically
> trying to use PCH-even-once-it's-been-disabled-in-the-compiler.

ACK on both patches.