[gentoo-dev] [PATCH] flag-o-matic.eclass: filter-lfs-flags: remove -D_TIME_BITS=64

[gentoo-dev] [PATCH] flag-o-matic.eclass: filter-lfs-flags: remove -D_TIME_BITS=64

[Mike Gilbert]

glibc only allows _TIME_BITS=64 when _FILE_OFFSET_BITS=64.

Signed-off-by: Mike Gilbert <floppym@gentoo.org>
---
 eclass/flag-o-matic.eclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
index d262a60b6bb..32119cb9a52 100644
--- a/eclass/flag-o-matic.eclass
+++ b/eclass/flag-o-matic.eclass
@@ -193,7 +193,8 @@ filter-lfs-flags() {
 	# _LARGEFILE_SOURCE: enable support for new LFS funcs (ftello/etc...)
 	# _LARGEFILE64_SOURCE: enable support for 64bit variants (off64_t/fseeko64/etc...)
 	# _FILE_OFFSET_BITS: default to 64bit variants (off_t is defined as off64_t)
-	filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
+	# _TIME_BITS: default to 64bit time_t (requires _FILE_OFFSET_BITS=64)
+	filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_TIME_BITS=64
 }
 
 # @FUNCTION: filter-ldflags
-- 
2.34.1

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: filter-lfs-flags: remove -D_TIME_BITS=64

[Sam James]

[-- Attachment #1.1: Type: text/plain, Size: 1385 bytes --]



> On 18 Dec 2021, at 18:27, Mike Gilbert <floppym@gentoo.org <mailto:floppym@gentoo.org>> wrote:
> 
> glibc only allows _TIME_BITS=64 when _FILE_OFFSET_BITS=64.
> 
> Signed-off-by: Mike Gilbert <floppym@gentoo.org <mailto:floppym@gentoo.org>>
> ---
> eclass/flag-o-matic.eclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
> index d262a60b6bb..32119cb9a52 100644
> --- a/eclass/flag-o-matic.eclass
> +++ b/eclass/flag-o-matic.eclass
> @@ -193,7 +193,8 @@ filter-lfs-flags() {
> 	# _LARGEFILE_SOURCE: enable support for new LFS funcs (ftello/etc...)
> 	# _LARGEFILE64_SOURCE: enable support for 64bit variants (off64_t/fseeko64/etc...)
> 	# _FILE_OFFSET_BITS: default to 64bit variants (off_t is defined as off64_t)
> -	filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> +	# _TIME_BITS: default to 64bit time_t (requires _FILE_OFFSET_BITS=64)
> +	filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_TIME_BITS=64
> }
> 
> # @FUNCTION: filter-ldflags
> --
> 2.34.1
> 
> 


LGTM and please go ahead so we can move forward with our planning for this (see https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration <https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration> for others).

Best,
sam

[-- Attachment #1.2: Type: text/html, Size: 2552 bytes --]

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 618 bytes --]