[gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip

[gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip

[Sam James]

This breaks at least ocamlopt.

Closes: https://bugs.gentoo.org/803047
Closes: https://bugs.gentoo.org/811315
Signed-off-by: Sam James <sam@gentoo.org>
---
 eclass/dune.eclass | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/eclass/dune.eclass b/eclass/dune.eclass
index 02a8a870ef43e..8a6e01893932a 100644
--- a/eclass/dune.eclass
+++ b/eclass/dune.eclass
@@ -28,6 +28,9 @@ esac
 # Do not complain about CFLAGS etc since ml projects do not use them.
 QA_FLAGS_IGNORED='.*'
 
+# Breaks with ocamlopt
+RESTRICT="strip"
+
 EXPORT_FUNCTIONS src_compile src_test src_install
 
 RDEPEND=">=dev-lang/ocaml-4:=[ocamlopt?] dev-ml/dune:="
-- 
2.33.0

[gentoo-dev] [PATCH 2/3] findlib.eclass: restrict strip

[Sam James]

This breaks at least ocamlopt.

Closes: https://bugs.gentoo.org/803047
Closes: https://bugs.gentoo.org/811315
Signed-off-by: Sam James <sam@gentoo.org>
---
 eclass/findlib.eclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/eclass/findlib.eclass b/eclass/findlib.eclass
index 3b19b30c57c9b..6239beccb7a43 100644
--- a/eclass/findlib.eclass
+++ b/eclass/findlib.eclass
@@ -25,6 +25,8 @@ QA_FLAGS_IGNORED='.*'
 # Required to use the ocamlopt? dep in RDEPEND below
 IUSE="ocamlopt"
 
+RESTRICT="strip"
+
 # From this findlib version, there is proper stublibs support.
 DEPEND=">=dev-ml/findlib-1.0.4-r1"
 [[ ${FINDLIB_USE} ]] && DEPEND="${FINDLIB_USE}? ( ${DEPEND} )"
-- 
2.33.0

[gentoo-dev] [PATCH 3/3] opam.eclass: restrict strip

[Sam James]

This breaks at least ocamlopt.

Closes: https://bugs.gentoo.org/803047
Closes: https://bugs.gentoo.org/811315
Signed-off-by: Sam James <sam@gentoo.org>
---
 eclass/opam.eclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/eclass/opam.eclass b/eclass/opam.eclass
index 262d726a8a7a2..6b9d43204206d 100644
--- a/eclass/opam.eclass
+++ b/eclass/opam.eclass
@@ -21,6 +21,8 @@ esac
 # Do not complain about CFLAGS etc since ml projects do not use them.
 QA_FLAGS_IGNORED='.*'
 
+RESTRICT="strip"
+
 # @ECLASS-VARIABLE: OPAM_INSTALLER_DEP
 # @PRE_INHERIT
 # @DESCRIPTION:
-- 
2.33.0

Re: [gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

>>>>> On Mon, 11 Oct 2021, Sam James wrote:

> +# Breaks with ocamlopt
> +RESTRICT="strip"

Note that RESTRICT isn't accumulated across eclasses in EAPIs before 8.
So for older EAPIs you may want to use RESTRICT+=" strip".

Of course, this applies to the other two eclasses as well.

Ulrich

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

Re: [gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip

[Alexis Ballier]

On Mon, 2021-10-11 at 06:07 +0100, Sam James wrote:
> This breaks at least ocamlopt.
> 
> Closes: https://bugs.gentoo.org/803047
> Closes: https://bugs.gentoo.org/811315
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
>  eclass/dune.eclass | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/eclass/dune.eclass b/eclass/dune.eclass
> index 02a8a870ef43e..8a6e01893932a 100644
> --- a/eclass/dune.eclass
> +++ b/eclass/dune.eclass
> @@ -28,6 +28,9 @@ esac
>  # Do not complain about CFLAGS etc since ml projects do not use
> them.
>  QA_FLAGS_IGNORED='.*'
>  
> +# Breaks with ocamlopt
> +RESTRICT="strip"
> +



err this is a terrible idea to do at such a large scale, esp. since
nowadays you can use dostrip -x and provide proper comments as to what
and why something breaks when stripped on a case by case basis