[gentoo-dev] [PATCH 0/9] drop the go-module_pkg_postinst function

[gentoo-dev] [PATCH 0/9] drop the go-module_pkg_postinst function

[William Hubbs]

It seems to me that we don't need this function any longer since the go
ebuild displays a message when it is upgraded or downgraded explaining
how to rebuild go packages, so I would like to remove it.

This patch series contains all of the changes I could find that need to
happen to allow the removal.

William Hubbs (9):
  app-admin/vault: drop calls to go-module_pkg_postinst
  app-metrics/blackbox_exporter: drop calls to go-module_pkg_postinst
  app-misc/pet: drop calls to go-module_pkg_postinst
  net-dns/coredns: drop calls to go-module_pkg_postinst
  net-dns/dnscrypt-proxy: drop calls to go-module_pkg_postinst
  net-vpn/riseup-vpn: drop calls to go-module_pkg_postinst
  www-apps/gitea: drop calls to go-module_pkg_postinst
  www-servers/caddy: drop calls to go-module_pkg_postinst
  go-module.eclass: drop the go-module_pkg_postinst function

 app-admin/vault/vault-1.5.9.ebuild              |  5 -----
 app-admin/vault/vault-1.6.5.ebuild              |  5 -----
 app-admin/vault/vault-1.7.3.ebuild              |  5 -----
 app-admin/vault/vault-1.8.1.ebuild              |  5 -----
 .../blackbox_exporter-0.19.0.ebuild             |  5 -----
 app-misc/pet/pet-0.3.6-r1.ebuild                |  4 +---
 eclass/go-module.eclass                         | 17 +----------------
 net-dns/coredns/coredns-1.8.3.ebuild            |  1 -
 .../dnscrypt-proxy/dnscrypt-proxy-2.0.45.ebuild |  1 -
 .../dnscrypt-proxy/dnscrypt-proxy-2.1.0.ebuild  |  1 -
 .../dnscrypt-proxy/dnscrypt-proxy-9999.ebuild   |  1 -
 net-vpn/riseup-vpn/riseup-vpn-0.21.6.ebuild     |  1 -
 www-apps/gitea/gitea-1.14.6.ebuild              |  1 -
 www-apps/gitea/gitea-9999.ebuild                |  1 -
 www-servers/caddy/caddy-2.3.0-r1.ebuild         |  1 -
 www-servers/caddy/caddy-2.4.2.ebuild            |  1 -
 16 files changed, 2 insertions(+), 53 deletions(-)

-- 
2.31.1

[gentoo-dev] [PATCH 1/9] app-admin/vault: drop calls to go-module_pkg_postinst

[William Hubbs]

Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: William Hubbs <williamh@gentoo.org>
---
 app-admin/vault/vault-1.5.9.ebuild | 5 -----
 app-admin/vault/vault-1.6.5.ebuild | 5 -----
 app-admin/vault/vault-1.7.3.ebuild | 5 -----
 app-admin/vault/vault-1.8.1.ebuild | 5 -----
 4 files changed, 20 deletions(-)

diff --git a/app-admin/vault/vault-1.5.9.ebuild b/app-admin/vault/vault-1.5.9.ebuild
index 0e1b75de2be..d8143cfbf23 100644
--- a/app-admin/vault/vault-1.5.9.ebuild
+++ b/app-admin/vault/vault-1.5.9.ebuild
@@ -71,8 +71,3 @@ src_install() {
 	keepdir /var/log/${PN}
 	fowners ${PN}:${PN} /var/log/${PN}
 }
-
-pkg_postinst() {
-	fcaps_pkg_postinst
-	go-module_pkg_postinst
-}
diff --git a/app-admin/vault/vault-1.6.5.ebuild b/app-admin/vault/vault-1.6.5.ebuild
index 64280d983e9..87aa3191263 100644
--- a/app-admin/vault/vault-1.6.5.ebuild
+++ b/app-admin/vault/vault-1.6.5.ebuild
@@ -71,8 +71,3 @@ src_install() {
 	keepdir /var/log/${PN}
 	fowners ${PN}:${PN} /var/log/${PN}
 }
-
-pkg_postinst() {
-	fcaps_pkg_postinst
-	go-module_pkg_postinst
-}
diff --git a/app-admin/vault/vault-1.7.3.ebuild b/app-admin/vault/vault-1.7.3.ebuild
index 64280d983e9..87aa3191263 100644
--- a/app-admin/vault/vault-1.7.3.ebuild
+++ b/app-admin/vault/vault-1.7.3.ebuild
@@ -71,8 +71,3 @@ src_install() {
 	keepdir /var/log/${PN}
 	fowners ${PN}:${PN} /var/log/${PN}
 }
-
-pkg_postinst() {
-	fcaps_pkg_postinst
-	go-module_pkg_postinst
-}
diff --git a/app-admin/vault/vault-1.8.1.ebuild b/app-admin/vault/vault-1.8.1.ebuild
index 7699be83768..e05fbc3bfbc 100644
--- a/app-admin/vault/vault-1.8.1.ebuild
+++ b/app-admin/vault/vault-1.8.1.ebuild
@@ -1802,8 +1802,3 @@ src_install() {
 	keepdir /var/log/${PN}
 	fowners ${PN}:${PN} /var/log/${PN}
 }
-
-pkg_postinst() {
-	fcaps_pkg_postinst
-	go-module_pkg_postinst
-}
-- 
2.31.1

[gentoo-dev] [PATCH 2/9] app-metrics/blackbox_exporter: drop calls to go-module_pkg_postinst

[William Hubbs]

Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: William Hubbs <williamh@gentoo.org>
---
 .../blackbox_exporter/blackbox_exporter-0.19.0.ebuild        | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/app-metrics/blackbox_exporter/blackbox_exporter-0.19.0.ebuild b/app-metrics/blackbox_exporter/blackbox_exporter-0.19.0.ebuild
index fd11adf7117..6a621d733a1 100644
--- a/app-metrics/blackbox_exporter/blackbox_exporter-0.19.0.ebuild
+++ b/app-metrics/blackbox_exporter/blackbox_exporter-0.19.0.ebuild
@@ -506,8 +506,3 @@ src_install() {
 	insinto /etc/logrotate.d
 	newins "${FILESDIR}/${PN}.logrotated" "${PN}"
 }
-
-pkg_postinst() {
-	fcaps_pkg_postinst
-	go-module_pkg_postinst
-}
-- 
2.31.1

[gentoo-dev] [PATCH 3/9] app-misc/pet: drop calls to go-module_pkg_postinst

[William Hubbs]

Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: William Hubbs <williamh@gentoo.org>
---
 app-misc/pet/pet-0.3.6-r1.ebuild | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/app-misc/pet/pet-0.3.6-r1.ebuild b/app-misc/pet/pet-0.3.6-r1.ebuild
index 09f5ee655f7..4beff9649cc 100644
--- a/app-misc/pet/pet-0.3.6-r1.ebuild
+++ b/app-misc/pet/pet-0.3.6-r1.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2020 Gentoo Authors
+# Copyright 1999-2021 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=7
@@ -78,8 +78,6 @@ src_install() {
 }
 
 pkg_postinst() {
-	go-module_pkg_postinst
-
 	if ! has_version app-shells/peco && ! has_version app-shells/fzf ; then
 		einfo "You should consider to install app-shells/peco or"
 		einfo "app-shells/fzf to be able to use selector command"
-- 
2.31.1

[gentoo-dev] [PATCH 4/9] net-dns/coredns: drop calls to go-module_pkg_postinst

[William Hubbs]

Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: William Hubbs <williamh@gentoo.org>
---
 net-dns/coredns/coredns-1.8.3.ebuild | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net-dns/coredns/coredns-1.8.3.ebuild b/net-dns/coredns/coredns-1.8.3.ebuild
index 14b4e4767af..184cef43304 100644
--- a/net-dns/coredns/coredns-1.8.3.ebuild
+++ b/net-dns/coredns/coredns-1.8.3.ebuild
@@ -911,6 +911,5 @@ src_test() {
 
 pkg_postinst() {
 	fcaps_pkg_postinst
-	go-module_pkg_postinst
 	tmpfiles_process ${PN}.conf
 }
-- 
2.31.1

[gentoo-dev] [PATCH 5/9] net-dns/dnscrypt-proxy: drop calls to go-module_pkg_postinst

[William Hubbs]

Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: William Hubbs <williamh@gentoo.org>
---
 net-dns/dnscrypt-proxy/dnscrypt-proxy-2.0.45.ebuild | 1 -
 net-dns/dnscrypt-proxy/dnscrypt-proxy-2.1.0.ebuild  | 1 -
 net-dns/dnscrypt-proxy/dnscrypt-proxy-9999.ebuild   | 1 -
 3 files changed, 3 deletions(-)

diff --git a/net-dns/dnscrypt-proxy/dnscrypt-proxy-2.0.45.ebuild b/net-dns/dnscrypt-proxy/dnscrypt-proxy-2.0.45.ebuild
index 86f103a511c..ffe2f5f05aa 100644
--- a/net-dns/dnscrypt-proxy/dnscrypt-proxy-2.0.45.ebuild
+++ b/net-dns/dnscrypt-proxy/dnscrypt-proxy-2.0.45.ebuild
@@ -74,7 +74,6 @@ src_install() {
 
 pkg_postinst() {
 	fcaps_pkg_postinst
-	go-module_pkg_postinst
 
 	if ! use filecaps; then
 		ewarn "'filecaps' USE flag is disabled"
diff --git a/net-dns/dnscrypt-proxy/dnscrypt-proxy-2.1.0.ebuild b/net-dns/dnscrypt-proxy/dnscrypt-proxy-2.1.0.ebuild
index 19acce66145..3e4c51ce549 100644
--- a/net-dns/dnscrypt-proxy/dnscrypt-proxy-2.1.0.ebuild
+++ b/net-dns/dnscrypt-proxy/dnscrypt-proxy-2.1.0.ebuild
@@ -74,7 +74,6 @@ src_install() {
 
 pkg_postinst() {
 	fcaps_pkg_postinst
-	go-module_pkg_postinst
 
 	if ! use filecaps; then
 		ewarn "'filecaps' USE flag is disabled"
diff --git a/net-dns/dnscrypt-proxy/dnscrypt-proxy-9999.ebuild b/net-dns/dnscrypt-proxy/dnscrypt-proxy-9999.ebuild
index 43359636f25..ef229346589 100644
--- a/net-dns/dnscrypt-proxy/dnscrypt-proxy-9999.ebuild
+++ b/net-dns/dnscrypt-proxy/dnscrypt-proxy-9999.ebuild
@@ -74,7 +74,6 @@ src_install() {
 
 pkg_postinst() {
 	fcaps_pkg_postinst
-	go-module_pkg_postinst
 
 	if ! use filecaps; then
 		ewarn "'filecaps' USE flag is disabled"
-- 
2.31.1

[gentoo-dev] [PATCH 6/9] net-vpn/riseup-vpn: drop calls to go-module_pkg_postinst

[William Hubbs]

Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: William Hubbs <williamh@gentoo.org>
---
 net-vpn/riseup-vpn/riseup-vpn-0.21.6.ebuild | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net-vpn/riseup-vpn/riseup-vpn-0.21.6.ebuild b/net-vpn/riseup-vpn/riseup-vpn-0.21.6.ebuild
index c2c5eb8da77..3b22b5554ae 100644
--- a/net-vpn/riseup-vpn/riseup-vpn-0.21.6.ebuild
+++ b/net-vpn/riseup-vpn/riseup-vpn-0.21.6.ebuild
@@ -133,5 +133,4 @@ src_install() {
 
 pkg_postinst() {
 	xdg_pkg_postinst
-	go-module_pkg_postinst
 }
-- 
2.31.1

[gentoo-dev] [PATCH 7/9] www-apps/gitea: drop calls to go-module_pkg_postinst

[William Hubbs]

Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: William Hubbs <williamh@gentoo.org>
---
 www-apps/gitea/gitea-1.14.6.ebuild | 1 -
 www-apps/gitea/gitea-9999.ebuild   | 1 -
 2 files changed, 2 deletions(-)

diff --git a/www-apps/gitea/gitea-1.14.6.ebuild b/www-apps/gitea/gitea-1.14.6.ebuild
index c1bc0be80fa..38cd614841a 100644
--- a/www-apps/gitea/gitea-1.14.6.ebuild
+++ b/www-apps/gitea/gitea-1.14.6.ebuild
@@ -124,6 +124,5 @@ src_install() {
 
 pkg_postinst() {
 	fcaps_pkg_postinst
-	go-module_pkg_postinst
 	tmpfiles_process gitea.conf
 }
diff --git a/www-apps/gitea/gitea-9999.ebuild b/www-apps/gitea/gitea-9999.ebuild
index 6a4eaea9959..912d2f81957 100644
--- a/www-apps/gitea/gitea-9999.ebuild
+++ b/www-apps/gitea/gitea-9999.ebuild
@@ -117,6 +117,5 @@ src_install() {
 
 pkg_postinst() {
 	fcaps_pkg_postinst
-	go-module_pkg_postinst
 	tmpfiles_process gitea.conf
 }
-- 
2.31.1

[gentoo-dev] [PATCH 8/9] www-servers/caddy: drop calls to go-module_pkg_postinst

[William Hubbs]

Package-Manager: Portage-3.0.20, Repoman-3.0.3
---
 www-servers/caddy/caddy-2.3.0-r1.ebuild | 1 -
 www-servers/caddy/caddy-2.4.2.ebuild    | 1 -
 2 files changed, 2 deletions(-)

diff --git a/www-servers/caddy/caddy-2.3.0-r1.ebuild b/www-servers/caddy/caddy-2.3.0-r1.ebuild
index 32da8be5fb0..05facd87394 100644
--- a/www-servers/caddy/caddy-2.3.0-r1.ebuild
+++ b/www-servers/caddy/caddy-2.3.0-r1.ebuild
@@ -1160,5 +1160,4 @@ src_install() {
 
 pkg_postinst() {
 	fcaps_pkg_postinst
-	go-module_pkg_postinst
 }
diff --git a/www-servers/caddy/caddy-2.4.2.ebuild b/www-servers/caddy/caddy-2.4.2.ebuild
index 2b788410be2..1f1105833ea 100644
--- a/www-servers/caddy/caddy-2.4.2.ebuild
+++ b/www-servers/caddy/caddy-2.4.2.ebuild
@@ -1181,5 +1181,4 @@ src_install() {
 
 pkg_postinst() {
 	fcaps_pkg_postinst
-	go-module_pkg_postinst
 }
-- 
2.31.1

[gentoo-dev] [PATCH 9/9] go-module.eclass: drop the go-module_pkg_postinst function

[William Hubbs]

Signed-off-by: William Hubbs <williamh@gentoo.org>
---
 eclass/go-module.eclass | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
index 053861a1a18..3f6e07fad2f 100644
--- a/eclass/go-module.eclass
+++ b/eclass/go-module.eclass
@@ -85,7 +85,7 @@ QA_FLAGS_IGNORED='.*'
 # Go packages should not be stripped with strip(1).
 RESTRICT+=" strip"
 
-EXPORT_FUNCTIONS src_unpack pkg_postinst
+EXPORT_FUNCTIONS src_unpack
 
 # @ECLASS-VARIABLE: EGO_SUM
 # @DESCRIPTION:
@@ -417,21 +417,6 @@ go-module_live_vendor() {
 	popd >& /dev/null || die
 }
 
-# @FUNCTION: go-module_pkg_postinst
-# @DESCRIPTION:
-# Display a warning about security updates for Go programs.
-go-module_pkg_postinst() {
-	debug-print-function "${FUNCNAME}" "$@"
-	[[ -n ${REPLACING_VERSIONS} ]] && return 0
-	ewarn "${PN} is written in the Go programming language."
-	ewarn "Since this language is statically linked, security"
-	ewarn "updates will be handled in individual packages and will be"
-	ewarn "difficult for us to track as a distribution."
-	ewarn "For this reason, please update any go packages asap when new"
-	ewarn "versions enter the tree or go stable if you are running the"
-	ewarn "stable tree."
-}
-
 # @FUNCTION: _go-module_gomod_encode
 # @DESCRIPTION:
 # Encode the name(path) of a Golang module in the format expected by Goproxy.
-- 
2.31.1

Re: [gentoo-dev] [PATCH 0/9] drop the go-module_pkg_postinst function

[William Hubbs]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

On Sun, Aug 29, 2021 at 11:33:17AM -0500, William Hubbs wrote:
> It seems to me that we don't need this function any longer since the go
> ebuild displays a message when it is upgraded or downgraded explaining
> how to rebuild go packages, so I would like to remove it.
> 
> This patch series contains all of the changes I could find that need to
> happen to allow the removal.

This series has been added to the tree.

Thanks,

William

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [gentoo-dev] [PATCH 0/9] drop the go-module_pkg_postinst function

[Robin H. Johnson]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

On Sun, Aug 29, 2021 at 11:33:17AM -0500, William Hubbs wrote:
> It seems to me that we don't need this function any longer since the go
> ebuild displays a message when it is upgraded or downgraded explaining
> how to rebuild go packages, so I would like to remove it.
> 
> This patch series contains all of the changes I could find that need to
> happen to allow the removal.
This series seems to remove fcaps postinst in some cases where it's the
only thing otherwise left, but not all cases.

I think it would be better if the fcaps postinst was explicitly left.

-- 
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
E-Mail   : robbat2@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1113 bytes --]