[gentoo-dev] [PATCH 1/2] eclass/eutils.eclass: drop ltprune inherit

[gentoo-dev] [PATCH 1/2] eclass/eutils.eclass: drop ltprune inherit

[Conrad Kostecki]

No ebuilds remaining to call directly prune_libtool_files,
so we could drop the ltprune inherit in eutils.

Signed-off-by: Conrad Kostecki <conikost@gentoo.org>
---
 eclass/eutils.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
index 207d05e7f97..8a7cb6bde53 100644
--- a/eclass/eutils.eclass
+++ b/eclass/eutils.eclass
@@ -25,7 +25,7 @@ _EUTILS_ECLASS=1
 # implicitly inherited (now split) eclasses
 case ${EAPI} in
 	5|6)
-		inherit desktop edos2unix epatch estack ltprune multilib \
+		inherit desktop edos2unix epatch estack multilib \
 			preserve-libs strip-linguas toolchain-funcs vcs-clean wrapper
 		;;
 	7) inherit edos2unix strip-linguas wrapper ;;
-- 
2.32.0

[gentoo-dev] [PATCH 2/2] eclass/gstreamer.eclass: drop ltprune inherit

[Conrad Kostecki]

Dropping ltprune eclass and replacing it with
a simple find command, as suggested alternatively.

Signed-off-by: Conrad Kostecki <conikost@gentoo.org>
---
 eclass/gstreamer.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/eclass/gstreamer.eclass b/eclass/gstreamer.eclass
index 301d0874106..d5adb8f6423 100644
--- a/eclass/gstreamer.eclass
+++ b/eclass/gstreamer.eclass
@@ -23,7 +23,7 @@
 # plugin, consider adding media-plugins/gst-plugins-meta dependency, but
 # also list any packages that provide explicitly requested plugins.
 
-inherit eutils ltprune multilib multilib-minimal toolchain-funcs versionator xdg-utils
+inherit eutils multilib multilib-minimal toolchain-funcs versionator xdg-utils
 
 case "${EAPI:-0}" in
 	5|6)
@@ -264,5 +264,5 @@ gstreamer_multilib_src_install_all() {
 		[[ -e ${dir}/README ]] && dodoc "${dir}"/README
 	done
 
-	prune_libtool_files --modules
+	find "${ED}" -name '*.la' -delete || die
 }
-- 
2.32.0

Re: [gentoo-dev] [PATCH 1/2] eclass/eutils.eclass: drop ltprune inherit

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

>>>>> On Tue, 27 Jul 2021, Conrad Kostecki wrote:

> No ebuilds remaining to call directly prune_libtool_files,
> so we could drop the ltprune inherit in eutils.

I see very little benefit, because a) the indirect inherit is limited to
EAPIs 5 and 6, and b) eutils is deprecated. OTOH, there's some risk of
(silent) breakage, because one can assume that eutils is still widely
used in overlays.

Ulrich

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]