From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D9C4013933E for ; Sat, 10 Jul 2021 11:09:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F21A7E0D60; Sat, 10 Jul 2021 11:09:16 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 986BCE0D27 for ; Sat, 10 Jul 2021 11:09:16 +0000 (UTC) Date: Sat, 10 Jul 2021 12:09:11 +0100 From: Sergei Trofimovich To: Ulrich Mueller Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/5] haskell-cabal.eclass: drop EAPI={0..5} support Message-ID: <20210710120911.7c86edd3@zn3> In-Reply-To: References: <20210705222555.3847172-1-slyfox@gentoo.org> <20210705222555.3847172-2-slyfox@gentoo.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/sb23/1jboiudxsVa9QsUE5d"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Archives-Salt: 339d173c-8f0e-4623-a442-abc07817399a X-Archives-Hash: add286c1c665a56e38359c3693b996da --Sig_/sb23/1jboiudxsVa9QsUE5d Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 06 Jul 2021 09:34:14 +0200 Ulrich Mueller wrote: > >>>>> On Tue, 06 Jul 2021, Sergei Trofimovich wrote: =20 > =20 > > case "${EAPI:-0}" in =20 >=20 > This could be just ${EAPI} now (and quotes were never necessary). >=20 > > - 0|1) ;; > > - 2|3|4|5|6|7) HASKELL_CABAL_EXPF+=3D" src_configure" ;; > > + 6|7) ;; > > *) die "EAPI ${EAPI} unsupported." ;; =20 >=20 >=20 > I'd suggest to update to die message to what is used in other eclasses > (see toolchain-funcs.eclass for example): >=20 > *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;; >=20 > > esac =20 >=20 > Same comment for the other eclasses of this series. >=20 > Ulrich Sounds good. Done both as: --- a/eclass/haskell-cabal.eclass +++ b/eclass/haskell-cabal.eclass @@ -40,11 +40,11 @@ # FEATURE can be removed once https://github.com/haskell/= cabal/issues/7213 # is fixed. -case "${EAPI:-0}" in +case ${EAPI} in # eutils is for eqawarn 6|7) inherit eutils ;; 8) ;; - *) die "EAPI ${EAPI} unsupported." ;; + *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;; esac inherit ghc-package multilib toolchain-funcs --=20 Sergei --Sig_/sb23/1jboiudxsVa9QsUE5d Content-Type: application/pgp-signature Content-Description: Цифровая подпись OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQKTBAEBCgB9FiEE+g11JqJ4cL44QkmN7V5F4G8qwpMFAmDpf9dfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEZB MEQ3NTI2QTI3ODcwQkUzODQyNDk4REVENUU0NUUwNkYyQUMyOTMACgkQ7V5F4G8q wpO+aBAAu8uISUcNBqWf7oVHrrpzJ8NvsyXZSMe250OxWZ9MbSbWj2IB6ufnIpQH Gou/Uk1heEfimG2VWMKCMAWYoIolHCx3iypuhdP8mj3u4rSOMFlxrWolwu3ljjfW QN53/SmRluCVtxJvpsC7oKvNwb7BFBH85QKbsJZPbuUBdCMMNa0Wh8EaB8sFuYkH BVVrGiSsDkL+WxlXx/G1w/mLrys57H3agA9AXe1jFM2iAR2hcy6qN+4nxFZwUWTU pttyNlUMh5Qf+Fg0cXMs7hB5dy3+OtRaGc8USFxqoTxzwNf65wQeu4S9CRZEIDU+ HRv254Ti05d/hbkEYLSzMIZ4vFphvsIKKTdnVmpfHBmhP0lu+dwjnIESXluFN35X qZtVVhV8pGtxXpl6gvrFgReB7LFJlH4BHNDspYtcpu4QfGT5BmEQfjC7ZlDKe3yn 8z5O5X/QuwOV0lsxqxF0GwCU3wakUvQ/7Nzr2f9ZX2TE0wn+FNFkh7UN68GisSWZ SaLbqP9rPD5sQ1dkEM7R7dkbB30lhzg0T3brNlWQHy1h8hrNmNgRNu42p+brRrEq UUqg7EUHg8ZteLT+fZmFu2YCZDdLDrSUt/9nhjiVmgghmkg9xEeUCGcGet42v2hM GEtBsQ6PbiIej8RWWN9+E5Oq56vm4ITZUmxyCCoZXJSWQtBm3o8= =ty3b -----END PGP SIGNATURE----- --Sig_/sb23/1jboiudxsVa9QsUE5d--