From: Georgy Yakovlev <gyakovlev@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: Georgy Yakovlev <gyakovlev@gentoo.org>
Subject: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add virtual/libcrypt dep check
Date: Thu, 24 Jun 2021 22:25:19 -0700 [thread overview]
Message-ID: <20210625052519.1434328-1-gyakovlev@gentoo.org> (raw)
Bug: https://bugs.gentoo.org/699422
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
---
metadata/install-qa-check.d/60libcrypt-deps | 38 +++++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 metadata/install-qa-check.d/60libcrypt-deps
diff --git a/metadata/install-qa-check.d/60libcrypt-deps b/metadata/install-qa-check.d/60libcrypt-deps
new file mode 100644
index 000000000000..bc7b8d3dced2
--- /dev/null
+++ b/metadata/install-qa-check.d/60libcrypt-deps
@@ -0,0 +1,38 @@
+# Copyright 2021 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+# QA check: ensure that package specifies a dependency on virtual/libcrypt
+# Author: Georgy Yakovlev <gyakovlev@gentoo.org>
+# Maintainer Sam James <sam@gentoo.org>
+
+libcrypt_check() {
+ if ! type -P scanelf >/dev/null || has binchecks ${PORTAGE_RESTRICT}; then
+ return
+ fi
+
+ # nothing to do here
+ if grep -q virtual/libcrypt <<<${RDEPEND}; then
+ return
+ fi
+
+ local libcrypt_consumers
+ # grep outputs newline separated list of files, so it's ok to skip specifying delimiter
+ IFS= mapfile libcrypt_consumers < <(find "${ED}" -type f -executable \
+ -print0 | xargs -0 scanelf -qyRF '%F %n' {} + | grep 'libcrypt.so' 2>/dev/null )
+
+ if [[ -n ${libcrypt_consumers[@]} ]]; then
+ eqawarn "Binary files linked to libcrypt.so found"
+ eqawarn "But dependency on virtual/libcrypt is not declared"
+ eqawarn
+ eqatag -v virtual-libcrypt.missing "${libcrypt_consumers[@]%% *}"
+ eqawarn
+ eqawarn "Please add virtual/libcrypt dependency"
+ eqawarn "Gentoo Bug: https://bugs.gentoo.org/699422"
+ fi
+
+}
+
+libcrypt_check
+: # guarantee successful exit
+
+# vim:ft=sh
--
2.32.0
next reply other threads:[~2021-06-25 5:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 5:25 Georgy Yakovlev [this message]
2021-06-26 22:54 ` [gentoo-dev] [PATCH] metadata/install-qa-check.d: add virtual/libcrypt dep check Georgy Yakovlev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625052519.1434328-1-gyakovlev@gentoo.org \
--to=gyakovlev@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox