From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-94125-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by finch.gentoo.org (Postfix) with ESMTPS id D06761382C5
for <garchives@archives.gentoo.org>; Thu, 1 Apr 2021 18:40:16 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id ED634E097C;
Thu, 1 Apr 2021 18:40:14 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id ADD86E0971
for <gentoo-dev@lists.gentoo.org>; Thu, 1 Apr 2021 18:40:14 +0000 (UTC)
Date: Thu, 1 Apr 2021 19:40:08 +0100
From: Sergei Trofimovich <slyfox@gentoo.org>
To: Andreas Sturmlechner <asturm@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v2 5/5] flag-o-matic.eclass: get rid of
eutils in <EAPI-8, fix eclassdoc, make some funcs internal
Message-ID: <20210401194008.027626d9@sf>
In-Reply-To: <1819506.7Z3S40VBb9@tuxbook>
References: <5252907.rdbgypaU67@tuxbook>
<3350735.dWV9SEqChM@tuxbook>
<6603455.9J7NaK4W3v@tuxbook>
<1819506.7Z3S40VBb9@tuxbook>
X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/Q2l7VVYrmM3hpmmAHe7xYxV";
protocol="application/pgp-signature"; micalg=pgp-sha512
X-Archives-Salt: ebc705ab-3c0e-41d0-9a86-61af85a52f9f
X-Archives-Hash: b33da0c14ea9e1017da7e0618aa9f651
--Sig_/Q2l7VVYrmM3hpmmAHe7xYxV
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
On Thu, 01 Apr 2021 12:02:15 +0200
Andreas Sturmlechner <asturm@gentoo.org> wrote:
> From af002023d6b8f9a9e51fc31c8c25d48012e35ddf Mon Sep 17 00:00:00 2001
> From: Andreas Sturmlechner <asturm@gentoo.org>
> Date: Sun, 28 Mar 2021 15:04:50 +0200
> Subject: [PATCH 5/5] flag-o-matic.eclass: Fix eclassdoc
>=20
> Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
The patch looks good.
> ---
> eclass/flag-o-matic.eclass | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>=20
> diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
> index a35f0bef269..6e7582c4643 100644
> --- a/eclass/flag-o-matic.eclass
> +++ b/eclass/flag-o-matic.eclass
> @@ -21,6 +21,8 @@ case ${EAPI} in
> *) die "EAPI ${EAPI} is not supported by flag-o-matic.eclass." ;;
> esac
> =20
> +# @FUNCTION: all-flag-vars
> +# @DESCRIPTION:
> # Return all the flag variables that our high level funcs operate on.
> all-flag-vars() {
> echo {ADA,C,CPP,CXX,CCAS,F,FC,LD}FLAGS
> @@ -108,7 +110,10 @@ _setup-allowed-flags() {
> )
> }
> =20
> -# inverted filters for hardened compiler. This is trying to unpick
> +# @FUNCTION: _filter-hardened
> +# @INTERNAL
> +# @DESCRIPTION:
> +# Inverted filters for hardened compiler. This is trying to unpick
> # the hardened compiler defaults.
> _filter-hardened() {
> local f
> @@ -142,6 +147,9 @@ _filter-hardened() {
> done
> }
> =20
> +# @FUNCTION: _filter-var
> +# @INTERNAL
> +# @DESCRIPTION:
> # Remove occurrences of strings from variable given in $1
> # Strings removed are matched as globs, so for example
> # '-O*' would remove -O1, -O2 etc.
> @@ -334,6 +342,11 @@ replace-cpu-flags() {
> return 0
> }
> =20
> +# @FUNCTION: _is_flagq
> +# @USAGE: <variable> <flag>
> +# @INTERNAL
> +# @DESCRIPTION:
> +# Returns shell true if <flag> is in a given <variable>, else returns sh=
ell false.
> _is_flagq() {
> local x var=3D"$1[*]"
> for x in ${!var} ; do
> --=20
> 2.31.0
>=20
--=20
Sergei
--Sig_/Q2l7VVYrmM3hpmmAHe7xYxV
Content-Type: application/pgp-signature
Content-Description: Цифровая подпись OpenPGP
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQKTBAEBCgB9FiEE+g11JqJ4cL44QkmN7V5F4G8qwpMFAmBmE4hfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEZB
MEQ3NTI2QTI3ODcwQkUzODQyNDk4REVENUU0NUUwNkYyQUMyOTMACgkQ7V5F4G8q
wpMXjg//UiNkbYpVFElxu4aHwU3IDQeY1FxUMXGzjssNpRyg8lGCx5WQxmFa11ul
6TTLOOtXcJvlOlheVw7HNUWgFK4VPCfIySQdrPM6f9xSv3ZkgEIeg8Grke29CWzJ
Avv24kkzg0b4gUrJnOgTvE/Jhi7nmz5HYZ9t7XCSC1BeFa9l1+XUgHahvaE4E4cI
kQ8bbmRrhr3+2/UopW+hs1qFBD1W6qVcBFMot9K6WXCEkjPmxJUw4QQHTSfB4F2v
vJ1npEvUSQxTr63IhgY1+GFNax7C6dKl8eXWMZGWiQVhewPv6ktNooePbDuh8koc
ZYsruc1lxT/hd6WEEZao1TeRSbfepDxtJYkV+oZ6omELp3n5+WIrP97mj3wUYoty
hseW0Z5zIzZLW9uJn6cfHiZrRwP2aaaQA9y844Q/ICJEjJmAOpqOGPvuRSoPzH/+
CsfyynBKKDtCfVDBYUJlYvav2m2Yj0JDRzD/OkUC4liVgkpARk/rQdHD/U/XKuoD
BPGjB/TmmVI7wr6NkIv6K12AEyxLH/2gNJDgCf+/gWSIMztSvAgo488b5e3RjqIR
Urw1L8A4KV6XD3/WgFtPasWq/iaZxk5qVlBF0Pk2IR7ZsqPf/0sRaZzg0N4omvCI
MAh9WKa4/jaLwtkBhahKJsFBVgwvsTZMweyIFHQyZ4kgG/RdDsQ=
=cfDv
-----END PGP SIGNATURE-----
--Sig_/Q2l7VVYrmM3hpmmAHe7xYxV--