From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C96AA1382C5 for ; Thu, 1 Apr 2021 18:30:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CEC18E0936; Thu, 1 Apr 2021 18:30:18 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 9743EE090F for ; Thu, 1 Apr 2021 18:30:18 +0000 (UTC) Date: Thu, 1 Apr 2021 19:30:12 +0100 From: Sergei Trofimovich To: Andreas Sturmlechner Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH v2 2/5] flag-o-matic.eclass: get rid of eutils in In-Reply-To: <2127539.vFx2qVVIhK@tuxbook> References: <5252907.rdbgypaU67@tuxbook> <20210331083321.24e5ead5@sf> <2537255.vuYhMxLoTh@tuxbook> <2127539.vFx2qVVIhK@tuxbook> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/.QnplaZkPf225GrRs_690e3"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Archives-Salt: 7491c72a-784a-4c40-8868-cb4c3b04b6a7 X-Archives-Hash: 1886c144a619acd0ceee21677445a254 --Sig_/.QnplaZkPf225GrRs_690e3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 01 Apr 2021 11:58:07 +0200 Andreas Sturmlechner wrote: > From 6d1c665d06186dde5361905d5fb2057e044b040e Mon Sep 17 00:00:00 2001 > From: Andreas Sturmlechner > Date: Wed, 31 Mar 2021 00:22:12 +0200 > Subject: [PATCH 2/5] flag-o-matic.eclass: Make setup-allowed-flags() inte= rnal >=20 > Signed-off-by: Andreas Sturmlechner > --- > eclass/flag-o-matic.eclass | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) >=20 > diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass > index ab79f70392d..d511a140592 100644 > --- a/eclass/flag-o-matic.eclass > +++ b/eclass/flag-o-matic.eclass > @@ -26,9 +26,23 @@ all-flag-vars() { > echo {ADA,C,CPP,CXX,CCAS,F,FC,LD}FLAGS > } > =20 > +# @FUNCTION: setup-allowed-flags > +# @INTERNAL > +# @DESCRIPTION: > # {C,CPP,CXX,CCAS,F,FC,LD}FLAGS that we allow in strip-flags > # Note: shell globs and character lists are allowed > setup-allowed-flags() { > + [[ ${EAPI} =3D=3D [5-7] ]] || Minor nit: I'd prefer '[[ ${EAPI} =3D=3D [567] ]]' Otherwise the patch is ok. > + die "Internal function ${FUNCNAME} is not available in >=3DEAPI-8." > + _setup-allowed-flags > +} > + > +# @FUNCTION: _setup-allowed-flags > +# @INTERNAL > +# @DESCRIPTION: > +# {C,CPP,CXX,CCAS,F,FC,LD}FLAGS that we allow in strip-flags > +# Note: shell globs and character lists are allowed > +_setup-allowed-flags() { > ALLOWED_FLAGS=3D( > -pipe -O '-O[12sg]' -mcpu -march -mtune > '-fstack-protector*' '-fsanitize*' '-fstack-check*' -fno-stack-check > @@ -412,7 +426,7 @@ strip-flags() { > local x y var > =20 > local ALLOWED_FLAGS > - setup-allowed-flags > + _setup-allowed-flags > =20 > set -f # disable pathname expansion > =20 > --=20 > 2.31.0 >=20 --=20 Sergei --Sig_/.QnplaZkPf225GrRs_690e3 Content-Type: application/pgp-signature Content-Description: Цифровая подпись OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQKTBAEBCgB9FiEE+g11JqJ4cL44QkmN7V5F4G8qwpMFAmBmETRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEZB MEQ3NTI2QTI3ODcwQkUzODQyNDk4REVENUU0NUUwNkYyQUMyOTMACgkQ7V5F4G8q wpOjEBAAqz9SyIpPx+PagjrSPTnZA7GNDhQAwKtT3CeM20PO+80d1HcWN6xdIX9g ujpA4CCuscbWrnWkYE/E7kJD+gamfmQGm8b3UXxN7QSHkOmhplkWONy4VJeksIyd P21VRQ7EG6z8nJD66zxDBMCjaYYVFDthO9nfbGGa7bS3ikueBQCoCd/7s8yPDywS f4Ao2Oseclh1K9cqWmz1pmaAK7UDZjz0pq/1+sbPWfnhOP2WbLQyqalPxWwhJjLY w/RMEz+m7mRrX3ELLOKlRa6Ors2IbdYkqZBanVPRrpwe9KH5nmPuOE/2eZhMOoAv ujfCWiGpubFN/0VdRIuOk+CXEw28xsG7HrZEhDRfzfZ4JJW4Vm53T/RoiVHZsZS+ uBmaZRTADQ22GQOpnyjdOr2UsWs/sDXfSMmVfNPjhWx9Hqy46uej4F0KtIoWpjSv HSdPUkFVOang9GD6P0TvnzxECAHQH3CCwe3BMW9W9qGJ/xG8yPtFqBg/QSw1C/qt ZUzJfvDI4P9l/lgSQsi9EPodLJsU/174VvRcKwaYJZpafV5zJg2WMjYsjudUmw6S uOyQgC845Vp7yBIncapD5K7wJ9y9Wl07yZVIRuBrQe2mf1OCLEZ0jUysyNhHrODB I9WgRVUxiercmbl1PcGNpARJdzTyMH4GfbKsXfgkMxZCzAC3Ftc= =X95y -----END PGP SIGNATURE----- --Sig_/.QnplaZkPf225GrRs_690e3--