From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-94121-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by finch.gentoo.org (Postfix) with ESMTPS id 1E3021382C5
for <garchives@archives.gentoo.org>; Thu, 1 Apr 2021 18:26:47 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id E5602E0952;
Thu, 1 Apr 2021 18:26:42 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id A40ECE0930
for <gentoo-dev@lists.gentoo.org>; Thu, 1 Apr 2021 18:26:42 +0000 (UTC)
Date: Thu, 1 Apr 2021 19:26:27 +0100
From: Sergei Trofimovich <slyfox@gentoo.org>
To: Andreas Sturmlechner <asturm@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v2 1/5] flag-o-matic.eclass: get rid of
eutils in <EAPI-8, fix eclassdoc, make some funcs internal
Message-ID: <20210401192627.0a3ab7f4@sf>
In-Reply-To: <2537255.vuYhMxLoTh@tuxbook>
References: <5252907.rdbgypaU67@tuxbook>
<20210331083321.24e5ead5@sf>
<2537255.vuYhMxLoTh@tuxbook>
X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/DwNFEawr/QKqzsLGmNB4R2=";
protocol="application/pgp-signature"; micalg=pgp-sha512
X-Archives-Salt: c36ba6fc-11e0-4daa-a2ea-d1fc40ddbfba
X-Archives-Hash: 7598a462013280ac41e39d90a587e635
--Sig_/DwNFEawr/QKqzsLGmNB4R2=
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
On Thu, 01 Apr 2021 11:57:01 +0200
Andreas Sturmlechner <asturm@gentoo.org> wrote:
> From 0bdac63ac30fdbe2d1293d0ecbdbc2a5ea673112 Mon Sep 17 00:00:00 2001
> From: Andreas Sturmlechner <asturm@gentoo.org>
> Date: Sun, 28 Mar 2021 11:41:32 +0200
> Subject: [PATCH 1/5] flag-o-matic.eclass: SUPPORTED_EAPIS: 5,6,7; drop eu=
tils,
> multilib
>=20
> - eutils was only used for eqawarn in old EAPI
> - multilib usage unknown, but is inherited by toolchain-funcs anyway
>=20
> Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
> ---
> eclass/flag-o-matic.eclass | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>=20
> diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
> index 20ee39d98ba..ab79f70392d 100644
> --- a/eclass/flag-o-matic.eclass
> +++ b/eclass/flag-o-matic.eclass
> @@ -1,9 +1,10 @@
> -# Copyright 1999-2020 Gentoo Authors
> +# Copyright 1999-2021 Gentoo Authors
> # Distributed under the terms of the GNU General Public License v2
> =20
> # @ECLASS: flag-o-matic.eclass
> # @MAINTAINER:
> # toolchain@gentoo.org
> +# @SUPPORTED_EAPIS: 5 6 7
> # @BLURB: common functions to manipulate and query toolchain flags
> # @DESCRIPTION:
> # This eclass contains a suite of functions to help developers sanely
> @@ -12,7 +13,13 @@
> if [[ -z ${_FLAG_O_MATIC_ECLASS} ]]; then
> _FLAG_O_MATIC_ECLASS=3D1
> =20
> -inherit eutils toolchain-funcs multilib
> +inherit toolchain-funcs
> +
> +case ${EAPI} in
> + [0-4]) die "flag-o-matic.eclass: EAPI ${EAPI} is too old." ;;
> + [5-7]) inherit eutils ;;
> + *) die "EAPI ${EAPI} is not supported by flag-o-matic.eclass." ;;
> +esac
Minor nit: I'd prefer more typical '|' style for string enumerations.
case ${EAPI:-0} in
0|1|2|3|4) ...
5|6|7) ...
Otherwise patch is good.
> # Return all the flag variables that our high level funcs operate on.
> all-flag-vars() {
> --=20
> 2.31.0
>=20
--=20
Sergei
--Sig_/DwNFEawr/QKqzsLGmNB4R2=
Content-Type: application/pgp-signature
Content-Description: Цифровая подпись OpenPGP
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQKTBAEBCgB9FiEE+g11JqJ4cL44QkmN7V5F4G8qwpMFAmBmEFNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEZB
MEQ3NTI2QTI3ODcwQkUzODQyNDk4REVENUU0NUUwNkYyQUMyOTMACgkQ7V5F4G8q
wpOOUQ//Q4G3PcUut3Q21kG2gQfsO/F1Cpe2BD3Lrtz0DlGb57cPa0CUzSb94wSp
jP6yl6nKgJyNzAN2b3yfHl/PmWAzsR+TQ6juRYc6R6HkEsDVN5pyIhVZ9GlY85l7
ro3fleo1b5OpQ1Vy1JJ1TPRH41yhQKBWieUvasVpRcw2W+sMuAXlUXsEE6l7ll+7
+vFwE/zLq5i7FGbZBbVg6LqYvU2jqIAzjtmUmJ9xqunq/WNQooxcC3GyP20gknFZ
ctWTUo/RmJXLMCtmxwk2JkiyjdgdFjdmW3CVzX9ofTCTDsiJ3UCsr1EvKQWUaSGx
Dzsy1Q2L6fx+TnKHEWfeF9HJ/xtO/rP0CKFEBLsFGy3oSPC8hBsu0eJmu2mwbfZk
gI930Lggo6KPNJ/qcXwBWfdGgRsbXD6RtAbzRE8JmNel7U1CsB+U28l5HwTDwRMp
M+x2I6uqynIX/YqoQxv2DFKLS5ycQKw1csHGeUhKX1BFPYUIOwAsbvtvLNshjAQn
G+rpf6jAxiHeP+a0W+VK5pdmWR5mINhgdKziW5WU8UdcdHPGTS7gYPo0QH/gL+ut
/7XusSpzeMmNKw8ZKLRzF0hPYou2ByPeGnXVD9PC6n3RsDPnj0iPeMmLXJf/PiFx
u8DmNUl4M7bn78FGcVBZ7HWqY6zRs+Q7RRw+uSFFo0LsFX060TM=
=kuRk
-----END PGP SIGNATURE-----
--Sig_/DwNFEawr/QKqzsLGmNB4R2=--