* [gentoo-dev] [PATCH 1/2] xorg-3.eclass: Remove XORG_STATIC
@ 2021-01-09 4:16 Matt Turner
2021-01-09 4:16 ` [gentoo-dev] [PATCH 2/2] xorg-2.eclass: " Matt Turner
0 siblings, 1 reply; 3+ messages in thread
From: Matt Turner @ 2021-01-09 4:16 UTC (permalink / raw
To: gentoo-dev; +Cc: Matt Turner
Statically linking X libraries into your program is an extremely bad
idea.
Signed-off-by: Matt Turner <mattst88@gentoo.org>
---
eclass/xorg-3.eclass | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/eclass/xorg-3.eclass b/eclass/xorg-3.eclass
index ece4d97b433..399fc8661f4 100644
--- a/eclass/xorg-3.eclass
+++ b/eclass/xorg-3.eclass
@@ -169,28 +169,6 @@ if [[ ${FONT} == yes ]]; then
FONT_DIR=${FONT_DIR/type1/Type1}
FONT_DIR=${FONT_DIR/speedo/Speedo}
fi
-
-# @ECLASS-VARIABLE: XORG_STATIC
-# @DESCRIPTION:
-# Enables static-libs useflag. Set to no, if your package gets:
-#
-# QA: configure: WARNING: unrecognized options: --disable-static
-: ${XORG_STATIC:="yes"}
-
-# Add static-libs useflag where useful.
-if [[ ${XORG_STATIC} == yes \
- && ${FONT} != yes \
- && ${CATEGORY} != app-doc \
- && ${CATEGORY} != x11-apps \
- && ${CATEGORY} != x11-drivers \
- && ${CATEGORY} != media-fonts \
- && ${PN} != util-macros \
- && ${PN} != xbitmaps \
- && ${PN} != xorg-cf-files \
- && ${PN/xcursor} = ${PN} ]]; then
- IUSE+=" static-libs"
-fi
-
BDEPEND+=" virtual/pkgconfig"
# @ECLASS-VARIABLE: XORG_DRI
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [gentoo-dev] [PATCH 2/2] xorg-2.eclass: Remove XORG_STATIC
2021-01-09 4:16 [gentoo-dev] [PATCH 1/2] xorg-3.eclass: Remove XORG_STATIC Matt Turner
@ 2021-01-09 4:16 ` Matt Turner
2021-01-09 9:48 ` David Seifert
0 siblings, 1 reply; 3+ messages in thread
From: Matt Turner @ 2021-01-09 4:16 UTC (permalink / raw
To: gentoo-dev; +Cc: Matt Turner
Statically linking X libraries into your program is an extremely bad
idea.
Signed-off-by: Matt Turner <mattst88@gentoo.org>
---
eclass/xorg-2.eclass | 23 +----------------------
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/eclass/xorg-2.eclass b/eclass/xorg-2.eclass
index f3b282e1a11..f9a18b8ec26 100644
--- a/eclass/xorg-2.eclass
+++ b/eclass/xorg-2.eclass
@@ -1,4 +1,4 @@
-# Copyright 1999-2020 Gentoo Authors
+# Copyright 1999-2021 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
# @ECLASS: xorg-2.eclass
@@ -168,27 +168,6 @@ fi
# If we're a driver package, then enable DRIVER case
[[ ${PN} == xf86-video-* || ${PN} == xf86-input-* ]] && DRIVER="yes"
-# @ECLASS-VARIABLE: XORG_STATIC
-# @DESCRIPTION:
-# Enables static-libs useflag. Set to no, if your package gets:
-#
-# QA: configure: WARNING: unrecognized options: --disable-static
-: ${XORG_STATIC:="yes"}
-
-# Add static-libs useflag where useful.
-if [[ ${XORG_STATIC} == yes \
- && ${FONT} != yes \
- && ${CATEGORY} != app-doc \
- && ${CATEGORY} != x11-apps \
- && ${CATEGORY} != x11-drivers \
- && ${CATEGORY} != media-fonts \
- && ${PN} != util-macros \
- && ${PN} != xbitmaps \
- && ${PN} != xorg-cf-files \
- && ${PN/xcursor} = ${PN} ]]; then
- IUSE+=" static-libs"
-fi
-
DEPEND+=" virtual/pkgconfig"
# @ECLASS-VARIABLE: XORG_DRI
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [gentoo-dev] [PATCH 2/2] xorg-2.eclass: Remove XORG_STATIC
2021-01-09 4:16 ` [gentoo-dev] [PATCH 2/2] xorg-2.eclass: " Matt Turner
@ 2021-01-09 9:48 ` David Seifert
0 siblings, 0 replies; 3+ messages in thread
From: David Seifert @ 2021-01-09 9:48 UTC (permalink / raw
To: gentoo-dev; +Cc: Matt Turner
On Fri, 2021-01-08 at 23:16 -0500, Matt Turner wrote:
> Statically linking X libraries into your program is an extremely bad
> idea.
>
> Signed-off-by: Matt Turner <mattst88@gentoo.org>
> ---
> eclass/xorg-2.eclass | 23 +----------------------
> 1 file changed, 1 insertion(+), 22 deletions(-)
>
> diff --git a/eclass/xorg-2.eclass b/eclass/xorg-2.eclass
> index f3b282e1a11..f9a18b8ec26 100644
> --- a/eclass/xorg-2.eclass
> +++ b/eclass/xorg-2.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2020 Gentoo Authors
> +# Copyright 1999-2021 Gentoo Authors
> # Distributed under the terms of the GNU General Public License v2
>
> # @ECLASS: xorg-2.eclass
> @@ -168,27 +168,6 @@ fi
> # If we're a driver package, then enable DRIVER case
> [[ ${PN} == xf86-video-* || ${PN} == xf86-input-* ]] && DRIVER="yes"
>
> -# @ECLASS-VARIABLE: XORG_STATIC
> -# @DESCRIPTION:
> -# Enables static-libs useflag. Set to no, if your package gets:
> -#
> -# QA: configure: WARNING: unrecognized options: --disable-static
> -: ${XORG_STATIC:="yes"}
> -
> -# Add static-libs useflag where useful.
> -if [[ ${XORG_STATIC} == yes \
> - && ${FONT} != yes \
> - && ${CATEGORY} != app-doc \
> - && ${CATEGORY} != x11-apps \
> - && ${CATEGORY} != x11-drivers \
> - && ${CATEGORY} != media-fonts \
> - && ${PN} != util-macros \
> - && ${PN} != xbitmaps \
> - && ${PN} != xorg-cf-files \
> - && ${PN/xcursor} = ${PN} ]]; then
> - IUSE+=" static-libs"
> -fi
> -
> DEPEND+=" virtual/pkgconfig"
>
> # @ECLASS-VARIABLE: XORG_DRI
+1 LGTM.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-09 9:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-09 4:16 [gentoo-dev] [PATCH 1/2] xorg-3.eclass: Remove XORG_STATIC Matt Turner
2021-01-09 4:16 ` [gentoo-dev] [PATCH 2/2] xorg-2.eclass: " Matt Turner
2021-01-09 9:48 ` David Seifert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox