From: Sergei Trofimovich <slyfox@gentoo.org>
To: Mike Gilbert <floppym@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org,
Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
Subject: Re: [gentoo-dev] [PATCH] multilib.eclass: Include /$(get_libdir) in PKG_CONFIG_SYSTEM_LIBRARY_PATH.
Date: Tue, 24 Nov 2020 07:50:04 +0000 [thread overview]
Message-ID: <20201124075004.4e5338c7@sf> (raw)
In-Reply-To: <20201124025535.643202-1-floppym@gentoo.org>
On Mon, 23 Nov 2020 21:55:35 -0500
Mike Gilbert <floppym@gentoo.org> wrote:
> From: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
>
> Set also PKG_CONFIG_SYSTEM_INCLUDE_PATH for consistency.
>
> Bug: https://bugs.gentoo.org/756238
> Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
> ---
> eclass/multilib.eclass | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/eclass/multilib.eclass b/eclass/multilib.eclass
> index 9c7042fcd29..33ca9726131 100644
> --- a/eclass/multilib.eclass
> +++ b/eclass/multilib.eclass
> @@ -498,6 +498,7 @@ multilib_toolchain_setup() {
> STRIP
> PKG_CONFIG_LIBDIR
> PKG_CONFIG_PATH
> + PKG_CONFIG_SYSTEM_INCLUDE_PATH
> PKG_CONFIG_SYSTEM_LIBRARY_PATH
> )
>
> @@ -547,7 +548,8 @@ multilib_toolchain_setup() {
> export CHOST=$(get_abi_CHOST $1)
> export PKG_CONFIG_LIBDIR=${EPREFIX}/usr/$(get_libdir)/pkgconfig
> export PKG_CONFIG_PATH=${EPREFIX}/usr/share/pkgconfig
> - export PKG_CONFIG_SYSTEM_LIBRARY_PATH=${EPREFIX}/usr/$(get_libdir)
> + export PKG_CONFIG_SYSTEM_INCLUDE_PATH=${EPREFIX}/usr/include
> + export PKG_CONFIG_SYSTEM_LIBRARY_PATH=${EPREFIX}/$(get_libdir):${EPREFIX}/usr/$(get_libdir)
> fi
> }
The patch looks good. Feel free to push.
--
Sergei
prev parent reply other threads:[~2020-11-24 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 2:55 [gentoo-dev] [PATCH] multilib.eclass: Include /$(get_libdir) in PKG_CONFIG_SYSTEM_LIBRARY_PATH Mike Gilbert
2020-11-24 7:50 ` Sergei Trofimovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124075004.4e5338c7@sf \
--to=slyfox@gentoo.org \
--cc=Arfrever@Apache.Org \
--cc=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox