public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] [PATCH] kernel-2.eclass: use $(CC) as HOSTCC, bug #725878
@ 2020-05-30 12:23 Sergei Trofimovich
  2020-05-30 16:59 ` Manoj Gupta
  0 siblings, 1 reply; 3+ messages in thread
From: Sergei Trofimovich @ 2020-05-30 12:23 UTC (permalink / raw
  To: gentoo-dev; +Cc: Sergei Trofimovich, kernel

Before the change HOSTCC always used gcc. This was
detected by Agostino on linux-headers package.

After the change HOSTCC uses user-specified CC
(or BUILD_CC). Tested on native linux-headers
and on cross-*/linux-headers.

CC: kernel@gentoo.org
Reported-by: Agostino Sarubbo
https://bugs.gentoo.org/725878
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
---
 eclass/kernel-2.eclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
index 930bcf22e29..04edee33930 100644
--- a/eclass/kernel-2.eclass
+++ b/eclass/kernel-2.eclass
@@ -712,6 +712,7 @@ env_setup_xmakeopts() {
 	elif type -p ${CHOST}-ar > /dev/null ; then
 		xmakeopts="${xmakeopts} CROSS_COMPILE=${CHOST}-"
 	fi
+	xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC)"
 	export xmakeopts
 }
 
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [gentoo-dev] [PATCH] kernel-2.eclass: use $(CC) as HOSTCC, bug #725878
  2020-05-30 12:23 [gentoo-dev] [PATCH] kernel-2.eclass: use $(CC) as HOSTCC, bug #725878 Sergei Trofimovich
@ 2020-05-30 16:59 ` Manoj Gupta
  2020-06-03  7:57   ` Sergei Trofimovich
  0 siblings, 1 reply; 3+ messages in thread
From: Manoj Gupta @ 2020-05-30 16:59 UTC (permalink / raw
  To: gentoo-dev; +Cc: Sergei Trofimovich, kernel

[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]

Also see https://bugs.chromium.org/p/chromium/issues/detail?id=1088210 on
Chrome OS.

Verified that this fixes the linux-headers build issue when gcc links are
not installed.

Thanks,
Manoj

On Sat, May 30, 2020 at 5:24 AM Sergei Trofimovich <slyfox@gentoo.org>
wrote:

> Before the change HOSTCC always used gcc. This was
> detected by Agostino on linux-headers package.
>
> After the change HOSTCC uses user-specified CC
> (or BUILD_CC). Tested on native linux-headers
> and on cross-*/linux-headers.
>
> CC: kernel@gentoo.org
> Reported-by: Agostino Sarubbo
> https://bugs.gentoo.org/725878
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
>  eclass/kernel-2.eclass | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
> index 930bcf22e29..04edee33930 100644
> --- a/eclass/kernel-2.eclass
> +++ b/eclass/kernel-2.eclass
> @@ -712,6 +712,7 @@ env_setup_xmakeopts() {
>         elif type -p ${CHOST}-ar > /dev/null ; then
>                 xmakeopts="${xmakeopts} CROSS_COMPILE=${CHOST}-"
>         fi
> +       xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC)"
>         export xmakeopts
>  }
>
> --
> 2.26.2
>
>
>

[-- Attachment #2: Type: text/html, Size: 1938 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-dev] [PATCH] kernel-2.eclass: use $(CC) as HOSTCC, bug #725878
  2020-05-30 16:59 ` Manoj Gupta
@ 2020-06-03  7:57   ` Sergei Trofimovich
  0 siblings, 0 replies; 3+ messages in thread
From: Sergei Trofimovich @ 2020-06-03  7:57 UTC (permalink / raw
  To: Manoj Gupta, gentoo-dev; +Cc: kernel

On Sat, 30 May 2020 09:59:16 -0700
Manoj Gupta <manojgupta@google.com> wrote:

> Also see https://bugs.chromium.org/p/chromium/issues/detail?id=1088210 on
> Chrome OS.
> 
> Verified that this fixes the linux-headers build issue when gcc links are
> not installed.
> 
> Thanks,
> Manoj
> 
> On Sat, May 30, 2020 at 5:24 AM Sergei Trofimovich <slyfox@gentoo.org>
> wrote:
> 
> > Before the change HOSTCC always used gcc. This was
> > detected by Agostino on linux-headers package.
> >
> > After the change HOSTCC uses user-specified CC
> > (or BUILD_CC). Tested on native linux-headers
> > and on cross-*/linux-headers.
> >
> > CC: kernel@gentoo.org
> > Reported-by: Agostino Sarubbo
> > https://bugs.gentoo.org/725878
> > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> > ---
> >  eclass/kernel-2.eclass | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
> > index 930bcf22e29..04edee33930 100644
> > --- a/eclass/kernel-2.eclass
> > +++ b/eclass/kernel-2.eclass
> > @@ -712,6 +712,7 @@ env_setup_xmakeopts() {
> >         elif type -p ${CHOST}-ar > /dev/null ; then
> >                 xmakeopts="${xmakeopts} CROSS_COMPILE=${CHOST}-"
> >         fi
> > +       xmakeopts="${xmakeopts} HOSTCC=$(tc-getBUILD_CC)"
> >         export xmakeopts
> >  }
> >
> > --
> > 2.26.2

Pushed as:
    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3dd41142d73f41e2528eefa32e760fc3083001ee

-- 

  Sergei


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-03  7:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-30 12:23 [gentoo-dev] [PATCH] kernel-2.eclass: use $(CC) as HOSTCC, bug #725878 Sergei Trofimovich
2020-05-30 16:59 ` Manoj Gupta
2020-06-03  7:57   ` Sergei Trofimovich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox