[gentoo-dev] [PATCH v3 1/2] metadata/qa-policy.conf: Introduce QA check configuration

[gentoo-dev] [PATCH v3 1/2] metadata/qa-policy.conf: Introduce QA check configuration

[Michał Górny]

Introduce a new configuration file for assigning QA check significance
levels to PGnnnn policies.  Long-term goal is that this will permit
unified configuration of various QA tools, including pkgcheck, repoman
and install-qa-check.d.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
 metadata/qa-policy.conf | 61 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)
 create mode 100644 metadata/qa-policy.conf

diff --git a/metadata/qa-policy.conf b/metadata/qa-policy.conf
new file mode 100644
index 000000000000..b6ad90337103
--- /dev/null
+++ b/metadata/qa-policy.conf
@@ -0,0 +1,61 @@
+# Copyright 2020 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+# The policy section assigns significance levels to various policies.
+# Keys are identifiers from the Policy Guide, values are either
+# 'notice', 'warning' or 'error'.
+#
+# The rule of thumb is that 'error' indicates a serious problem that
+# may cause serious problem to the end users and therefore should block
+# committing / deployment.  'warning' should be fixed by developer
+# but does not need to immediately prevent committing.
+#
+# https://projects.gentoo.org/qa/policy-guide/std-policy-index.html
+
+[policy]
+# =-dependencies with no revision
+PG0002 = warning
+# Revision bumps on runtime dependency changes
+PG0003 = warning
+# Slot and subslot dependencies: on (sub-)slotted packages
+PG0011 = warning
+# USE dependencies: on packages without the flag
+PG0021 = warning
+# Coding style
+PG0101 = warning
+# Code must be contained within ebuild and eclasses
+PG0102 = error
+# HOMEPAGE must not contain variables
+PG0103 = warning
+# SRC_URI must not refer to HOMEPAGE
+PG0104 = warning
+# KEYWORDS must be defined on a single line
+PG0105 = warning
+# Installation paths
+PG0201 = warning
+# Support for separate /usr
+PG0202 = warning
+# Strict multilib layout
+PG0203 = error
+# Static libraries and libtool files
+PG0204 = error
+# Game install locations and ownership
+PG0205 = warning
+# Absolute symbolic link targets
+PG0206 = warning
+# Python: Eclass usage
+PG0501 = warning
+# Python: Python 2 deprecation
+PG0502 = warning
+# Dynamic slots (multislot flag)
+PG0701 = error
+# HOMEPAGE value must be meaningful
+PG0702 = warning
+# RESTRICT=test for USE=-test
+PG0703 = warning
+# LICENSE
+PG0704 = warning
+# Underscores in USE flag names
+PG0803 = warning
+# User and group account policy
+PG0901 = warning
-- 
2.25.1

[gentoo-dev] [PATCH v3 2/2] metadata/qa-policy.conf: Include deprecated eclasses

[Michał Górny]

Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
 metadata/qa-policy.conf | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/metadata/qa-policy.conf b/metadata/qa-policy.conf
index b6ad90337103..4e822fa2b8ab 100644
--- a/metadata/qa-policy.conf
+++ b/metadata/qa-policy.conf
@@ -59,3 +59,19 @@ PG0704 = warning
 PG0803 = warning
 # User and group account policy
 PG0901 = warning
+
+
+# The deprecated-eclass section lists deprecated eclasses along with
+# their suggested replacements (if any).  Most of the values are
+# replacement eclass names, though free-form text is permitted.
+[deprecated-eclass]
+autotools-multilib = multilib-minimal
+autotools-utils = (none)
+base = (none)
+epatch = (eapply since EAPI 6)
+fdo-mime = xdg-utils
+games = (none)
+ltprune = (inline find ... -delete)
+mono = mono-env
+user = (GLEP 81 acct-* packages)
+versionator = eapi7-ver (built-in since EAPI 7)
-- 
2.25.1

Re: [gentoo-dev] [PATCH v3 2/2] metadata/qa-policy.conf: Include deprecated eclasses

[Kent Fredric]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

On Wed, 26 Feb 2020 15:36:52 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> +fdo-mime = xdg-utils
> +games = (none)

Some of these need to have more context. For instance, a comment for
the games one citing -ml discussions about why the eclass is
deprecated, and what you should be doing instead, might be useful

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [gentoo-dev] [PATCH v3 2/2] metadata/qa-policy.conf: Include deprecated eclasses

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

On Thu, 2020-02-27 at 16:31 +1300, Kent Fredric wrote:
> On Wed, 26 Feb 2020 15:36:52 +0100
> Michał Górny <mgorny@gentoo.org> wrote:
> 
> > +fdo-mime = xdg-utils
> > +games = (none)
> 
> Some of these need to have more context. For instance, a comment for
> the games one citing -ml discussions about why the eclass is
> deprecated, and what you should be doing instead, might be useful

I'm all for it but I think that context should go into eclassdoc or
devmanual in general, and not into increasing CI report size.

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]