From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BD572138334 for ; Sat, 7 Dec 2019 09:00:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 664D9E0876; Sat, 7 Dec 2019 09:00:48 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E5FE7E082D for ; Sat, 7 Dec 2019 09:00:47 +0000 (UTC) Received: from sf (tunnel547699-pt.tunnel.tserv1.lon2.ipv6.he.net [IPv6:2001:470:1f1c:3e6::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: slyfox) by smtp.gentoo.org (Postfix) with ESMTPSA id 0B35734D864 for ; Sat, 7 Dec 2019 09:00:46 +0000 (UTC) Date: Sat, 7 Dec 2019 09:00:40 +0000 From: Sergei Trofimovich Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH v3] mount-boot.eclass: Check if /boot is sane, but don't try to mount it. Message-ID: <20191207090040.033527ae@sf> In-Reply-To: References: <20191206235333.3addea86@sf> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/tigG6.W0TO9ZN9G_5xHa+57"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Archives-Salt: 8ea3d5c5-c953-4bba-9c75-2e9d34d14ad1 X-Archives-Hash: fd2d0ff4c9cf3d512be4c3e133e02ebf --Sig_/tigG6.W0TO9ZN9G_5xHa+57 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 07 Dec 2019 06:44:21 +0100 Ulrich Mueller wrote: > >>>>> On Sat, 07 Dec 2019, Sergei Trofimovich wrote: =20 >=20 > >> # The user wants us to leave things be. > >> - if [[ -n ${DONT_MOUNT_BOOT} ]] ; then > >> + if [[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] ; then > >> return 0 > >> fi =20 >=20 > > The rest of patch looks ok but I find I_KNOW_WHAT_I_AM_DOING > > proliferation worrying. Having enough eclasses guard things on it I > > don't really know what I am doing :) =20 >=20 > > For example developer profile sets it on by default and disables perl > > error checks. I don't think it's intentional. =20 >=20 > Oh, I forgot that it is set globally in the developer profile (and I > think that's a stupid idea). Indeed we should use a different variable > then. >=20 > > I suggest giving this variable a unique specific name. =20 >=20 > Would it be acceptable to leave DONT_MOUNT_BOOT in place? It would have > the advantage that users won't have to update their config. Sounds good. > > And phase out ${I_KNOW_WHAT_I_AM_DOING} uses from tree completely. =20 >=20 > That's a separate discussion. Sure. As long as we don't add extra uses. --=20 Sergei --Sig_/tigG6.W0TO9ZN9G_5xHa+57 Content-Type: application/pgp-signature Content-Description: Цифровая подпись OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQKTBAEBCgB9FiEE+g11JqJ4cL44QkmN7V5F4G8qwpMFAl3rajhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEZB MEQ3NTI2QTI3ODcwQkUzODQyNDk4REVENUU0NUUwNkYyQUMyOTMACgkQ7V5F4G8q wpNzwxAAhCkANoel2wOPwlVwp9IzlrnK3sX20Uy7YbO/A47RJ/qxx29ePfOGXvQx K1DjX564DfK1lju17efYVzKIMGqYx9/yQNKFIEiQ5LER2mir3V+lcHLEUvIht79p bt2Npqe8HqUoq00gkt5udw/bXdtZrPYIY2HHKFPPIJGEtRgqIO78ioTK9Mr4Uz9Q z3uNQdKN5UIO9+1i8a6KTUrL7wCFVGIflCcS441ndb73xaYlhx2UCQQpTEeNbZqx X+ccUYRVd/uyqhsUqrTf2HvZ2nkEgQPFBw1QFNnJnoZQMBzYQjdpgI4ycqEqH/Sl 6M1jiFA2XTAvC/wQzYaqs+Lk7ONsNweeqPudsLFjIJZ7SCWb6YDr/JPdk8AyqfHA 5oOnd18RR+4dAFEzvH95H9dJpmISjhGpARunuuVpUzztwxTpLSIu+H6GlMwUrWRc fdXiCwPxSxXhg3Uh3bm1vW1JbuMIpjNTwwWrE6BaEACh7E2k2nixN0E7C2rr9psp Yhtm87gXsWIXjkLH5hFFP5MuGA3YQRyQTWP/P704oURaMBNRBDifPcrxu3pbAN7n uTvoeCUsdcEx5fpxtJECZ6dzM5av0XPMQtdy+uzPAfn5j026GUN+GMO9bZVfT86m Zo6CfBB+a9Ei//+VkwGaT5MgcMAnM4wB9lev38cFLO0QsI+od/k= =3DaV -----END PGP SIGNATURE----- --Sig_/tigG6.W0TO9ZN9G_5xHa+57--