From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-89568-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by finch.gentoo.org (Postfix) with ESMTPS id 177F1138334
for <garchives@archives.gentoo.org>; Fri, 6 Dec 2019 23:53:42 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id AD607E0886;
Fri, 6 Dec 2019 23:53:38 +0000 (UTC)
Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id 58B74E086A
for <gentoo-dev@lists.gentoo.org>; Fri, 6 Dec 2019 23:53:38 +0000 (UTC)
Received: from sf (tunnel547699-pt.tunnel.tserv1.lon2.ipv6.he.net [IPv6:2001:470:1f1c:3e6::2])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
(Authenticated sender: slyfox)
by smtp.gentoo.org (Postfix) with ESMTPSA id C1F6734D858
for <gentoo-dev@lists.gentoo.org>; Fri, 6 Dec 2019 23:53:36 +0000 (UTC)
Date: Fri, 6 Dec 2019 23:53:33 +0000
From: Sergei Trofimovich <slyfox@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v3] mount-boot.eclass: Check if /boot is
sane, but don't try to mount it.
Message-ID: <20191206235333.3addea86@sf>
In-Reply-To: <w6gv9qt4gbq.fsf@kph.uni-mainz.de>
References: <w6gv9qt4gbq.fsf@kph.uni-mainz.de>
X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: ff0b7dec-1b3d-46d7-a5ef-dfaf2fff48e6
X-Archives-Hash: c534c353c6a257e9e5174e6fb0a0f671
On Fri, 06 Dec 2019 16:35:53 +0100
Ulrich M=C3=BCller <ulm@gentoo.org> wrote:
> # The user wants us to leave things be.
> - if [[ -n ${DONT_MOUNT_BOOT} ]] ; then
> + if [[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] ; then
> return 0
> fi
The rest of patch looks ok but I find I_KNOW_WHAT_I_AM_DOING
proliferation worrying. Having enough eclasses guard things on it I don't
really know what I am doing :)
For example developer profile sets it on by default and disables perl error
checks. I don't think it's intentional.
I suggest giving this variable a unique specific name. And phase out
${I_KNOW_WHAT_I_AM_DOING} uses from tree completely.
--=20
Sergei