From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-89567-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by finch.gentoo.org (Postfix) with ESMTPS id 16CC3138334
for <garchives@archives.gentoo.org>; Fri, 6 Dec 2019 23:44:49 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id 99A09E086C;
Fri, 6 Dec 2019 23:44:45 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id 5E24EE085A
for <gentoo-dev@lists.gentoo.org>; Fri, 6 Dec 2019 23:44:45 +0000 (UTC)
Received: from sf (tunnel547699-pt.tunnel.tserv1.lon2.ipv6.he.net [IPv6:2001:470:1f1c:3e6::2])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
(Authenticated sender: slyfox)
by smtp.gentoo.org (Postfix) with ESMTPSA id 47B4934D855
for <gentoo-dev@lists.gentoo.org>; Fri, 6 Dec 2019 23:44:44 +0000 (UTC)
Date: Fri, 6 Dec 2019 23:44:38 +0000
From: Sergei Trofimovich <slyfox@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] cargo.eclass: use verbose cargo
invocations
Message-ID: <20191206234438.63218eb2@sf>
In-Reply-To: <20191206200931.22347-1-gyakovlev@gentoo.org>
References: <20191206200931.22347-1-gyakovlev@gentoo.org>
X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Archives-Salt: 65c4ae62-38f1-421a-b37e-d5bdcb2e573c
X-Archives-Hash: 0d676575fb62ce2e55a9ca64ed0e9cd5
On Fri, 6 Dec 2019 12:09:31 -0800
Georgy Yakovlev <gyakovlev@gentoo.org> wrote:
> Default output just prints crate name.
> With -vv we can see all cargo options and rustc args.
>
> Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
> ---
Looks good!
I had to do an equivalent locally at least a few times.
While at it I also suggest adding equivalent of
econf's/emake's ${EXTRA_ECONF} and ${EXTRA_EMAKE}
to allow users to inject arbitrary stuff. For example
to sneak in '-Z' options globally.
Say, ${CARGO_BUILD_EXTRA}, ${CARGO_INSTALL_EXTRA},
${CARGO_TEST_EXTRA}.
> eclass/cargo.eclass | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/eclass/cargo.eclass b/eclass/cargo.eclass
> index 5b6d1f050f1..13dd5c355fb 100644
> --- a/eclass/cargo.eclass
> +++ b/eclass/cargo.eclass
> @@ -146,7 +146,7 @@ cargo_src_compile() {
>
> export CARGO_HOME="${ECARGO_HOME}"
>
> - cargo build -j $(makeopts_jobs) $(usex debug "" --release) "$@" \
> + cargo build -vv -j $(makeopts_jobs) $(usex debug "" --release) "$@" \
> || die "cargo build failed"
> }
>
> @@ -156,7 +156,7 @@ cargo_src_compile() {
> cargo_src_install() {
> debug-print-function ${FUNCNAME} "$@"
>
> - cargo install -j $(makeopts_jobs) --root="${ED}/usr" $(usex debug --debug "") "$@" \
> + cargo install -vv -j $(makeopts_jobs) --root="${ED}/usr" $(usex debug --debug "") "$@" \
> || die "cargo install failed"
> rm -f "${ED}/usr/.crates.toml"
>
> @@ -169,7 +169,7 @@ cargo_src_install() {
> cargo_src_test() {
> debug-print-function ${FUNCNAME} "$@"
>
> - cargo test -j $(makeopts_jobs) $(usex debug "" --release) "$@" \
> + cargo test -vv -j $(makeopts_jobs) $(usex debug "" --release) "$@" \
> || die "cargo test failed"
> }
>
> --
> 2.23.0
>
>
--
Sergei