From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C3020138334 for ; Fri, 6 Dec 2019 09:33:44 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C74A3E0893; Fri, 6 Dec 2019 09:33:40 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 86BB8E0886 for ; Fri, 6 Dec 2019 09:33:40 +0000 (UTC) Received: by smtp.gentoo.org (Postfix, from userid 2274) id 81DE134D82E; Fri, 6 Dec 2019 09:33:39 +0000 (UTC) Date: Fri, 6 Dec 2019 04:33:36 -0500 From: Tim Harder To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template Message-ID: <20191206093336.GA6649@sumac.radhermit.com> Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20191205160957.576971-1-mgorny@gentoo.org> <067cc5678d1eb4a3445bdf7beefe8c055307eeb4.camel@gentoo.org> <31d2646b48bc35d02ca2a7a0b9db7b634d5b0ef0.camel@gentoo.org> <20191206082325.GA5714@sumac.radhermit.com> <2cf18040c81c4eb0afbbf3282bacb150c80b572f.camel@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2cf18040c81c4eb0afbbf3282bacb150c80b572f.camel@gentoo.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-Archives-Salt: 65b2814c-670c-41ac-b6b0-26ecb8a75c57 X-Archives-Hash: dbfebbc6e7918b938498c7bdad9bb012 On 2019-12-06 Fri 04:03, Alexis Ballier wrote: > it's not just like repoman and cvs since repoman commit did push ;) > it will never be perfect but i really like repoman commit to refuse to > even commit if there's something obviously wrong I'm more of the opinion (and am working towards that practicality in terms of runtime speed) that a subset of QA checks should be run as a git hook which would cause push failures on certain classes of bad commits. > as you write below, it's just a matter of checking exit status and > using git, which can be done by scripting, but the script is standard > (*) and mandated to be part of the workflow > it also allows to check or templatize commit messages to follow policy Technically pkgcheck supports more git-related checks than repoman last I checked, i.e. result keywords including BadCommitSummary, DirectStableKeywords, DroppedUnstableKeywords, DroppedStableKeywords, DirectNoMaintainer, and MissingSignOff; with possible future additions such as warning when modifying deps in an ebuild without revbumping. Futhermore, one can scan against all commits in parallel via `pkgcheck scan --commits` which will enable potential commit results that are otherwise skipped. Anyway, my main point is that if someone really wants commit functionality it's semi-trivial to script something similar to what repoman does (assuming exit status/api support exists) and if it's decent enough quality (including tests) I'd probably consider adding it to the pkgcheck repo. Tim