From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 606D7138334 for ; Sat, 2 Nov 2019 08:55:13 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3F5F0E0899; Sat, 2 Nov 2019 08:55:09 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EBC6AE087B for ; Sat, 2 Nov 2019 08:55:08 +0000 (UTC) Received: from katipo2.lan (unknown [203.86.205.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kentnl) by smtp.gentoo.org (Postfix) with ESMTPSA id 9D35934C696 for ; Sat, 2 Nov 2019 08:55:07 +0000 (UTC) Date: Sat, 2 Nov 2019 21:54:57 +1300 From: Kent Fredric To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] RFC: Require full $P not just $PN on stable/keyword commit messages Message-ID: <20191102215457.022cb7b6@katipo2.lan> In-Reply-To: <55b42dc1-cbfd-8fa0-8bfd-433e7c92a21f@veremit.xyz> References: <55b42dc1-cbfd-8fa0-8bfd-433e7c92a21f@veremit.xyz> Organization: Gentoo X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/qsnTG1cKtQlYX=lUEw8xvZd"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Archives-Salt: c717bada-1070-48e2-af58-cf8ba8e6fe97 X-Archives-Hash: 524976f1f8dd44650251bb6e9e4ac137 --Sig_/qsnTG1cKtQlYX=lUEw8xvZd Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 1 Nov 2019 19:59:35 +0000 Michael 'veremitz' Everitt wrote: > Thoughts from outside peanut gallery? >=20 > Michael / veremitz. I have an alternative that might be more pleasant: 1. Change repoman so that when its clear that: - There is at least one ebuild being changed - There is only one ebuild being changed Then the templated summary line is full ${P} 2. Otherwise, retain the current semantics of using a simpler ${P} in other cases. 3. Make no *requirements* that ${P} be used instead of ${PN}, and that way people who think they have a good reason to use ${PN} instead of ${P} can do just that (if for instance, they need to lop off context so they can have a longer commit message ) This IMO improves things by default, given that the majority of changes get run through repoman, and a majority of changes have very terse requirements for extra data. It also means that by default, when people just make the commit message something silly like "bump", or "version bump", despite the fact they didn't put in much effort, the log defaults to being useful, and the commit messages relayed to #gentoo-commits improves in usefulness. Partly, because for me, one of my prime vectors where I become aware changes are occuring is in #gentoo commits, particularly because something in there highlights me. I don't want to *have* to: - Resync my git repo=20 - Dig into git wizardry=20 *just* to ascertain what version was involved, and to then ascertain if I need to investigate further. ( Because once I've already synced and started using git wizardry, I'm already starting to pay investigation taxes ) --Sig_/qsnTG1cKtQlYX=lUEw8xvZd Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEgdrME8Lrmai3DXYJda6SGagVg7UFAl29RGEACgkQda6SGagV g7X0HA/+INW9sTsK4HsUYo8QQuWVuSp2mrPRlPmJEpe1px+KZ8Nz4HPwQj/HSeok tYyYVNz2teu5wvwfYy77Jr8jTxg3AV5/8y3aH2awHuSz4YHxPFYIltP6S5Pe4jA0 s8P3FaU/1HxTkBYRoXxAlgBoxxjh9VzIoMCZyJL+eT0QTfsLiuFcK2Sq4LJDrRNO dewaF0L7evKxumT2+NwjtHvozamRqgHOTeRX9kO4tV5G99gpDOAHq5mKOk7RxXGH noxSXnhnJU3d/uw5IYQMG2H//OwYiOOQbrPd/yOwFXQvq2hkML9ojcFxlVajYbfq 6lUXEyLNAOHWAoID41NaraG93lbTc3P9k15IDOw72oE4+rmdu1n7L9qP8KchLYSI Q1wSqt+BI0ktj5ae0sRwJjR4kQ3k89FH6QBvZOdAWXIzUb4VHv7QFGse1MGICWbb AspGSLiSsvfYJs5Yxs/nU+53EGOBSY70+733loMKquYI8rxfqI/jXiM6rvVZhZYv c3+9pmIEozZrwVNZAl7WxEn4oMehnIDKo9SdIy0Tk7dSjSwCmMKJ2FC8Zy37RJBt lZKvKH6FiPx439lZvsTatbxSlV+JE8+l3TaYUyWy4+VBhFqnHeiAQ4dkDwf69O0l PxltiSA3AW+QSwFf6aZm9+JSCUg7YODTwHF5QZW6wto9w+anzbk= =U1D3 -----END PGP SIGNATURE----- --Sig_/qsnTG1cKtQlYX=lUEw8xvZd--