From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 6DA25138334 for ; Fri, 1 Nov 2019 23:08:56 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5DF9FE0821; Fri, 1 Nov 2019 23:08:52 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id F17EFE0819 for ; Fri, 1 Nov 2019 23:08:51 +0000 (UTC) Received: from sf (tunnel547699-pt.tunnel.tserv1.lon2.ipv6.he.net [IPv6:2001:470:1f1c:3e6::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: slyfox) by smtp.gentoo.org (Postfix) with ESMTPSA id C0EC434C694; Fri, 1 Nov 2019 23:08:48 +0000 (UTC) Date: Fri, 1 Nov 2019 23:08:31 +0000 From: Sergei Trofimovich To: Michael 'veremitz' Everitt Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] RFC: Require full $P not just $PN on stable/keyword commit messages Message-ID: <20191101230831.77c56bed@sf> In-Reply-To: <55b42dc1-cbfd-8fa0-8bfd-433e7c92a21f@veremit.xyz> References: <55b42dc1-cbfd-8fa0-8bfd-433e7c92a21f@veremit.xyz> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 76a2230a-d5a4-4f42-bd02-218e7e5eb226 X-Archives-Hash: 1dd2af1e37e97340a4463f7012cdc8d5 On Fri, 1 Nov 2019 19:59:35 +0000 Michael 'veremitz' Everitt wrote: > Hello, > > I've noticed a lot of stabilisation commit messages (and a few keywording > ones too) simply state the package atom and not the relevant > release/version. I find this a little meaningless, as unless this is the > first time the package has ever been either stabilised or keyworded, it is > reasonable to expect that there is/was some transition point for a package > from when it first entered the Gentoo Repository. > > Therefore, it would be much /more/ useful to have the package-version > tagged in the commit message, so that you could easily grep logs for when a > given version of a package was stabilised, and/or keyworded. Granted, this > is more of-use in a historical context compared to a present (future?!) > one, but I would argue that it conveys more meaning -with- the version than > without. > > Thoughts from outside peanut gallery? A few points: 1. Given that you can't rely on that information today it won't be of much use in future if it's already not precise. If you want consistent keywording/stabilizing behaviour you might want to propose/implement a tool that generates commits in a form everybody agrees. Say, a specific form of repoman commit. Today even keywording itself in not exactly fully automated process: https://bugs.gentoo.org/639724 2. repoman was changed to disallow long enough subject lines from being committed. As a result sometimes you can't just fit both package name and package version into the fist line. Let alone full arch list and bug number. Thus requiring ${P} is technically infeasible. It would probably help to describe original problem in more detail being solved before discussing of a solution. If you need a precise solution for "when foo was stabilized" you have to look at the ebuild's metadata as an authoritative source. -- Sergei