From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id A144C138334 for ; Tue, 22 Oct 2019 00:36:57 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 81BA3E0B13; Tue, 22 Oct 2019 00:36:53 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 324F9E085E for ; Tue, 22 Oct 2019 00:36:53 +0000 (UTC) Received: from katipo2.lan (unknown [203.86.205.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kentnl) by smtp.gentoo.org (Postfix) with ESMTPSA id B689034C1B1 for ; Tue, 22 Oct 2019 00:36:51 +0000 (UTC) Date: Tue, 22 Oct 2019 13:36:42 +1300 From: Kent Fredric To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Proposal: change to default policy of doing changes to packages that are maintained by other developers Message-ID: <20191022133642.41590ee5@katipo2.lan> In-Reply-To: References: Organization: Gentoo X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/FHZOuYBq22uDKi/J58y4ZlC"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Archives-Salt: 28b56f36-425c-427f-96b7-0c53d8a0aae6 X-Archives-Hash: 4ac39d03b32835eb8a18a3ca589962d5 --Sig_/FHZOuYBq22uDKi/J58y4ZlC Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 21 Oct 2019 19:37:28 +0200 Piotr Karbowski wrote: > This is a bit unhealthy, especially when some developers that maintain > packages are out of reach, or the patches to update ebuild just rot on > the bugzilla and are not taken in by maintainers. IME this is far from the norm and should not be used as the justification here. I would argue some *honest* attempt be made to contact the people officially responsible for the package. If they can't be contacted in a reasonable time frame, sure, by all means. But I cannot support a policy where it creates a conjecture of "I think this patch doesn't matter, so I'll just do it". Because in practice, no change, no matter how apparently insignificant, is immune from the risk of creating a quality reduction. And no change, is immune from potentially affecting the package maintainers workflow. ( For example, if you drop in a sed, or a patch, when the package uses a carefully curated tar-ball of patches which are also carefully tested against upstream sources on travis or something, by dropping the patch in unconsulted, you run the risk of pissing somebody off by adding a patch in ways that by-passes and potentially confounds these efforts. ) It really sucks having to review somebodies changes after-the-fact where you discover the change long after it was done, because nobody even tried to communicate. Reasonable attempts should be made, _especially_ if there are multiple maintainers for a package, or a project with multiple members. If you don't have the patience to even wait _one_ day for a response, maybe you shouldn't be doing opensource. --Sig_/FHZOuYBq22uDKi/J58y4ZlC Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEgdrME8Lrmai3DXYJda6SGagVg7UFAl2uTxoACgkQda6SGagV g7XZvQ/7BPDYfNQOc2LUn/MmKvJecnOi8g4QPp4d5anc3z2KrklDkkXOoUFpguCR V5mGV93bAns+wQ/YlX42qjCwOme9ZO8f2CeI18lvaiTrH/gw5WzI0JPbMCPHBt8O QdFButhTGMLOZGTbL+0AAhkOKV/v2wZEqnehq8ezCji4vYh64Z6g7GZlQHJiYA17 FL+32rlxd/Ex5VBksoYz9z1xEYkDDdJKekfv7zxCqyhQz8ilDybUfVFz3WrRAj2P C3GmE2a7ZwP2ljTVBqxUFW1LRAHE3LGevn9kwABUlFev7MlBnvibOBUEFl40e1UN CSq4aEgWXl7hJZh9GoGI8b0O1AeeqEI51xX0wTWKTSdSDCXyw1lihql7BU1WIij5 z+kNbVq6gORJupQdrwVnUSIGu7qmk7Ia1PCbGOcLbx4XYI+MB2G0UyzwYRLIReIF 8OXlk/S4N5IJh97Rvs3DH7TV7jnhdmJLFxxfzB0/86/d5fk2igsww4z7dPEWTTvl f5rbt4EW0w8YYHmOkQqhndY3ZcikAylMTXBv59qpuGjmqp29rD/9sccNHEBKjOD5 38pAQmfLYvOMMveWdPrcNtZKtQHOqwTB8rqXiqKGvhHHFGcJIf1W1was8WZp5BqR Y57RhPhmDa8weGRkkIYUU1uQyqjTNl5oJTJWFlE9yjvOckBL7Go= =lEPH -----END PGP SIGNATURE----- --Sig_/FHZOuYBq22uDKi/J58y4ZlC--