public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] [PATCH 0/1] go-module.eclass: only show wwarning for new packages
@ 2019-10-01 21:07 William Hubbs
  2019-10-01 21:07 ` [gentoo-dev] [PATCH 1/1] go-module.eclass: only show warning " William Hubbs
  0 siblings, 1 reply; 4+ messages in thread
From: William Hubbs @ 2019-10-01 21:07 UTC (permalink / raw
  To: gentoo-dev; +Cc: William Hubbs

*** BLURB HERE ***
The pkg_postinst function in this eclass should only display the warning
if the user is installing a new package, not for upgrades.

William Hubbs (1):
  go-module.eclass: only show warning for new packages

 eclass/go-module.eclass | 1 +
 1 file changed, 1 insertion(+)

-- 
2.21.0



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [gentoo-dev] [PATCH 1/1] go-module.eclass: only show warning for new packages
  2019-10-01 21:07 [gentoo-dev] [PATCH 0/1] go-module.eclass: only show wwarning for new packages William Hubbs
@ 2019-10-01 21:07 ` William Hubbs
  2019-10-01 21:29   ` William Hubbs
  0 siblings, 1 reply; 4+ messages in thread
From: William Hubbs @ 2019-10-01 21:07 UTC (permalink / raw
  To: gentoo-dev; +Cc: William Hubbs

---
 eclass/go-module.eclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
index e6152966911..f1f1d743f43 100644
--- a/eclass/go-module.eclass
+++ b/eclass/go-module.eclass
@@ -165,6 +165,7 @@ go-module_live_vendor() {
 # Display a warning about security updates for Go programs.
 go-module_pkg_postinst() {
 	debug-print-function ${FUNCNAME} "$@"
+	[[ -n ${REPLACING_VERSIONS} ]] || return 0
 	ewarn "${PN} is written in the Go programming language."
 	ewarn "Since this language is statically linked, security"
 	ewarn "updates will be handled in individual packages and will be"
-- 
2.21.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: only show warning for new packages
  2019-10-01 21:07 ` [gentoo-dev] [PATCH 1/1] go-module.eclass: only show warning " William Hubbs
@ 2019-10-01 21:29   ` William Hubbs
  2019-10-02 18:23     ` William Hubbs
  0 siblings, 1 reply; 4+ messages in thread
From: William Hubbs @ 2019-10-01 21:29 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

On Tue, Oct 01, 2019 at 04:07:49PM -0500, William Hubbs wrote:
> ---
>  eclass/go-module.eclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
> index e6152966911..f1f1d743f43 100644
> --- a/eclass/go-module.eclass
> +++ b/eclass/go-module.eclass
> @@ -165,6 +165,7 @@ go-module_live_vendor() {
>  # Display a warning about security updates for Go programs.
>  go-module_pkg_postinst() {
>  	debug-print-function ${FUNCNAME} "$@"
> +	[[ -n ${REPLACING_VERSIONS} ]] || return 0

Typo fix, || will be changed to && before I commit.

William

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: only show warning for new packages
  2019-10-01 21:29   ` William Hubbs
@ 2019-10-02 18:23     ` William Hubbs
  0 siblings, 0 replies; 4+ messages in thread
From: William Hubbs @ 2019-10-02 18:23 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

On Tue, Oct 01, 2019 at 04:29:52PM -0500, William Hubbs wrote:
> On Tue, Oct 01, 2019 at 04:07:49PM -0500, William Hubbs wrote:
> > ---
> >  eclass/go-module.eclass | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
> > index e6152966911..f1f1d743f43 100644
> > --- a/eclass/go-module.eclass
> > +++ b/eclass/go-module.eclass
> > @@ -165,6 +165,7 @@ go-module_live_vendor() {
> >  # Display a warning about security updates for Go programs.
> >  go-module_pkg_postinst() {
> >  	debug-print-function ${FUNCNAME} "$@"
> > +	[[ -n ${REPLACING_VERSIONS} ]] || return 0
> 
> Typo fix, || will be changed to && before I commit.

This is done and committed.

Thanks,

William

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-02 18:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-01 21:07 [gentoo-dev] [PATCH 0/1] go-module.eclass: only show wwarning for new packages William Hubbs
2019-10-01 21:07 ` [gentoo-dev] [PATCH 1/1] go-module.eclass: only show warning " William Hubbs
2019-10-01 21:29   ` William Hubbs
2019-10-02 18:23     ` William Hubbs

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox