public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Manoj Gupta <manojgupta@google.com>
To: gentoo-dev@lists.gentoo.org
Cc: Manoj Gupta <manojgupta@google.com>
Subject: [gentoo-dev] [PATCH] sys-libs/db: Remove --default-symver usage.
Date: Fri, 27 Sep 2019 12:31:43 -0700	[thread overview]
Message-ID: <20190927193143.196168-1-manojgupta@google.com> (raw)

sys-libs/db-18.1.32 can builds without "--default-symver"
linker flag. This fixes the build issue when using LLD linker
which does not support this flag.

Given that sys-libs/db is the only Gentoo package using
"--default-symver" linker, it is probably not a terrible idea to
drop use of "--default-symver" flag.

Signed-off-by: Manoj Gupta <manojgupta@google.com>
---
 sys-libs/db/{db-18.1.32.ebuild => db-18.1.32-r1.ebuild} | 6 ------
 1 file changed, 6 deletions(-)
 rename sys-libs/db/{db-18.1.32.ebuild => db-18.1.32-r1.ebuild} (97%)

diff --git a/sys-libs/db/db-18.1.32.ebuild b/sys-libs/db/db-18.1.32-r1.ebuild
similarity index 97%
rename from sys-libs/db/db-18.1.32.ebuild
rename to sys-libs/db/db-18.1.32-r1.ebuild
index be515fd043e..c23babeb9d9 100644
--- a/sys-libs/db/db-18.1.32.ebuild
+++ b/sys-libs/db/db-18.1.32-r1.ebuild
@@ -146,12 +146,6 @@ multilib_src_configure() {
 		is-flagq -O[s123] || append-flags -O2
 	fi
 
-	# Add linker versions to the symbols. Easier to do, and safer than header file
-	# mumbo jumbo.
-	if use userland_GNU ; then
-		append-ldflags -Wl,--default-symver
-	fi
-
 	# use `set` here since the java opts will contain whitespace
 	if multilib_is_native_abi && use java ; then
 		myconf+=(
-- 
2.23.0.444.g18eeb5a265-goog



             reply	other threads:[~2019-09-27 19:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27 19:31 Manoj Gupta [this message]
2019-09-27 19:48 ` [gentoo-dev] [PATCH] sys-libs/db: Remove --default-symver usage Brian Evans
2019-09-27 19:54   ` Manoj Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190927193143.196168-1-manojgupta@google.com \
    --to=manojgupta@google.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox