From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id B9BDE138334 for ; Mon, 16 Sep 2019 18:35:08 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 35395E09C6; Mon, 16 Sep 2019 18:35:05 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D736FE0997 for ; Mon, 16 Sep 2019 18:35:04 +0000 (UTC) Received: from whubbs1.gaikai.biz (unknown [100.42.103.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: williamh) by smtp.gentoo.org (Postfix) with ESMTPSA id 97DBD34B224; Mon, 16 Sep 2019 18:35:03 +0000 (UTC) Received: (nullmailer pid 27959 invoked by uid 1000); Mon, 16 Sep 2019 18:35:00 -0000 Date: Mon, 16 Sep 2019 13:35:00 -0500 From: William Hubbs To: gentoo-dev@lists.gentoo.org Cc: zmedico@gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules Message-ID: <20190916183500.GB27855@whubbs1.dev.av1.gaikai.org> Mail-Followup-To: gentoo-dev@lists.gentoo.org, zmedico@gentoo.org References: <20190916141719.12922-1-williamh@gentoo.org> <20190916141719.12922-2-williamh@gentoo.org> <2f70ef66-63d7-0359-17a0-e517979f700d@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8P1HSweYDcXXzwPJ" Content-Disposition: inline In-Reply-To: <2f70ef66-63d7-0359-17a0-e517979f700d@gentoo.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Archives-Salt: 950fa122-5e35-46aa-88e6-09b22fa41a17 X-Archives-Hash: b4bee882918090ab2a731fcd0f5f676e --8P1HSweYDcXXzwPJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 16, 2019 at 11:01:38AM -0700, Zac Medico wrote: > On 9/16/19 7:17 AM, William Hubbs wrote: > > +# You will know the software you are packaging uses modules because > > +# it will have files named go.sum and go.mod in its top-level source > > +# directory. If it does not have these files, use the golang-* eclasse= s. > > +# > > +# If the software you are packaging uses modules, the next question is > > +# whether it has a directory named "vendor" at the top-level of the so= urce tree. > > +# > > +# If it doesn't, you need to create a tarball of what would be in the > > +# vendor directory and mirror it locally. > > +# If foo-1.0 is the name of your project and you have the tarball for = it > > +# in your current directory, this is done with the following commands: > > +# > > +# @CODE: > > +# > > +# tar -xf foo-1.0.tar.gz > > +# cd foo-1.0 > > +# go mod vendor > > +# cd .. > > +# tar -acf foo-1.0-vendor.tar.gz foo-1.0/vendor >=20 > For packages that I maintain, I'd prefer to continue using EGO_VENDOR to > even with packages using go.mod. I hope that this go-module.class will > not preclude this sort of usage. For example, the latest go-tools ebuild > uses EGO_VENDOR together with GOFLAGS=3D"-mod=3Dvendor": >=20 > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3D8cc6d401139526e2f9= a6dbadbd31f0ff2387705f Can you elaborate on why you want to keep EGO_VENDOR? The "go mod vendor" command above downloads all the correct versions of the dependencies and puts them in the vendor directory, so I'm not sure why you would need the EGO_VENDOR variable. Thanks, William --8P1HSweYDcXXzwPJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTVeuxEZo4uUHOkQAluVBb0MMRlOAUCXX/V1AAKCRBuVBb0MMRl ODQvAJ9AaA96rqFdFePzOb8IilHdrmcmEQCeMRmvuV3aRlS6E4DoOyTEakw9iZ8= =LKq/ -----END PGP SIGNATURE----- --8P1HSweYDcXXzwPJ--