From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 98DF7138334 for ; Mon, 16 Sep 2019 17:40:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C364CE09D1; Mon, 16 Sep 2019 17:40:22 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 76326E09C9 for ; Mon, 16 Sep 2019 17:40:22 +0000 (UTC) Received: from whubbs1.gaikai.biz (unknown [100.42.103.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: williamh) by smtp.gentoo.org (Postfix) with ESMTPSA id D68E934B24C; Mon, 16 Sep 2019 17:40:08 +0000 (UTC) Received: (nullmailer pid 27727 invoked by uid 1000); Mon, 16 Sep 2019 17:40:05 -0000 Date: Mon, 16 Sep 2019 12:40:05 -0500 From: William Hubbs To: gentoo-dev@lists.gentoo.org Cc: mgorny@gentoo.org, soap@gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules Message-ID: <20190916174005.GA27707@whubbs1.dev.av1.gaikai.org> Mail-Followup-To: gentoo-dev@lists.gentoo.org, mgorny@gentoo.org, soap@gentoo.org References: <20190916141719.12922-1-williamh@gentoo.org> <20190916141719.12922-2-williamh@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+HP7ph2BbKc20aGI" Content-Disposition: inline In-Reply-To: <20190916141719.12922-2-williamh@gentoo.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Archives-Salt: 249204a3-a2a7-4c3d-8b3c-49665298b238 X-Archives-Hash: 9894304f581f6ca23e1a4eb076f95078 --+HP7ph2BbKc20aGI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline All, here is my thought about the src_prepare function in the eclass. It is commented right now, but I want to uncomment it and not force ${P} into the path in the vendor tarball if no one objects; I think it is easier to do that because it would allow me to detect when upstream vendors and the maintainer tries to provide a vendor tarball at the same time as shown in the first if block in the function. Let me know if you agree or disagree with this. Thanks, William --+HP7ph2BbKc20aGI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTVeuxEZo4uUHOkQAluVBb0MMRlOAUCXX/I8AAKCRBuVBb0MMRl OND/AKCPuOnaO7xxMDRdJKxiLGykE1vPagCcCctdg9AGrIgPbyAeZyevvrYKgSA= =7cU1 -----END PGP SIGNATURE----- --+HP7ph2BbKc20aGI--