[gentoo-dev] [PATCH 1/2] use.desc: Make lz4 a global flag

[gentoo-dev] [PATCH 1/2] use.desc: Make lz4 a global flag

[Michał Górny]

The 'lz4' flag is used consistently for the LZ4 compression algorithm
in 23 packages.  Make it a global flag.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
 profiles/use.desc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/profiles/use.desc b/profiles/use.desc
index 136d86900685..0969d8f8b7b5 100644
--- a/profiles/use.desc
+++ b/profiles/use.desc
@@ -182,6 +182,7 @@ lm-sensors - Add linux lm-sensors (hardware sensors) support
 lua - Enable Lua scripting support
 luajit - Use dev-lang/luajit instead of dev-lang/lua (ineffective with USE=-lua)
 lzma - Support for LZMA (de)compression algorithm
+lz4 - Enable support for lz4 compression (as implemented in app-arch/lz4)
 lzo - Enable support for lzo compression
 m17n-lib - Enable m17n-lib support
 mad - Add support for mad (high-quality mp3 decoder library and cli frontend)
-- 
2.23.0

[gentoo-dev] [PATCH 2/2] */*: Remove redundant descriptions for USE=lz4

[Michał Górny]

Remove local descriptions of 'lz4' flag where they add nothing to
the global description.  They were left where they are more precise,
e.g. indicate what the compression is used for or indicate another
provider.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
 app-arch/libarchive/metadata.xml      | 3 ---
 app-arch/zstd/metadata.xml            | 5 -----
 app-backup/fsarchiver/metadata.xml    | 3 ---
 app-emulation/spice/metadata.xml      | 1 -
 dev-libs/c-blosc/metadata.xml         | 1 -
 dev-python/fastparquet/metadata.xml   | 1 -
 dev-util/squashdelta/metadata.xml     | 3 ---
 dev-util/squashmerge/metadata.xml     | 3 ---
 net-analyzer/wireshark/metadata.xml   | 1 -
 net-mail/dovecot/metadata.xml         | 1 -
 net-misc/spice-gtk/metadata.xml       | 2 --
 net-vpn/openconnect/metadata.xml      | 1 -
 net-vpn/openvpn/metadata.xml          | 1 -
 sys-fs/squashfs-tools-ng/metadata.xml | 1 -
 sys-fs/squashfs-tools/metadata.xml    | 1 -
 sys-fs/squashfuse/metadata.xml        | 3 ---
 x11-wm/xpra/metadata.xml              | 1 -
 17 files changed, 32 deletions(-)

diff --git a/app-arch/libarchive/metadata.xml b/app-arch/libarchive/metadata.xml
index 69042b3e7224..553fc08711f4 100644
--- a/app-arch/libarchive/metadata.xml
+++ b/app-arch/libarchive/metadata.xml
@@ -18,9 +18,6 @@
 		<flag name="e2fsprogs">
 			Use file flags from <pkg>sys-fs/e2fsprogs</pkg> headers instead of <pkg>virtual/os-headers</pkg> headers
 		</flag>
-		<flag name="lz4">
-			Enable support for LZ4 compression using <pkg>app-arch/lz4</pkg>
-		</flag>
 		<flag name="nettle">
 			Use <pkg>dev-libs/nettle</pkg> as crypto backend
 		</flag>
diff --git a/app-arch/zstd/metadata.xml b/app-arch/zstd/metadata.xml
index 82079cb18aea..b9782eebc304 100644
--- a/app-arch/zstd/metadata.xml
+++ b/app-arch/zstd/metadata.xml
@@ -5,11 +5,6 @@
     <email>patrick@gentoo.org</email>
     <name>Patrick Lauer</name>
   </maintainer>
-  <use>
-    <flag name="lz4">
-      Enable support for LZ4 compression using <pkg>app-arch/lz4</pkg>
-    </flag>
-  </use>
   <upstream>
     <remote-id type="github">facebook/zstd</remote-id>
   </upstream>
diff --git a/app-backup/fsarchiver/metadata.xml b/app-backup/fsarchiver/metadata.xml
index 3d248f851ebd..aa5f1ad3b52d 100644
--- a/app-backup/fsarchiver/metadata.xml
+++ b/app-backup/fsarchiver/metadata.xml
@@ -2,9 +2,6 @@
 <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
 <pkgmetadata>
 	<!-- maintainer-needed -->
-	<use>
-		<flag name="lz4">Enable lz4 compression support</flag>
-	</use>
 	<upstream>
 		<remote-id type="sourceforge">fsarchiver</remote-id>
 		<remote-id type="github">fdupoux/fsarchiver</remote-id>
diff --git a/app-emulation/spice/metadata.xml b/app-emulation/spice/metadata.xml
index 0f32fa2a88cf..ee309bddf45f 100644
--- a/app-emulation/spice/metadata.xml
+++ b/app-emulation/spice/metadata.xml
@@ -6,7 +6,6 @@
 		<name>Gentoo Virtualization Project</name>
 	</maintainer>
 	<use>
-		<flag name="lz4">Enable support for LZ4 compression using <pkg>app-arch/lz4</pkg></flag>
 		<flag name="smartcard">Enable smartcard remoting using <pkg>app-emulation/libcacard</pkg></flag>
 	</use>
 </pkgmetadata>
diff --git a/dev-libs/c-blosc/metadata.xml b/dev-libs/c-blosc/metadata.xml
index 4ce6ebd129d5..2b3831ea197b 100644
--- a/dev-libs/c-blosc/metadata.xml
+++ b/dev-libs/c-blosc/metadata.xml
@@ -13,7 +13,6 @@
 	or in-memory, but also to accelerate memory-bound computations.
 	</longdescription>
 	<use>
-		<flag name="lz4">Enable lz4 compression</flag>
 		<flag name="snappy">Enable snappy compression</flag>
 	</use>
 	<upstream>
diff --git a/dev-python/fastparquet/metadata.xml b/dev-python/fastparquet/metadata.xml
index 161302662a03..0866e1d45e83 100644
--- a/dev-python/fastparquet/metadata.xml
+++ b/dev-python/fastparquet/metadata.xml
@@ -19,7 +19,6 @@
   </upstream>
   <use>
     <flag name="brotli">Enable support for brotli compression</flag>    
-    <flag name="lz4">Enable support for lz4 compression</flag>
     <flag name="snappy">Enable support for snappy compression</flag>
   </use>
 </pkgmetadata>
diff --git a/dev-util/squashdelta/metadata.xml b/dev-util/squashdelta/metadata.xml
index 1001cf9123ee..ef0fca903aa9 100644
--- a/dev-util/squashdelta/metadata.xml
+++ b/dev-util/squashdelta/metadata.xml
@@ -1,9 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
 <pkgmetadata>
-	<use>
-		<flag name="lz4">Enable support for LZ4 compression using <pkg>app-arch/lz4</pkg></flag>
-	</use>
 	<maintainer type="person">
 		<email>mgorny@gentoo.org</email>
 		<name>Michał Górny</name>
diff --git a/dev-util/squashmerge/metadata.xml b/dev-util/squashmerge/metadata.xml
index 8c6675d140f4..0823857e76f4 100644
--- a/dev-util/squashmerge/metadata.xml
+++ b/dev-util/squashmerge/metadata.xml
@@ -1,9 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
 <pkgmetadata>
-	<use>
-		<flag name="lz4">Enable support for LZ4 compression using <pkg>app-arch/lz4</pkg></flag>
-	</use>
 	<maintainer type="person">
 		<email>mgorny@gentoo.org</email>
 		<name>Michał Górny</name>
diff --git a/net-analyzer/wireshark/metadata.xml b/net-analyzer/wireshark/metadata.xml
index 17945000941a..03dc8e4024ec 100644
--- a/net-analyzer/wireshark/metadata.xml
+++ b/net-analyzer/wireshark/metadata.xml
@@ -39,7 +39,6 @@ be exported to XML, PostScript®, CSV, or plain text.
 <flag name="dumpcap">Install dumpcap, to dump network traffic from inside wireshark</flag>
 <flag name="editcap">Install editcap, to edit and/or translate the format of capture files</flag>
 <flag name="libxml2">Use <pkg>dev-libs/libxml2</pkg> for handling XML configuration in dissectors</flag>
-<flag name="lz4">Use <pkg>app-arch/lz4</pkg> for compression/decompression</flag>
 <flag name="maxminddb">Use <pkg>dev-libs/libmaxminddb</pkg> for IP address geolocation</flag>
 <flag name="mergecap">Install mergecap, to merge two or more capture files into one</flag>
 <flag name="minizip">Build with zip file compression support</flag>
diff --git a/net-mail/dovecot/metadata.xml b/net-mail/dovecot/metadata.xml
index d8223dea238d..b28b2502b030 100644
--- a/net-mail/dovecot/metadata.xml
+++ b/net-mail/dovecot/metadata.xml
@@ -12,7 +12,6 @@
     <flag name="vpopmail">Add vpopmail support</flag>
     <flag name="lucene">Add lucene full text search (FTS) support using <pkg>dev-cpp/clucene</pkg></flag>
     <flag name="lzma">Add support for lzma (de)compression</flag>
-    <flag name="lz4">Add support for lz4 (de)compression</flag>
     <flag name="solr">Add solr full text search (FTS) support</flag>
     <flag name="textcat">Add libtextcat language guessing support for full text search (FTS)</flag>
   </use>
diff --git a/net-misc/spice-gtk/metadata.xml b/net-misc/spice-gtk/metadata.xml
index 72afe048bc6a..34612a8b0bad 100644
--- a/net-misc/spice-gtk/metadata.xml
+++ b/net-misc/spice-gtk/metadata.xml
@@ -9,8 +9,6 @@
 		<flag name="dbus">Support for desktop integration such as
 			automounting and other APIs exposed by your DE via D-Bus</flag>
 		<flag name="gtk3">Build the spice client (spicy), requires <pkg>x11-libs/gtk+</pkg>:3</flag>
-		<flag name="lz4">Enable support for LZ4 compression using
-			<pkg>app-arch/lz4</pkg></flag>
 		<flag name="policykit">Enable <pkg>sys-auth/polkit</pkg> support for the
 			usbredir acl helper</flag>
 		<flag name="usbredir">Use <pkg>sys-apps/usbredir</pkg> to redirect USB
diff --git a/net-vpn/openconnect/metadata.xml b/net-vpn/openconnect/metadata.xml
index aa05046a5fd4..1f2957923f0f 100644
--- a/net-vpn/openconnect/metadata.xml
+++ b/net-vpn/openconnect/metadata.xml
@@ -13,7 +13,6 @@
 		<flag name="gssapi">Build GSSAPI support</flag>
 		<flag name="java">Build JNI bindings using jni.h</flag>
 		<flag name="libproxy">Enable proxy support</flag>
-		<flag name="lz4">Enable support for lz4 compression</flag>
 		<flag name="stoken">Enable stoken support</flag>
 	</use>
 </pkgmetadata>
diff --git a/net-vpn/openvpn/metadata.xml b/net-vpn/openvpn/metadata.xml
index 2f1d7181933c..4d0024cb2edf 100644
--- a/net-vpn/openvpn/metadata.xml
+++ b/net-vpn/openvpn/metadata.xml
@@ -15,7 +15,6 @@ networks using an encrypted tunnel.</longdescription>
   <use>
     <flag name="down-root">Enable the down-root plugin</flag>
     <flag name="iproute2">Enabled iproute2 support instead of net-tools</flag>
-    <flag name="lz4">Enable LZ4 support</flag>
     <flag name="mbedtls">Use mbed TLS instead of OpenSSL</flag>
     <flag name="pkcs11">Enable PKCS#11 smartcard support</flag>
     <flag name="plugins">Enable the OpenVPN plugin system</flag>
diff --git a/sys-fs/squashfs-tools-ng/metadata.xml b/sys-fs/squashfs-tools-ng/metadata.xml
index b1a0267dd913..a98fd7a51d69 100644
--- a/sys-fs/squashfs-tools-ng/metadata.xml
+++ b/sys-fs/squashfs-tools-ng/metadata.xml
@@ -6,7 +6,6 @@
 		<name>Matt Turner</name>
 	</maintainer>
 	<use>
-		<flag name="lz4">Enable support for LZ4 compression using <pkg>app-arch/lz4</pkg></flag>
 		<flag name="xz">Enable support for XZ ("LZMA2") compression using <pkg>app-arch/xz-utils</pkg></flag>
 	</use>
 	<upstream>
diff --git a/sys-fs/squashfs-tools/metadata.xml b/sys-fs/squashfs-tools/metadata.xml
index afefbbcf3f0b..bf36ab7e6bbe 100644
--- a/sys-fs/squashfs-tools/metadata.xml
+++ b/sys-fs/squashfs-tools/metadata.xml
@@ -6,7 +6,6 @@
 <name>Gentoo LiveCD Project</name>
 </maintainer>
 <use>
-<flag name="lz4">Enable support for LZ4 compression using <pkg>app-arch/lz4</pkg></flag>
 <flag name="xz">Enable support for XZ ("LZMA2") compression using <pkg>app-arch/xz-utils</pkg></flag>
 </use>
 <upstream>
diff --git a/sys-fs/squashfuse/metadata.xml b/sys-fs/squashfuse/metadata.xml
index 4b36f192fd0d..cdbecb75705a 100644
--- a/sys-fs/squashfuse/metadata.xml
+++ b/sys-fs/squashfuse/metadata.xml
@@ -11,7 +11,4 @@
 		<email>zmedico@gentoo.org</email>
 		<name>Zac Medico</name>
 	</maintainer>
-	<use>
-		<flag name="lz4">Enable support for lz4 compression</flag>
-	</use>
 </pkgmetadata>
diff --git a/x11-wm/xpra/metadata.xml b/x11-wm/xpra/metadata.xml
index 81ce7aa32a08..9ac095e40d67 100644
--- a/x11-wm/xpra/metadata.xml
+++ b/x11-wm/xpra/metadata.xml
@@ -16,7 +16,6 @@
 	<flag name="enc_ffmpeg">Enable advanced ffmpeg/libav encoder support</flag>
 	<flag name="enc_x264">Enable x264 encoder support</flag>
 	<flag name="enc_x265">Enable x265 encoder support</flag>
-	<flag name="lz4">Enable support for lz4 compression</flag>
 	<flag name="pillow">Enable pillow support</flag>
 	<flag name="server">Build server-side code</flag>
 	<flag name="vpx">Enable vpx image format support</flag>
-- 
2.23.0

Re: [gentoo-dev] [PATCH 1/2] use.desc: Make lz4 a global flag

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

On Sun, 2019-09-15 at 16:12 +0200, Michał Górny wrote:
> The 'lz4' flag is used consistently for the LZ4 compression algorithm
> in 23 packages.  Make it a global flag.
> 

Please forgive me, it's 21.  My 'quse' was too broad.

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]

Re: [gentoo-dev] [PATCH 1/2] use.desc: Make lz4 a global flag

[Matt Turner]

On Sun, Sep 15, 2019 at 7:12 AM Michał Górny <mgorny@gentoo.org> wrote:
>
> The 'lz4' flag is used consistently for the LZ4 compression algorithm
> in 23 packages.  Make it a global flag.

Good idea. Ack for both this and snappy.

Re: [gentoo-dev] [PATCH 1/2] use.desc: Make lz4 a global flag

[Aaron Bauman]

[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]

On Sun, Sep 15, 2019 at 04:12:31PM +0200, Michał Górny wrote:
> The 'lz4' flag is used consistently for the LZ4 compression algorithm
> in 23 packages.  Make it a global flag.
> 
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
>  profiles/use.desc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/profiles/use.desc b/profiles/use.desc
> index 136d86900685..0969d8f8b7b5 100644
> --- a/profiles/use.desc
> +++ b/profiles/use.desc
> @@ -182,6 +182,7 @@ lm-sensors - Add linux lm-sensors (hardware sensors) support
>  lua - Enable Lua scripting support
>  luajit - Use dev-lang/luajit instead of dev-lang/lua (ineffective with USE=-lua)
>  lzma - Support for LZMA (de)compression algorithm
> +lz4 - Enable support for lz4 compression (as implemented in app-arch/lz4)
>  lzo - Enable support for lzo compression
>  m17n-lib - Enable m17n-lib support
>  mad - Add support for mad (high-quality mp3 decoder library and cli frontend)
> -- 
> 2.23.0
> 
>

This is also good from a security perspective with identifying packages relying
on lz4.

Acked-by: Aaron Bauman <bman@gentoo.org>

-- 
Cheers,
Aaron

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]