From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-88547-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 4FBCC138334
	for <garchives@archives.gentoo.org>; Fri, 13 Sep 2019 18:47:10 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 5F0A9E0A95;
	Fri, 13 Sep 2019 18:47:07 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 0226BE09EA
	for <gentoo-dev@lists.gentoo.org>; Fri, 13 Sep 2019 18:47:07 +0000 (UTC)
Received: from sf (tunnel547699-pt.tunnel.tserv1.lon2.ipv6.he.net [IPv6:2001:470:1f1c:3e6::2])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: slyfox)
	by smtp.gentoo.org (Postfix) with ESMTPSA id A146A34B121;
	Fri, 13 Sep 2019 18:47:04 +0000 (UTC)
Date: Fri, 13 Sep 2019 19:46:58 +0100
From: Sergei Trofimovich <slyfox@gentoo.org>
To: Ulrich Mueller <ulm@gentoo.org>, Manoj Gupta <manojgupta@google.com>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [PATCH] toolchain-funcs: Add tc-ld-is-lld
 helper.
Message-ID: <20190913194658.17a87ce8@sf>
In-Reply-To: <w6g5zlws0wh.fsf@kph.uni-mainz.de>
References: <20190912113240.226571-1-manojgupta@google.com>
	<CAH=QcsjVD67uipu8HDcOYo-O6CW45YsFXiZ3dHrSfbk5ov3YYg@mail.gmail.com>
	<w6ga7b8s1vr.fsf@kph.uni-mainz.de>
	<CAH=QcsgNQOVnSXpzcmkFAX+R4vC8Fq9cRSZz+CLCMG-i7v0oaA@mail.gmail.com>
	<w6g5zlws0wh.fsf@kph.uni-mainz.de>
X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Archives-Salt: 59d4cbe7-e078-42e7-9b83-4312b6a3b33f
X-Archives-Hash: 330c6838b715158bb954c5df2d512bec

On Fri, 13 Sep 2019 16:53:34 +0200
Ulrich Mueller <ulm@gentoo.org> wrote:

> >>>>> On Fri, 13 Sep 2019, Manoj Gupta wrote:  
> 
> > Thanks for the review. I did it this way to make this an exact copy of
> > tc-ld-is-gold function above it except the LLD checks.
> > Should I also change the  tc-ld-is-gold function?  
> 
> Good question. Presumably the eclass maintainers should have the last
> word on this.

I've pushed the change as-is. You can send follow-up patch. Or I'll get to
to it later.

-- 

  Sergei