From: Sergei Trofimovich <slyfox@gentoo.org>
To: Ulrich Mueller <ulm@gentoo.org>, Manoj Gupta <manojgupta@google.com>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [PATCH] toolchain-funcs: Add tc-ld-is-lld helper.
Date: Fri, 13 Sep 2019 19:46:58 +0100 [thread overview]
Message-ID: <20190913194658.17a87ce8@sf> (raw)
In-Reply-To: <w6g5zlws0wh.fsf@kph.uni-mainz.de>
On Fri, 13 Sep 2019 16:53:34 +0200
Ulrich Mueller <ulm@gentoo.org> wrote:
> >>>>> On Fri, 13 Sep 2019, Manoj Gupta wrote:
>
> > Thanks for the review. I did it this way to make this an exact copy of
> > tc-ld-is-gold function above it except the LLD checks.
> > Should I also change the tc-ld-is-gold function?
>
> Good question. Presumably the eclass maintainers should have the last
> word on this.
I've pushed the change as-is. You can send follow-up patch. Or I'll get to
to it later.
--
Sergei
next prev parent reply other threads:[~2019-09-13 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 11:32 [gentoo-dev] [PATCH] toolchain-funcs: Add tc-ld-is-lld helper Manoj Gupta
2019-09-13 14:11 ` [gentoo-dev] " Manoj Gupta
2019-09-13 14:32 ` Ulrich Mueller
2019-09-13 14:38 ` Manoj Gupta
2019-09-13 14:53 ` Ulrich Mueller
2019-09-13 18:46 ` Sergei Trofimovich [this message]
2019-09-13 18:44 ` Sergei Trofimovich
2019-09-13 18:47 ` Manoj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913194658.17a87ce8@sf \
--to=slyfox@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=manojgupta@google.com \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox