From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id A54B5138334 for ; Thu, 12 Sep 2019 15:36:38 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 04D72E08F1; Thu, 12 Sep 2019 15:36:31 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8B376E08EC for ; Thu, 12 Sep 2019 15:36:30 +0000 (UTC) Received: from whubbs1.gaikai.biz (unknown [100.42.103.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: williamh) by smtp.gentoo.org (Postfix) with ESMTPSA id 9184434B0BE; Thu, 12 Sep 2019 15:36:29 +0000 (UTC) Received: (nullmailer pid 23968 invoked by uid 1000); Thu, 12 Sep 2019 15:36:26 -0000 Date: Thu, 12 Sep 2019 10:36:26 -0500 From: William Hubbs To: gentoo-dev@lists.gentoo.org Cc: antarus@gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules Message-ID: <20190912153626.GA23846@whubbs1.dev.av1.gaikai.org> Mail-Followup-To: gentoo-dev@lists.gentoo.org, antarus@gentoo.org References: <20190911172128.18885-1-williamh@gentoo.org> <20190911172128.18885-2-williamh@gentoo.org> <20190912000525.GB21591@whubbs1.dev.av1.gaikai.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Archives-Salt: 3beb8634-d3e7-408e-8010-2d473eea37c2 X-Archives-Hash: 3780198113ae1b62f16d4ade02c4ec8f --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 11, 2019 at 05:28:22PM -0700, Alec Warner wrote: > On Wed, Sep 11, 2019 at 5:05 PM William Hubbs wrote: >=20 > > On Wed, Sep 11, 2019 at 04:31:00PM -0700, Alec Warner wrote: > > > On Wed, Sep 11, 2019 at 10:28 AM William Hubbs > > wrote: > > > > > > > Copyright: Sony Interactive Entertainment Inc. > > > > Signed-off-by: William Hubbs > > > > --- > > > > eclass/go-module.eclass | 76 +++++++++++++++++++++++++++++++++++++= ++++ > > > > 1 file changed, 76 insertions(+) > > > > create mode 100644 eclass/go-module.eclass > > > > > > > > diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass > > > > new file mode 100644 > > > > index 00000000000..7009fcd3beb > > > > --- /dev/null > > > > +++ b/eclass/go-module.eclass > > > > @@ -0,0 +1,76 @@ > > > > +# Copyright 1999-2015 Gentoo Foundation > > > > +# Distributed under the terms of the GNU General Public License v2 > > > > + > > > > +# @ECLASS: go-module.eclass > > > > +# @MAINTAINER: > > > > +# William Hubbs > > > > +# @SUPPORTED_EAPIS: 7 > > > > +# @BLURB: basic eclass for building software written in the go > > > > +# programming language that uses go modules. > > > > +# @DESCRIPTION: > > > > +# This eclass provides a convenience src_prepare() phase and some > > basic > > > > +# settings needed for all software written in the go programming > > > > +# language that uses go modules. > > > > +# > > > > +# You will know the software you are packaging uses modules because > > > > +# it will have files named go.sum and go.mod in its top-level sour= ce > > > > +# directory. If it does not have these files, use the golang-* > > eclasses. > > > > +# > > > > +# If the software you are packaging uses modules, the next questio= n is > > > > +# whether it has a directory named "vendor" at the top-level of the > > > > source tree. > > > > +# > > > > +# If it doesn't, you need to create a tarball of what would be in = the > > > > +# vendor directory and mirror it locally. This is done with the > > > > +# following commands if upstream is using a git repository: > > > > +# > > > > +# @CODE: > > > > +# > > > > +# $ cd /my/clone/of/upstream > > > > +# $ git checkout > > > > +# $ go mod vendor > > > > +# $ tar cvf project-version-vendor.tar.gz vendor > > > > +# > > > > +# @CODE: > > > > +# > > > > +# Other than this, all you need to do is inherit this eclass then > > > > +# make sure the exported src_prepare function is run. > > > > + > > > > +case ${EAPI:-0} in > > > > + 7) ;; > > > > + *) die "${ECLASS} API in EAPI ${EAPI} not yet established." > > > > +esac > > > > + > > > > +if [[ -z ${_GO_MODULE} ]]; then > > > > + > > > > +_GO_MODULE=3D1 > > > > + > > > > +BDEPEND=3D">=3Ddev-lang/go-1.12" > > > > + > > > > +# Do not download dependencies from the internet > > > > +# make build output verbose by default > > > > +export GOFLAGS=3D"-mod=3Dvendor -v -x" > > > > + > > > > +# Do not complain about CFLAGS etc since go projects do not use th= em. > > > > +QA_FLAGS_IGNORED=3D'.*' > > > > + > > > > +# Upstream does not support stripping go packages > > > > +RESTRICT=3D"strip" > > > > > > > > > > https://golang.org/cmd/link/ implies you can pass -s -w to the compil= er > > to > > > reduce binary size. > > > > > > Does that not work in portage by default, or does upstream just consi= der > > > that bad practice? > > > > I haven't tried it, but here are the definitions of -s and -w. > > > > -s Omit the symbol table and debug information. > > -w Omit the DWARF symbol table. > > > > These look like Go's equivalent of stripping the binaries, and I have my > > doubts as to whether we should force this. > > >=20 > I don't care if you strip or not (I'm not even sure portage knows how to = do > it for go binaries) but I'm fairly sure the reason isn't because "upstream > does not support stripping go binaries" because they clearly do...unless > upstream is portage here...? Well, go binaries aren't supposed to be stripped using strip(1), which is how portage strips binaries. You strip go binaries by passing -s and -w to ldflags, so it has to be done during the build. In order to do it right I would have to have a pms-compatible way to check restrictions/features, and there isn't one that I'm aware of. If there is a way to do this, I'm all ears, or I can update the comment in the eclass. William --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTVeuxEZo4uUHOkQAluVBb0MMRlOAUCXXpl8QAKCRBuVBb0MMRl OHhrAJ9gdZGK895Cfb9Z1xRIMkNBQPMoSQCfY3NuesX3olKuSdy393MHaOWAG2E= =j21v -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--