From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 54269138334 for ; Thu, 5 Sep 2019 19:26:59 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 84D08E077A; Thu, 5 Sep 2019 19:26:53 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 27F34E0536 for ; Thu, 5 Sep 2019 19:26:53 +0000 (UTC) Received: from katipo2.lan (unknown [203.86.205.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kentnl) by smtp.gentoo.org (Postfix) with ESMTPSA id C1ED934ACF3 for ; Thu, 5 Sep 2019 19:26:51 +0000 (UTC) Date: Fri, 6 Sep 2019 07:26:42 +1200 From: Kent Fredric To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ Message-ID: <20190906072642.4a25357b@katipo2.lan> In-Reply-To: References: <1567619929.63486fef43c2e0dee3b4128db18fd1a6b4bf9381.tupone@gentoo> <6221fceb9ac4f3451a3a43e39141102f489a830d.camel@gentoo.org> <1860939b-1751-061d-c593-59deb20f05e7@gentoo.org> <7dd9f947-b3b1-a685-29df-0a59a19ebcbe@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/vQf8VR8XBjAo00ns=YeZlKd"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Archives-Salt: 93698cae-d2aa-4d71-b0cb-64c1b905e860 X-Archives-Hash: 6469a0b163633b750bcaae0d2487f4e5 --Sig_/vQf8VR8XBjAo00ns=YeZlKd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 5 Sep 2019 09:04:23 -0500 Gordon Pettey wrote: > You'll note the bit you quoted in defense of skipping review says > "changes", and the bit about new eclasses says "do not skip this step". Emphasis added: ----- BEFORE committing a NEW eclass to the tree, it SHOULD be emailed to the gentoo-dev mailing list with a justification and a proposed implementation. DO NOT SKIP this step =E2=80=94 sometimes a better implementation or an alternative which does not require a new eclass will be suggested.=20 ----- If its mandatory, it must say "MUST" not "SHOULD", SHOULD is a suggestion, following a suggestion with an imperative just adds predictable confusion. Either fix the "should", or drop the "DO NOT SKIP". Otherwise you're just giving mixed messages. --Sig_/vQf8VR8XBjAo00ns=YeZlKd Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEgdrME8Lrmai3DXYJda6SGagVg7UFAl1xYXIACgkQda6SGagV g7XZiA/+KZErOd0qHIHF57X5nyn7fs17QH3YkWeVkFqnaKoyOOpTtXCFWu9eT8yX SFVbpCtbzGKIkk62lmfFCbDHFZcbzkthy7yKuic+MWjqQ/LDYYDPdQ14gMajvj2L mI+7Gd3Ug4/PogvbB8sqijRN/IFjNMUsYtUZVBW8mN+lvDSOECVWcCSXHjrLEm2R F3AOxmmlsoRg0E3sP8yNR0nX/gqww3EyluFd+OSkDOmioVzbMOz8JILuyh3/LjHI gH5tCm6OLnkNdTWjr5rzmmHhVgKAz5HyV3IFE4KC2hGIRNxppzicpWHgWdlOQDMJ rMqWLigDI39Ej7Ic3NWanlr4HTQt0BNJqou0GZS+syEYGHhEQ/t9Q5rLzry/3mHs SMNBNJ/UzBQIebineFnpgygamU3zXOnQzjcWUtKL5GgjD8wGkDtLS+0PRfLy948c OHiYXwmfC1AlC4Z9h8V+/R7E+LLZBpuRtPwRP8m6LK/Ce56sJgdluLfKEjo+At2Y QVhG/gCyWVzlTAHX40lRDjdjo75GQzRSTG8dtu5S9xOiQYCbbSpORodjYRcPPeXL 83Y0dwgPvx7uCGJc/1bKPxHhd1YGYDx3T6KxDvzg8wH4zUd9AaBPGezksSGKamzO ofn13KipdMLlftlSV3dfeKE+a3xwmtSu8Ws6G+LDLHAwREqeeL0= =PzLo -----END PGP SIGNATURE----- --Sig_/vQf8VR8XBjAo00ns=YeZlKd--