From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7C442138334 for ; Thu, 5 Sep 2019 19:28:34 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B0C33E077A; Thu, 5 Sep 2019 19:28:31 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 37E19E0536 for ; Thu, 5 Sep 2019 19:28:31 +0000 (UTC) Received: from symphony.aura-online.co.uk (154.189.187.81.in-addr.arpa [81.187.189.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: chewi) by smtp.gentoo.org (Postfix) with ESMTPSA id 011CC34ACF5 for ; Thu, 5 Sep 2019 19:28:29 +0000 (UTC) Date: Thu, 5 Sep 2019 20:28:14 +0100 From: James Le Cuirot To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ Message-ID: <20190905202814.0bc424d5@symphony.aura-online.co.uk> In-Reply-To: <20190906072642.4a25357b@katipo2.lan> References: <1567619929.63486fef43c2e0dee3b4128db18fd1a6b4bf9381.tupone@gentoo> <6221fceb9ac4f3451a3a43e39141102f489a830d.camel@gentoo.org> <1860939b-1751-061d-c593-59deb20f05e7@gentoo.org> <7dd9f947-b3b1-a685-29df-0a59a19ebcbe@gentoo.org> <20190906072642.4a25357b@katipo2.lan> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/jo2hPIpi49j0iLCvo9A=TdF"; protocol="application/pgp-signature" X-Archives-Salt: ce6030ea-b8e1-474c-85bf-c50bb93bb76c X-Archives-Hash: 02d47768d7a73d54f60f71741ca163cc --Sig_/jo2hPIpi49j0iLCvo9A=TdF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 6 Sep 2019 07:26:42 +1200 Kent Fredric wrote: > On Thu, 5 Sep 2019 09:04:23 -0500 > Gordon Pettey wrote: >=20 > > You'll note the bit you quoted in defense of skipping review says > > "changes", and the bit about new eclasses says "do not skip this step".= =20 >=20 > Emphasis added: >=20 > ----- > BEFORE committing a NEW eclass to the tree, it SHOULD be emailed to the > gentoo-dev mailing list with a justification and a proposed > implementation. DO NOT SKIP this step =E2=80=94 sometimes a better > implementation or an alternative which does not require a new eclass > will be suggested.=20 > ----- >=20 >=20 > If its mandatory, it must say "MUST" not "SHOULD", SHOULD is a > suggestion, following a suggestion with an imperative just adds > predictable confusion. >=20 > Either fix the "should", or drop the "DO NOT SKIP". >=20 > Otherwise you're just giving mixed messages. +1 --=20 James Le Cuirot (chewi) Gentoo Linux Developer --Sig_/jo2hPIpi49j0iLCvo9A=TdF Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEPxcZ3tkwcedKm2a8EiZBXQDdMTcFAl1xYc4ACgkQEiZBXQDd MTdu/BAArU/LjRhDVG1KUvIyd3QoeJavNjOFQS98fD4tfUhInbjVQ49CTZSP0NJu 4iJ7GRqtqnevqMWK39JQ/Ij0gpkWxWQcUnV2WT4bqxG308cX2rIacxyxfBii97cU vpOq9rIRPHEyajLL6jYw6ZKkRCz2Xg3ZmohImJZi9/rgFGDoTZPLjVJccouwsbFn pdbHu7LDQAbp/spDYkX/g7SFVsAj/72X7uav7wPh6Ls2vHo56PWch8dYcQ040AbM HOPN4brImB9S4zlWOcw6VxAisE8vAWykCROZS+bARZrn2FTiDrROYo6SH/axv08V rutpI8cPliuqxPVtWOeNzCAuCPRAIxz5M4ljnCe47TdS7FLkzi8q6uQz3aJrS1MU LM14ZONbOr6Gx/S69E6etgMECmL+luiwuL9SH5RwOyplEgiel9WtODSZuIXDuM5V mjsme8Y37mbfdX+0ORgQupXYgvUN7WBE4SiQt9ifV0EvmS0Xms3gJT1uy+a9fplA 4tNCnhlaDP+8qLgoaAJGdqFcm+9J3PIyiLJO9Qovg1/L+aXjhu9tzzzh0Zxkurh3 itETHV0t0BZW/PVDO/cCTTT6NCM1Auoymgc6avudhVwhYVHAS175rJNhVAjMZs5z +vKHCPS0n3P37NMrOzqUKP4qO/XrBZW2Uxhs26Fn9L60smJdDuA= =Xizd -----END PGP SIGNATURE----- --Sig_/jo2hPIpi49j0iLCvo9A=TdF--