[gentoo-dev] Patch series: User and group for amavisd-new (UID/GID 333)

[gentoo-dev] Patch series: User and group for amavisd-new (UID/GID 333)

[Ralph Seichter]

As suggested by Michael Orlitzky, I am submitting my patches to create
a group and user 'amavis' according to GLEP 81 for review.

-Ralph

[gentoo-dev] [PATCH 1/2] acct-group/amavis: new group (GID 333)

[Ralph Seichter]

Signed-off-by: Ralph Seichter <gentoo@seichter.de>
---
 acct-group/amavis/amavis-0.ebuild |  9 +++++++++
 acct-group/amavis/metadata.xml    | 12 ++++++++++++
 2 files changed, 21 insertions(+)
 create mode 100644 acct-group/amavis/amavis-0.ebuild
 create mode 100644 acct-group/amavis/metadata.xml

diff --git a/acct-group/amavis/amavis-0.ebuild b/acct-group/amavis/amavis-0.ebuild
new file mode 100644
index 00000000000..edfeefae77b
--- /dev/null
+++ b/acct-group/amavis/amavis-0.ebuild
@@ -0,0 +1,9 @@
+# Copyright 2019 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=7
+
+inherit acct-group
+
+ACCT_GROUP_ID=333
+DESCRIPTION="Group for mail-filter/amavisd-new"
diff --git a/acct-group/amavis/metadata.xml b/acct-group/amavis/metadata.xml
new file mode 100644
index 00000000000..68dee4eb504
--- /dev/null
+++ b/acct-group/amavis/metadata.xml
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
+<pkgmetadata>
+	<maintainer type="person">
+		<email>mjo@gentoo.org</email>
+		<name>Michael Orlitzky</name>
+	</maintainer>
+	<maintainer type="person">
+		<email>gentoo@seichter.de</email>
+		<name>Ralph Seichter</name>
+	</maintainer>
+</pkgmetadata>
-- 
2.21.0

[gentoo-dev] [PATCH 2/2] acct-user/amavis: new user (UID 333)

[Ralph Seichter]

Signed-off-by: Ralph Seichter <gentoo@seichter.de>
---
 acct-user/amavis/amavis-0.ebuild | 12 ++++++++++++
 acct-user/amavis/metadata.xml    | 12 ++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 acct-user/amavis/amavis-0.ebuild
 create mode 100644 acct-user/amavis/metadata.xml

diff --git a/acct-user/amavis/amavis-0.ebuild b/acct-user/amavis/amavis-0.ebuild
new file mode 100644
index 00000000000..8720ccf79bf
--- /dev/null
+++ b/acct-user/amavis/amavis-0.ebuild
@@ -0,0 +1,12 @@
+# Copyright 2019 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=7
+
+inherit acct-user
+
+ACCT_USER_ID=333
+ACCT_USER_GROUPS=( amavis )
+DESCRIPTION="User for mail-filter/amavisd-new"
+
+acct-user_add_deps
diff --git a/acct-user/amavis/metadata.xml b/acct-user/amavis/metadata.xml
new file mode 100644
index 00000000000..68dee4eb504
--- /dev/null
+++ b/acct-user/amavis/metadata.xml
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
+<pkgmetadata>
+	<maintainer type="person">
+		<email>mjo@gentoo.org</email>
+		<name>Michael Orlitzky</name>
+	</maintainer>
+	<maintainer type="person">
+		<email>gentoo@seichter.de</email>
+		<name>Ralph Seichter</name>
+	</maintainer>
+</pkgmetadata>
-- 
2.21.0

Re: [gentoo-dev] Patch series: User and group for amavisd-new (UID/GID 333)

[Mike Gilbert]

On Sat, Aug 3, 2019 at 2:43 PM Ralph Seichter <gentoo@seichter.de> wrote:
>
> As suggested by Michael Orlitzky, I am submitting my patches to create
> a group and user 'amavis' according to GLEP 81 for review.

Looks like you grabbed the ID from Arch? Looks good to me.

Re: [gentoo-dev] Patch series: User and group for amavisd-new (UID/GID 333)

[Ralph Seichter]

* Mike Gilbert:

> Looks like you grabbed the ID from Arch?

Indeed, Arch Linux uses 333 as well.

-Ralph

Re: [gentoo-dev] [PATCH 2/2] acct-user/amavis: new user (UID 333)

[Michael Orlitzky]

On 8/3/19 2:43 PM, Ralph Seichter wrote:
> +
> +EAPI=7
> +
> +inherit acct-user
> +
> +ACCT_USER_ID=333
> +ACCT_USER_GROUPS=( amavis )
> +DESCRIPTION="User for mail-filter/amavisd-new"
> +
> +acct-user_add_deps

The existing user created by the amavisd-new ebuilds has a home
directory of /var/amavis. This was done to match the default value of
$MYHOME in the upstream config file, but is wrong: the FHS says that
applications should not create top-level directories in /var for their
own use. The right place for amavis' data is under /var/lib/amavis. And
now is certainly the time to make that change if we're ever going to
make it.

If we were to do so a month ago, we would have set the user's home
directory to /dev/null and used keepdir on /var/lib/amavis, because
otherwise the "home" directory itself would be left untracked by the
package manager. However, the acct-user eclass is smart enough to
keepdir the new home directory for us. That makes me think that we
should set

  ACCT_USER_HOME=/var/lib/amavis

to avoid the extra step. Does anyone see a downside to that, versus
leaving the homedir at /dev/null and creating the "extra" directory
under /var/lib?

Re: [gentoo-dev] [PATCH 2/2] acct-user/amavis: new user (UID 333)

[Michael Orlitzky]

On 8/3/19 7:49 PM, Michael Orlitzky wrote:
>
> That makes me think that we should set
> 
>   ACCT_USER_HOME=/var/lib/amavis
> 

We'll do this during the next version/revision bump, keeping everything
else the same.